[UPDATE] Add return statements of parent class

Adrien Schaegis · Adrien Schaegis · commit 3458674615f3 · 2016-04-11T14:23:06.000+01:00
diff --git a/Command/MigrationsDiffDoctrineCommand.php b/Command/MigrationsDiffDoctrineCommand.php
@@ -17,6 +17,7 @@
 use Doctrine\Bundle\DoctrineBundle\Command\Proxy\DoctrineCommandHelper;
 use Doctrine\DBAL\Migrations\Tools\Console\Command\DiffCommand;
 use Doctrine\DBAL\Sharding\PoolingShardConnection;
+use LogicException;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
@@ -48,7 +49,7 @@ public function execute(InputInterface $input, OutputInterface $output)
         if ($input->getOption('shard')) {
             $connection = $this->getApplication()->getHelperSet()->get('db')->getConnection();
             if (!$connection instanceof PoolingShardConnection) {
-                throw new \LogicException(sprintf("Connection of EntityManager '%s' must implements shards configuration.", $input->getOption('em')));
+                throw new LogicException(sprintf("Connection of EntityManager '%s' must implements shards configuration.", $input->getOption('em')));
             }
 
             $connection->connect($input->getOption('shard'));
@@ -57,6 +58,6 @@ public function execute(InputInterface $input, OutputInterface $output)
         $configuration = $this->getMigrationConfiguration($input, $output);
         DoctrineCommand::configureMigrations($this->getApplication()->getKernel()->getContainer(), $configuration);
 
-        parent::execute($input, $output);
+        return parent::execute($input, $output);
     }
 }
diff --git a/Command/MigrationsExecuteDoctrineCommand.php b/Command/MigrationsExecuteDoctrineCommand.php
@@ -14,6 +14,7 @@
 
 namespace Doctrine\Bundle\MigrationsBundle\Command;
 
+use InvalidArgumentException;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Input\InputOption;
@@ -43,14 +44,14 @@ public function execute(InputInterface $input, OutputInterface $output)
     {
         // EM and DB options cannot be set at same time
         if (null !== $input->getOption('em') && null !== $input->getOption('db')) {
-            throw new \InvalidArgumentException('Cannot set both "em" and "db" for command execution.');
+            throw new InvalidArgumentException('Cannot set both "em" and "db" for command execution.');
         }
 
         Helper\DoctrineCommandHelper::setApplicationHelper($this->getApplication(), $input);
 
         $configuration = $this->getMigrationConfiguration($input, $output);
         DoctrineCommand::configureMigrations($this->getApplication()->getKernel()->getContainer(), $configuration);
-
-        parent::execute($input, $output);
+    
+        return parent::execute($input, $output);
     }
 }
diff --git a/Command/MigrationsGenerateDoctrineCommand.php b/Command/MigrationsGenerateDoctrineCommand.php
@@ -14,6 +14,7 @@
 
 namespace Doctrine\Bundle\MigrationsBundle\Command;
 
+use InvalidArgumentException;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Input\InputOption;
@@ -43,14 +44,14 @@ public function execute(InputInterface $input, OutputInterface $output)
     {
         // EM and DB options cannot be set at same time
         if (null !== $input->getOption('em') && null !== $input->getOption('db')) {
-            throw new \InvalidArgumentException('Cannot set both "em" and "db" for command execution.');
+            throw new InvalidArgumentException('Cannot set both "em" and "db" for command execution.');
         }
 
         Helper\DoctrineCommandHelper::setApplicationHelper($this->getApplication(), $input);
 
         $configuration = $this->getMigrationConfiguration($input, $output);
         DoctrineCommand::configureMigrations($this->getApplication()->getKernel()->getContainer(), $configuration);
-
-        parent::execute($input, $output);
+    
+        return parent::execute($input, $output);
     }
 }
diff --git a/Command/MigrationsLatestDoctrineCommand.php b/Command/MigrationsLatestDoctrineCommand.php
@@ -14,6 +14,7 @@
 
 namespace Doctrine\Bundle\MigrationsBundle\Command;
 
+use InvalidArgumentException;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Input\InputOption;
@@ -43,14 +44,14 @@ public function execute(InputInterface $input, OutputInterface $output)
     {
         // EM and DB options cannot be set at same time
         if (null !== $input->getOption('em') && null !== $input->getOption('db')) {
-            throw new \InvalidArgumentException('Cannot set both "em" and "db" for command execution.');
+            throw new InvalidArgumentException('Cannot set both "em" and "db" for command execution.');
         }
 
         Helper\DoctrineCommandHelper::setApplicationHelper($this->getApplication(), $input);
 
         $configuration = $this->getMigrationConfiguration($input, $output);
         DoctrineCommand::configureMigrations($this->getApplication()->getKernel()->getContainer(), $configuration);
-
-        parent::execute($input, $output);
+    
+        return parent::execute($input, $output);
     }
 }
diff --git a/Command/MigrationsMigrateDoctrineCommand.php b/Command/MigrationsMigrateDoctrineCommand.php
@@ -14,6 +14,7 @@
 
 namespace Doctrine\Bundle\MigrationsBundle\Command;
 
+use InvalidArgumentException;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Input\InputOption;
@@ -43,14 +44,14 @@ public function execute(InputInterface $input, OutputInterface $output)
     {
         // EM and DB options cannot be set at same time
         if (null !== $input->getOption('em') && null !== $input->getOption('db')) {
-            throw new \InvalidArgumentException('Cannot set both "em" and "db" for command execution.');
+            throw new InvalidArgumentException('Cannot set both "em" and "db" for command execution.');
         }
 
         Helper\DoctrineCommandHelper::setApplicationHelper($this->getApplication(), $input);
 
         $configuration = $this->getMigrationConfiguration($input, $output);
         DoctrineCommand::configureMigrations($this->getApplication()->getKernel()->getContainer(), $configuration);
 
-        parent::execute($input, $output);
+        return parent::execute($input, $output);
     }
 }
diff --git a/Command/MigrationsStatusDoctrineCommand.php b/Command/MigrationsStatusDoctrineCommand.php
@@ -14,6 +14,7 @@
 
 namespace Doctrine\Bundle\MigrationsBundle\Command;
 
+use InvalidArgumentException;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Input\InputOption;
@@ -43,14 +44,14 @@ public function execute(InputInterface $input, OutputInterface $output)
     {
         // EM and DB options cannot be set at same time
         if (null !== $input->getOption('em') && null !== $input->getOption('db')) {
-            throw new \InvalidArgumentException('Cannot set both "em" and "db" for command execution.');
+            throw new InvalidArgumentException('Cannot set both "em" and "db" for command execution.');
         }
 
         Helper\DoctrineCommandHelper::setApplicationHelper($this->getApplication(), $input);
 
         $configuration = $this->getMigrationConfiguration($input, $output);
         DoctrineCommand::configureMigrations($this->getApplication()->getKernel()->getContainer(), $configuration);
-
-        parent::execute($input, $output);
+    
+        return parent::execute($input, $output);
     }
 }
diff --git a/Command/MigrationsVersionDoctrineCommand.php b/Command/MigrationsVersionDoctrineCommand.php
@@ -14,6 +14,7 @@
 
 namespace Doctrine\Bundle\MigrationsBundle\Command;
 
+use InvalidArgumentException;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Input\InputOption;
@@ -43,14 +44,14 @@ public function execute(InputInterface $input, OutputInterface $output)
     {
         // EM and DB options cannot be set at same time
         if (null !== $input->getOption('em') && null !== $input->getOption('db')) {
-            throw new \InvalidArgumentException('Cannot set both "em" and "db" for command execution.');
+            throw new InvalidArgumentException('Cannot set both "em" and "db" for command execution.');
         }
 
         Helper\DoctrineCommandHelper::setApplicationHelper($this->getApplication(), $input);
 
         $configuration = $this->getMigrationConfiguration($input, $output);
         DoctrineCommand::configureMigrations($this->getApplication()->getKernel()->getContainer(), $configuration);
 
-        parent::execute($input, $output);
+        return parent::execute($input, $output);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,7 @@`
`14`	`14`
`15`	`15`	`namespace Doctrine\Bundle\MigrationsBundle\Command;`
`16`	`16`
	`17`	`+use InvalidArgumentException;`
`17`	`18`	`use Symfony\Component\Console\Input\InputInterface;`
`18`	`19`	`use Symfony\Component\Console\Output\OutputInterface;`
`19`	`20`	`use Symfony\Component\Console\Input\InputOption;`
`@@ -43,14 +44,14 @@ public function execute(InputInterface $input, OutputInterface $output)`
`43`	`44`	`{`
`44`	`45`	`// EM and DB options cannot be set at same time`
`45`	`46`	`if (null !== $input->getOption('em') && null !== $input->getOption('db')) {`
`46`		`- throw new \InvalidArgumentException('Cannot set both "em" and "db" for command execution.');`
	`47`	`+ throw new InvalidArgumentException('Cannot set both "em" and "db" for command execution.');`
`47`	`48`	`}`
`48`	`49`
`49`	`50`	`Helper\DoctrineCommandHelper::setApplicationHelper($this->getApplication(), $input);`
`50`	`51`
`51`	`52`	`$configuration = $this->getMigrationConfiguration($input, $output);`
`52`	`53`	`DoctrineCommand::configureMigrations($this->getApplication()->getKernel()->getContainer(), $configuration);`
`53`		`-`
`54`		`- parent::execute($input, $output);`
	`54`	`+`
	`55`	`+ return parent::execute($input, $output);`
`55`	`56`	`}`
`56`	`57`	`}`