Merge pull request #288 from alcaeus/fix-type-conversion-2.1

Fix type conversion of CLI options

Author: alcaeus

Command/Helper/DoctrineCommandHelper.php

@@ -33,9 +33,9 @@ public static function setApplicationHelper(Application $application, InputInter
         $managerNames = $doctrine->getManagerNames();
 
         if ($input->getOption('db') !== null || count($managerNames) === 0) {
-            self::setApplicationConnection($application, (string) $input->getOption('db'));
+            self::setApplicationConnection($application, $input->getOption('db'));
         } else {
-            self::setApplicationEntityManager($application, (string) $input->getOption('em'));
+            self::setApplicationEntityManager($application, $input->getOption('em'));
         }
 
         if ($input->getOption('shard') === null) {
@@ -61,6 +61,6 @@ public static function setApplicationHelper(Application $application, InputInter
             ));
         }
 
-        $connection->connect((string) $input->getOption('shard'));
+        $connection->connect($input->getOption('shard'));
     }
 }

phpstan.neon

@@ -1,2 +1,7 @@
+parameters:
+    ignoreErrors:
+        # This is due to a bug in DoctrineBundle
+        - '~Parameter \#2 \$connName of static method Doctrine\\Bundle\\DoctrineBundle\\Command\\Proxy\\DoctrineCommandHelper::setApplicationConnection\(\) expects string, array\<string\>\|bool\|string\|null given\.~'
+        - '~Parameter \#2 \$emName of static method Doctrine\\Bundle\\DoctrineBundle\\Command\\Proxy\\DoctrineCommandHelper::setApplicationEntityManager\(\) expects string, array\<string\>\|bool\|string\|null given\.~'
 includes:
     - vendor/phpstan/phpstan-strict-rules/rules.neon