ensure checked types are consistent

Author: goetas

DependencyInjection/CompilerPass/ConfigureDependencyFactoryPass.php

@@ -9,6 +9,8 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Reference;
 
+use function assert;
+use function is_string;
 use function sprintf;
 
 class ConfigureDependencyFactoryPass implements CompilerPassInterface
@@ -18,6 +20,7 @@ public function process(ContainerBuilder $container): void
         $preferredEm  = $container->getParameter('doctrine.migrations.preferred_em');
         $diDefinition = $container->getDefinition('doctrine.migrations.dependency_factory');
 
+        assert(is_string($preferredEm) || $preferredEm === null);
         $emID = sprintf('doctrine.orm.%s_entity_manager', $preferredEm ?? 'default');
 
         if ($container->has($emID)) {
@@ -28,7 +31,8 @@ public function process(ContainerBuilder $container): void
             $diDefinition->setArgument(1, new Reference('doctrine.migrations.em_loader'));
         } else {
             $preferredConnection = $container->getParameter('doctrine.migrations.preferred_connection');
-            $connectionId        = sprintf('doctrine.dbal.%s_connection', $preferredConnection ?? 'default');
+            assert(is_string($preferredConnection) || $preferredConnection === null);
+            $connectionId = sprintf('doctrine.dbal.%s_connection', $preferredConnection ?? 'default');
             $container->getDefinition('doctrine.migrations.connection_loader')
                 ->setArgument(0, new Reference($connectionId));
 

DependencyInjection/DoctrineMigrationsExtension.php

@@ -18,8 +18,10 @@
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
 
 use function array_keys;
+use function assert;
 use function explode;
 use function implode;
+use function is_array;
 use function sprintf;
 use function strlen;
 use function substr;
@@ -141,6 +143,8 @@ private function getBundlePath(string $bundleName, ContainerBuilder $container):
     {
         $bundleMetadata = $container->getParameter('kernel.bundles_metadata');
 
+        assert(is_array($bundleMetadata));
+
         if (! isset($bundleMetadata[$bundleName])) {
             throw new RuntimeException(sprintf(
                 'The bundle "%s" has not been registered, available bundles: %s',