Skip to content

Commit ca3879c

Browse files
authored
Merge pull request #655 from greg0ire/4.0.x
Merge 3.8.x up into 4.0.x
2 parents eb59fe3 + 762405e commit ca3879c

File tree

7 files changed

+20
-10
lines changed

7 files changed

+20
-10
lines changed

.github/workflows/coding-standards.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ on:
1212
jobs:
1313
coding-standards:
1414
name: "Coding Standards"
15-
uses: "doctrine/.github/.github/workflows/coding-standards.yml@13.0.0"
15+
uses: "doctrine/.github/.github/workflows/coding-standards.yml@13.1.0"

.github/workflows/composer-lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ on:
1717
jobs:
1818
composer-lint:
1919
name: "Composer Lint"
20-
uses: "doctrine/.github/.github/workflows/composer-lint.yml@13.0.0"
20+
uses: "doctrine/.github/.github/workflows/composer-lint.yml@13.1.0"

.github/workflows/continuous-integration.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ on:
1212
jobs:
1313
phpunit:
1414
name: "PHPUnit"
15-
uses: "doctrine/.github/.github/workflows/continuous-integration.yml@v12.2.0"
15+
uses: "doctrine/.github/.github/workflows/continuous-integration.yml@13.1.0"
1616
with:
1717
php-versions: '["8.4"]'
1818
secrets:
1919
CODECOV_TOKEN: "${{ secrets.CODECOV_TOKEN }}"
2020

2121
phpunit-with-dev-deps:
2222
name: "PHPUnit with dev dependencies"
23-
uses: "doctrine/.github/.github/workflows/continuous-integration-symfony-unstable.yml@13.0.0"
23+
uses: "doctrine/.github/.github/workflows/continuous-integration-symfony-unstable.yml@13.1.0"
2424
with:
2525
symfony-version-constraint: "^7"
2626
secrets:

.github/workflows/static-analysis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@ on:
1212
jobs:
1313
static-analysis:
1414
name: "Static Analysis"
15-
uses: "doctrine/.github/.github/workflows/phpstan.yml@13.0.0"
15+
uses: "doctrine/.github/.github/workflows/phpstan.yml@13.1.0"

composer.json

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,18 @@
2525
"homepage": "https://www.doctrine-project.org",
2626
"require": {
2727
"php": "^8.4",
28+
"doctrine/dbal": "^2 || ^3 || ^4",
2829
"doctrine/doctrine-bundle": "^3",
2930
"doctrine/migrations": "^3.2",
31+
"psr/log": "^1 || ^2 || ^3",
32+
"symfony/config": "^6.4 || ^7.0 || ^8.0",
33+
"symfony/console": "^6.4 || ^7.0 || ^8.0",
34+
"symfony/dependency-injection": "^6.4 || ^7.0 || ^8.0",
3035
"symfony/deprecation-contracts": "^2.1 || ^3",
3136
"symfony/framework-bundle": "^6.4 || ^7.0 || ^8.0",
32-
"symfony/http-kernel": "^6.4 || ^7.0 || ^8.0"
37+
"symfony/http-foundation": "^6.4 || ^7.0 || ^8.0",
38+
"symfony/http-kernel": "^6.4 || ^7.0 || ^8.0",
39+
"symfony/service-contracts": "^1.0 || ^2.0 || ^3.0"
3340
},
3441
"require-dev": {
3542
"composer/semver": "^3.0",

phpstan.neon.dist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
parameters:
22
level: 7
3-
phpVersion: 80400
3+
phpVersion: 80500
44
paths:
55
- src
66
- tests

src/EventListener/SchemaFilterListener.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
namespace Doctrine\Bundle\MigrationsBundle\EventListener;
66

77
use Doctrine\DBAL\Schema\AbstractAsset;
8+
use Doctrine\DBAL\Schema\AbstractNamedObject;
89
use Doctrine\DBAL\Schema\Name\OptionallyQualifiedName;
910
use Doctrine\ORM\Tools\Console\Command\SchemaTool\UpdateCommand;
1011
use Doctrine\ORM\Tools\Console\Command\ValidateSchemaCommand;
@@ -25,15 +26,17 @@ public function __construct(private readonly string $configurationTableName)
2526

2627
private bool $enabled = false;
2728

28-
/** @param AbstractAsset<OptionallyQualifiedName>|string $asset */
29-
public function __invoke(AbstractAsset|string $asset): bool
29+
/** @param AbstractAsset<OptionallyQualifiedName>|AbstractNamedObject<OptionallyQualifiedName>|string $asset */
30+
public function __invoke(AbstractAsset|AbstractNamedObject|string $asset): bool
3031
{
3132
if (! $this->enabled) {
3233
return true;
3334
}
3435

3536
if ($asset instanceof AbstractAsset) {
36-
$asset = $asset->getName();
37+
$asset = $asset instanceof AbstractNamedObject
38+
? $asset->getObjectName()->toString()
39+
: $asset->getName();
3740
}
3841

3942
return $asset !== $this->configurationTableName;

0 commit comments

Comments
 (0)