Incorrect deprecation notice

[craigh]

Bug Report

Q	A
Version	2.4.0
Previous Version if the bug is a regression	2.3.0 (probably)

Summary

Valid code is triggering a deprecation notice.

Current behavior

This code is triggering this notice.

Passing null as $firstResult to the constructor of Doctrine\Common\Collections\Criteria is deprecated. Pass 0 instead or omit the argument. (Criteria.php:85 called by Seat.php:530, https://github.com/doctrine/collections/pull/311, package doctrine/collections)

with this code:

new Criteria(orderings: ['startDate' => Order::Descending], accessRawFieldValues: true)

I think the counting of the function args isn't working as expected

        if ($firstResult === null && func_num_args() > 2) {

Expected behavior

This code should not be triggering this notice.

How to reproduce

[greg0ire]

Related: #472 (comment)

[craigh]

@greg0ire do you suggest that my only fix here is the workaround suggest in #472 ?

[greg0ire]

I'm not suggesting it's the only fix, no. There's probably another way than func_num_args(). Somebody should research that.

[greg0ire]

Solution found by Claude:

        $firstResultPassed = false;
        $trace = debug_backtrace(0, 1)[0];

        // Check if $firstResult was passed by examining the call line
        if (isset($trace['file'])) {
            $file = file($trace['file']);
            $callLine = $file[$trace['line'] - 1] ?? '';

            // Check for positional argument (third argument position)
            if (preg_match('/new\s+Criteria\([^)]*,\s*[^)]*,\s*null/', $callLine)) {
                $firstResultPassed = true;
            }
            // Check for named argument
            elseif (preg_match('/firstResult\s*=>\s*null/', $callLine)) {
                $firstResultPassed = true;
            }
        }

🤮

[greg0ire]

Another solution by @Crell, from https://symfony-devs.slack.com/archives/C6PSS2YKW/p1762531512526109?thread_ts=1762458080.756499&cid=C6PSS2YKW