Merge pull request #4255 from morozov/issues/4243

Revert full support for foreign key constraints for SQLite

Author: morozov

lib/Doctrine/DBAL/Driver/AbstractSQLiteDriver.php

@@ -70,10 +70,6 @@ public function convertException($message, DriverException $exception)
             return new Exception\ConnectionException($message, $exception);
         }
 
-        if (strpos($exception->getMessage(), 'FOREIGN KEY constraint failed') !== false) {
-            return new Exception\ForeignKeyConstraintViolationException($message, $exception);
-        }
-
         return new Exception\DriverException($message, $exception);
     }
 

lib/Doctrine/DBAL/Internal/DependencyOrderCalculator.php

@@ -3217,16 +3217,6 @@ public function supportsForeignKeyConstraints()
         return true;
     }
 
-    /**
-     * Whether foreign key constraints can be dropped.
-     *
-     * If false, then getDropForeignKeySQL() throws exception.
-     */
-    public function supportsCreateDropForeignKeyConstraints(): bool
-    {
-        return true;
-    }
-
     /**
      * Whether this platform supports onUpdate in foreign key constraints.
      *

lib/Doctrine/DBAL/Internal/DependencyOrderEdge.php

@@ -791,11 +791,6 @@ public function canEmulateSchemas()
      * {@inheritDoc}
      */
     public function supportsForeignKeyConstraints()
-    {
-        return true;
-    }
-
-    public function supportsCreateDropForeignKeyConstraints(): bool
     {
         return false;
     }
@@ -813,21 +808,15 @@ public function getCreatePrimaryKeySQL(Index $index, $table)
      */
     public function getCreateForeignKeySQL(ForeignKeyConstraint $foreignKey, $table)
     {
-        throw new DBALException(
-            'Sqlite platform does not support alter foreign key, '
-            . 'the table must be fully recreated using getAlterTableSQL.'
-        );
+        throw new DBALException('Sqlite platform does not support alter foreign key.');
     }
 
     /**
      * {@inheritdoc}
      */
     public function getDropForeignKeySQL($foreignKey, $table)
     {
-        throw new DBALException(
-            'Sqlite platform does not support alter foreign key, '
-            . 'the table must be fully recreated using getAlterTableSQL.'
-        );
+        throw new DBALException('Sqlite platform does not support alter foreign key.');
     }
 
     /**

lib/Doctrine/DBAL/Internal/DependencyOrderNode.php

@@ -2,7 +2,6 @@
 
 namespace Doctrine\DBAL\Schema;
 
-use Doctrine\DBAL\Internal\DependencyOrderCalculator;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 
 use function array_merge;
@@ -139,16 +138,13 @@ protected function _toSql(AbstractPlatform $platform, $saveMode = false)
         }
 
         $foreignKeySql = [];
-        $createFlags   = AbstractPlatform::CREATE_INDEXES;
-
-        if (! $platform->supportsCreateDropForeignKeyConstraints()) {
-            $createFlags |= AbstractPlatform::CREATE_FOREIGNKEYS;
-        }
-
-        foreach ($this->getNewTablesSortedByDependencies() as $table) {
-            $sql = array_merge($sql, $platform->getCreateTableSQL($table, $createFlags));
+        foreach ($this->newTables as $table) {
+            $sql = array_merge(
+                $sql,
+                $platform->getCreateTableSQL($table, AbstractPlatform::CREATE_INDEXES)
+            );
 
-            if (! $platform->supportsCreateDropForeignKeyConstraints()) {
+            if (! $platform->supportsForeignKeyConstraints()) {
                 continue;
             }
 
@@ -171,37 +167,4 @@ protected function _toSql(AbstractPlatform $platform, $saveMode = false)
 
         return $sql;
     }
-
-    /**
-     * Sorts tables by dependencies so that they are created in the right order.
-     *
-     * This is necessary when one table depends on another while creating foreign key
-     * constraints directly during CREATE TABLE.
-     *
-     * @return array<Table>
-     */
-    private function getNewTablesSortedByDependencies()
-    {
-        $calculator = new DependencyOrderCalculator();
-        $newTables  = [];
-
-        foreach ($this->newTables as $table) {
-            $newTables[$table->getName()] = true;
-            $calculator->addNode($table->getName(), $table);
-        }
-
-        foreach ($this->newTables as $table) {
-            foreach ($table->getForeignKeys() as $foreignKey) {
-                $foreignTableName = $foreignKey->getForeignTableName();
-
-                if (! isset($newTables[$foreignTableName])) {
-                    continue;
-                }
-
-                $calculator->addDependency($foreignTableName, $table->getName());
-            }
-        }
-
-        return $calculator->sort();
-    }
 }

lib/Doctrine/DBAL/Platforms/AbstractPlatform.php

@@ -149,7 +149,7 @@ public function listTableForeignKeys($table, $database = null)
                 $id = $value['id'];
 
                 $tableForeignKeys[$key] = array_merge($tableForeignKeys[$key], [
-                    'constraint_name' => isset($names[$id]) && $names[$id] !== '' ? $names[$id] : null,
+                    'constraint_name' => isset($names[$id]) && $names[$id] !== '' ? $names[$id] : $id,
                     'deferrable'      => isset($deferrable[$id]) && strtolower($deferrable[$id]) === 'deferrable',
                     'deferred'        => isset($deferred[$id]) && strtolower($deferred[$id]) === 'deferred',
                 ]);

lib/Doctrine/DBAL/Platforms/SqlitePlatform.php

@@ -56,7 +56,7 @@ public function acceptTable(Table $table)
      */
     public function acceptForeignKey(Table $localTable, ForeignKeyConstraint $fkConstraint)
     {
-        if (! $this->platform->supportsCreateDropForeignKeyConstraints()) {
+        if (! $this->platform->supportsForeignKeyConstraints()) {
             return;
         }
 

lib/Doctrine/DBAL/Schema/SchemaDiff.php

@@ -48,10 +48,6 @@ public function acceptTable(Table $table)
      */
     public function acceptForeignKey(Table $localTable, ForeignKeyConstraint $fkConstraint)
     {
-        if (! $this->platform->supportsCreateDropForeignKeyConstraints()) {
-            return;
-        }
-
         if (strlen($fkConstraint->getName()) === 0) {
             throw SchemaException::namedForeignKeyRequired($localTable, $fkConstraint);
         }