Skip to content

Commit 556e351

Browse files
committed
Use double quotes to quote column names in a test foreign key constraint
This change indicates the issue being tracked in XYZ. It is extracted into a separate commit to demonstrate the issue and the fact that this is a test-only change.
1 parent 9cd1b2b commit 556e351

File tree

7 files changed

+8
-8
lines changed

7 files changed

+8
-8
lines changed

tests/Platforms/AbstractMySQLPlatformTestCase.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ protected function getQuotedColumnInForeignKeySQL(): array
220220
{
221221
return [
222222
'CREATE TABLE `quoted` (`create` VARCHAR(255) NOT NULL, foo VARCHAR(255) NOT NULL, '
223-
. '`bar` VARCHAR(255) NOT NULL, INDEX IDX_22660D028FD6E0FB8C736521D79164E3 (`create`, foo, `bar`))',
223+
. '`bar` VARCHAR(255) NOT NULL, INDEX IDX_22660D028FD6E0FB8C7365216D704F76 (`create`, foo, `bar`))',
224224
'ALTER TABLE `quoted` ADD CONSTRAINT FK_WITH_RESERVED_KEYWORD FOREIGN KEY (`create`, foo, `bar`)'
225225
. ' REFERENCES `foreign` (`create`, bar, `foo-bar`)',
226226
'ALTER TABLE `quoted` ADD CONSTRAINT FK_WITH_NON_RESERVED_KEYWORD FOREIGN KEY (`create`, foo, `bar`)'

tests/Platforms/AbstractPlatformTestCase.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -442,8 +442,8 @@ public function testQuotedColumnInForeignKeyPropagation(): void
442442

443443
$table->addForeignKeyConstraint(
444444
'foreign',
445-
['create', 'foo', '`bar`'],
446-
['create', 'bar', '`foo-bar`'],
445+
['create', 'foo', '"bar"'],
446+
['create', 'bar', '"foo-bar"'],
447447
[],
448448
'FK_WITH_RESERVED_KEYWORD',
449449
);

tests/Platforms/DB2PlatformTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ protected function getQuotedColumnInForeignKeySQL(): array
6969
. ' REFERENCES foo ("create", bar, "foo-bar")',
7070
'ALTER TABLE "quoted" ADD CONSTRAINT FK_WITH_INTENDED_QUOTATION FOREIGN KEY ("create", foo, "bar")'
7171
. ' REFERENCES "foo-bar" ("create", bar, "foo-bar")',
72-
'CREATE INDEX IDX_22660D028FD6E0FB8C736521D79164E3 ON "quoted" ("create", foo, "bar")',
72+
'CREATE INDEX IDX_22660D028FD6E0FB8C7365216D704F76 ON "quoted" ("create", foo, "bar")',
7373
];
7474
}
7575

tests/Platforms/OraclePlatformTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ protected function getQuotedColumnInForeignKeySQL(): array
306306
. ' REFERENCES foo ("create", bar, "foo-bar")',
307307
'ALTER TABLE "quoted" ADD CONSTRAINT FK_WITH_INTENDED_QUOTATION FOREIGN KEY ("create", foo, "bar")'
308308
. ' REFERENCES "foo-bar" ("create", bar, "foo-bar")',
309-
'CREATE INDEX IDX_22660D028FD6E0FB8C736521D79164E3 ON "quoted" ("create", foo, "bar")',
309+
'CREATE INDEX IDX_22660D028FD6E0FB8C7365216D704F76 ON "quoted" ("create", foo, "bar")',
310310
];
311311
}
312312

tests/Platforms/PostgreSQLPlatformTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ protected function getQuotedColumnInForeignKeySQL(): array
379379
return [
380380
'CREATE TABLE "quoted" ("create" VARCHAR(255) NOT NULL, '
381381
. 'foo VARCHAR(255) NOT NULL, "bar" VARCHAR(255) NOT NULL)',
382-
'CREATE INDEX IDX_22660D028FD6E0FB8C736521D79164E3 ON "quoted" ("create", foo, "bar")',
382+
'CREATE INDEX IDX_22660D028FD6E0FB8C7365216D704F76 ON "quoted" ("create", foo, "bar")',
383383
'ALTER TABLE "quoted" ADD CONSTRAINT FK_WITH_RESERVED_KEYWORD FOREIGN KEY ("create", foo, "bar")'
384384
. ' REFERENCES "foreign" ("create", bar, "foo-bar")',
385385
'ALTER TABLE "quoted" ADD CONSTRAINT FK_WITH_NON_RESERVED_KEYWORD FOREIGN KEY ("create", foo, "bar")'

tests/Platforms/SQLServerPlatformTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -644,7 +644,7 @@ protected function getQuotedColumnInForeignKeySQL(): array
644644
return [
645645
'CREATE TABLE [quoted] ([create] NVARCHAR(255) NOT NULL, '
646646
. 'foo NVARCHAR(255) NOT NULL, [bar] NVARCHAR(255) NOT NULL)',
647-
'CREATE INDEX IDX_22660D028FD6E0FB8C736521D79164E3 ON [quoted] ([create], foo, [bar])',
647+
'CREATE INDEX IDX_22660D028FD6E0FB8C7365216D704F76 ON [quoted] ([create], foo, [bar])',
648648
'ALTER TABLE [quoted] ADD CONSTRAINT FK_WITH_RESERVED_KEYWORD'
649649
. ' FOREIGN KEY ([create], foo, [bar]) REFERENCES [foreign] ([create], bar, [foo-bar])',
650650
'ALTER TABLE [quoted] ADD CONSTRAINT FK_WITH_NON_RESERVED_KEYWORD'

tests/Platforms/SQLitePlatformTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@ protected function getQuotedColumnInForeignKeySQL(): array
471471
'REFERENCES foo ("create", bar, "foo-bar") NOT DEFERRABLE INITIALLY IMMEDIATE, ' .
472472
'CONSTRAINT FK_WITH_INTENDED_QUOTATION FOREIGN KEY ("create", foo, "bar") ' .
473473
'REFERENCES "foo-bar" ("create", bar, "foo-bar") NOT DEFERRABLE INITIALLY IMMEDIATE)',
474-
'CREATE INDEX IDX_22660D028FD6E0FB8C736521D79164E3 ON "quoted" ("create", foo, "bar")',
474+
'CREATE INDEX IDX_22660D028FD6E0FB8C7365216D704F76 ON "quoted" ("create", foo, "bar")',
475475
];
476476
}
477477

0 commit comments

Comments
 (0)