Merge branch '4.4.x' into 5.0.x

Author: morozov

UPGRADE.md

@@ -352,6 +352,17 @@ all drivers and middleware.
 
 # Upgrade to 4.4
 
+## Deprecated `AbstractAsset::isQuoted()`
+
+The `AbstractAsset::isQuoted()` method has been deprecated. The recommended approach depends on the object class:
+
+1. Get the object name using `NamedObject::getObjectName()` or `OptionallyNamedObject::getObjectName()`.
+2. Depending on the type of the name, use one or a combination of the following methods to get the identifier(s):
+   - For unqualified names, use `UnqualifiedName::getIdentifier()`
+   - For optionally qualified names, use `OptionallyQualifiedName::getQualifier()` and/or
+     `OptionallyQualifiedName::getUnqualifiedName()`.
+3. Use `Identifier::isQuoted()` to check if corresponding identifier(s) is (are) quoted.
+
 ## Deprecated `service` connection parameter for `oci8` and `pdo_oci` connections.
 
 Using the `service` connection parameter to indicate that the value of the `dbname` parameter is the service name has

src/Schema/AbstractAsset.php

@@ -11,6 +11,7 @@
 use Doctrine\DBAL\Schema\Name\OptionallyQualifiedName;
 use Doctrine\DBAL\Schema\Name\Parser;
 use Doctrine\DBAL\Schema\Name\UnqualifiedName;
+use Doctrine\Deprecations\Deprecation;
 
 use function array_map;
 use function assert;
@@ -37,6 +38,7 @@ abstract class AbstractAsset
 {
     protected string $_name = '';
 
+    /** @deprecated */
     protected bool $_quoted = false;
 
     /** @var list<Identifier> */
@@ -111,9 +113,22 @@ protected function setName(?Name $name): void
 
     /**
      * Checks if this asset's name is quoted.
+     *
+     * @deprecated Depending on the concrete class of the object, use {@see NamedObject::getObjectName()} or
+     *             {@see OptionallyNamedObject::getObjectName()} to get the name. Then, depending on the type of the
+     *             name, use {@see UnqualifiedName::getIdentifier()}, {@see OptionallyQualifiedName::getQualifier()},
+     *             or {@see OptionallyQualifiedName::getUnqualifiedName()} to get the corresponding identifiers. Then,
+     *             use {@see Identifier::$isQuoted()}.
      */
     public function isQuoted(): bool
     {
+        Deprecation::triggerIfCalledFromOutside(
+            'doctrine/dbal',
+            'https://github.com/doctrine/dbal/pull/7084',
+            '%s is deprecated and will be removed in 5.0.',
+            __METHOD__,
+        );
+
         return $this->_quoted;
     }