Use more specific exception messages

Author: morozov

src/Platforms/AbstractPlatform.php

@@ -947,8 +947,14 @@ public function getDropTablesSQL(array $tables): array
 
         foreach ($tables as $table) {
             foreach ($table->getForeignKeys() as $foreignKey) {
+                $constraintName = $foreignKey->getObjectName();
+
+                if ($constraintName === null) {
+                    throw UnspecifiedConstraintName::forForeignKeyConstraint();
+                }
+
                 $sql[] = $this->getDropForeignKeySQL(
-                    $this->getConstraintName($foreignKey)->toSQL($this),
+                    $constraintName->toSQL($this),
                     $table->getObjectName()->toSQL($this),
                 );
             }
@@ -2210,15 +2216,4 @@ abstract public function createMetadataProvider(Connection $connection): Metadat
      * database schema according to the dialect of the platform.
      */
     abstract public function createSchemaManager(Connection $connection): AbstractSchemaManager;
-
-    private function getConstraintName(ForeignKeyConstraint $constraint): UnqualifiedName
-    {
-        $name = $constraint->getObjectName();
-
-        if ($name === null) {
-            throw UnspecifiedConstraintName::new();
-        }
-
-        return $name;
-    }
 }

src/Platforms/DB2Platform.php

@@ -273,7 +273,7 @@ public function getAlterTableSQL(TableDiff $diff): array
             $constraintName = $droppedPrimaryKeyConstraint->getObjectName();
 
             if ($constraintName === null) {
-                throw UnspecifiedConstraintName::new();
+                throw UnspecifiedConstraintName::forPrimaryKeyConstraint();
             }
 
             $sql[] = $this->getDropConstraintSQL($constraintName->toSQL($this), $tableNameSQL);

src/Platforms/OraclePlatform.php

@@ -510,7 +510,7 @@ public function getAlterTableSQL(TableDiff $diff): array
             $constraintName = $droppedPrimaryKeyConstraint->getObjectName();
 
             if ($constraintName === null) {
-                throw UnspecifiedConstraintName::new();
+                throw UnspecifiedConstraintName::forPrimaryKeyConstraint();
             }
 
             $sql[] = $this->getDropConstraintSQL($constraintName->toSQL($this), $tableNameSQL);

src/Platforms/PostgreSQLPlatform.php

@@ -185,7 +185,7 @@ public function getAlterTableSQL(TableDiff $diff): array
             $constraintName = $droppedPrimaryKeyConstraint->getObjectName();
 
             if ($constraintName === null) {
-                throw UnspecifiedConstraintName::new();
+                throw UnspecifiedConstraintName::forPrimaryKeyConstraint();
             }
 
             $sql[] = $this->getDropConstraintSQL($constraintName->toSQL($this), $tableNameSQL);

src/Platforms/SQLServerPlatform.php

@@ -321,7 +321,7 @@ public function getAlterTableSQL(TableDiff $diff): array
             $constraintName = $droppedPrimaryKeyConstraint->getObjectName();
 
             if ($constraintName === null) {
-                throw UnspecifiedConstraintName::new();
+                throw UnspecifiedConstraintName::forPrimaryKeyConstraint();
             }
 
             $sql[] = $this->getDropConstraintSQL($constraintName->toSQL($this), $table->getObjectName()->toSQL($this));

src/Schema/Exception/UnspecifiedConstraintName.php

@@ -9,8 +9,13 @@
 
 final class UnspecifiedConstraintName extends InvalidArgumentException implements SchemaException
 {
-    public static function new(): self
+    public static function forPrimaryKeyConstraint(): self
     {
-        return new self('Constraint name is not specified.');
+        return new self('Primary key constraint name is not specified.');
+    }
+
+    public static function forForeignKeyConstraint(): self
+    {
+        return new self('Foreign key constraint name is not specified.');
     }
 }