Enable PHPStan in tests

Author: Majkl578

composer.json

@@ -30,6 +30,7 @@
         "doctrine/coding-standard": "^6.0",
         "jetbrains/phpstorm-stubs": "^2018.1.2",
         "phpstan/phpstan": "^0.11.3",
+        "phpstan/phpstan-phpunit": "^0.11.0",
         "phpunit/phpunit": "^8.0",
         "symfony/console": "^2.0.5|^3.0|^4.0",
         "symfony/phpunit-bridge": "^3.4.5|^4.0.5"

composer.lock

@@ -2,6 +2,7 @@ parameters:
     level: 7
     paths:
         - %currentWorkingDirectory%/lib
+        - %currentWorkingDirectory%/tests
     autoload_files:
         - %currentWorkingDirectory%/tests/phpstan-polyfill.php
     reportUnmatchedIgnoredErrors: false
@@ -69,3 +70,21 @@ parameters:
         -
             message: '~^Strict comparison using === between string|false and null will always evaluate to false\.~'
             path: %currentWorkingDirectory%/lib/Doctrine/DBAL/Driver/PDOStatement.php
+
+        # impossible inference for covariance
+        - '~^Property Doctrine\\Tests\\DBAL\\Types\\\S+Test::\$type \(Doctrine\\DBAL\\Types\\\S+Type\) does not accept Doctrine\\DBAL\\Types\\Type\.\z~'
+        - '~^Property Doctrine\\Tests\\DBAL\\Tools\\Console\\RunSqlCommandTest::\$command \(Doctrine\\DBAL\\Tools\\Console\\Command\\RunSqlCommand\) does not accept Symfony\\Component\\Console\\Command\\Command\.\z~'
+
+        # https://github.com/phpstan/phpstan-phpunit/pull/28
+        -
+            message: '~Call to method expects\(\) on an unknown class \S+~'
+            path: %currentWorkingDirectory%/tests/Doctrine/Tests/DBAL/Platforms/AbstractPlatformTestCase.php
+        -
+            message: '~Call to method expects\(\) on an unknown class \S+~'
+            path: %currentWorkingDirectory%/tests/Doctrine/Tests/DBAL/ConnectionTest.php
+        -
+            message: '~Call to method expects\(\) on an unknown class \S+~'
+            path: %currentWorkingDirectory%/tests/Doctrine/Tests/DBAL/Functional/Schema/SchemaManagerFunctionalTestCase.php
+includes:
+    - vendor/phpstan/phpstan-phpunit/extension.neon
+    - vendor/phpstan/phpstan-phpunit/rules.neon

phpstan.neon.dist

@@ -23,7 +23,7 @@ class QueryCacheProfileTest extends DbalTestCase
     /** @var int[] */
     private $params = [666];
 
-    /** @var string[] */
+    /** @var int[] */
     private $types = [ParameterType::INTEGER];
 
     /** @var string[] */

tests/Doctrine/Tests/DBAL/Cache/QueryCacheProfileTest.php

@@ -108,7 +108,7 @@ public function getSQLState() : ?string
         $message = 'DBAL exception message';
 
         foreach ($data as $item) {
-            /** @var $driverException \Doctrine\DBAL\Driver\DriverException */
+            /** @var DriverException $driverException */
             [$driverException, $convertedExceptionClassName] = $item;
 
             $convertedException = $this->driver->convertException($message, $driverException);

tests/Doctrine/Tests/DBAL/Driver/AbstractDriverTest.php

@@ -27,7 +27,7 @@ class PDOExceptionTest extends DbalTestCase
     /**
      * The wrapped PDO exception mock.
      *
-     * @var \PDOException|MockObject
+     * @var \PDOException
      */
     private $wrappedException;
 

tests/Doctrine/Tests/DBAL/Driver/PDOExceptionTest.php

@@ -9,7 +9,7 @@
 use Doctrine\Tests\DBAL\Driver\AbstractPostgreSQLDriverTest;
 use PDO;
 use PDOException;
-use PHPUnit_Framework_SkippedTestError;
+use PHPUnit\Framework\SkippedTestError;
 use function defined;
 
 class DriverTest extends AbstractPostgreSQLDriverTest
@@ -111,7 +111,7 @@ protected function createDriver()
     }
 
     /**
-     * @throws PHPUnit_Framework_SkippedTestError
+     * @throws SkippedTestError
      */
     private function skipWhenNotUsingPhp56AndPdoPgsql()
     {

tests/Doctrine/Tests/DBAL/Driver/PDOPgSql/DriverTest.php

@@ -5,8 +5,10 @@
 namespace Doctrine\Tests\DBAL\Functional\Driver\IBMDB2;
 
 use Doctrine\DBAL\Driver\IBMDB2\DB2Driver;
+use Doctrine\DBAL\Statement;
 use Doctrine\Tests\DbalFunctionalTestCase;
 use PHPUnit\Framework\Error\Notice;
+use function assert;
 use function extension_loaded;
 
 class DB2StatementTest extends DbalFunctionalTestCase
@@ -29,6 +31,7 @@ protected function setUp() : void
     public function testExecutionErrorsAreNotSuppressed()
     {
         $stmt = $this->connection->prepare('SELECT * FROM SYSIBM.SYSDUMMY1 WHERE \'foo\' = ?');
+        assert($stmt instanceof Statement);
 
         // unwrap the statement to prevent the wrapper from handling the PHPUnit-originated exception
         $wrappedStmt = $stmt->getWrappedStatement();

tests/Doctrine/Tests/DBAL/Functional/Driver/IBMDB2/DB2StatementTest.php

@@ -8,6 +8,7 @@
 use Doctrine\DBAL\Driver\OCI8\OCI8Connection;
 use Doctrine\DBAL\Schema\Table;
 use Doctrine\Tests\DbalFunctionalTestCase;
+use function assert;
 use function extension_loaded;
 
 class OCI8ConnectionTest extends DbalFunctionalTestCase
@@ -27,7 +28,10 @@ protected function setUp() : void
             $this->markTestSkipped('oci8 only test.');
         }
 
-        $this->driverConnection = $this->connection->getWrappedConnection();
+        $wrappedConnection = $this->connection->getWrappedConnection();
+        assert($wrappedConnection instanceof OCI8Connection);
+
+        $this->driverConnection = $wrappedConnection;
     }
 
     /**

tests/Doctrine/Tests/DBAL/Functional/Driver/OCI8/OCI8ConnectionTest.php

@@ -28,13 +28,14 @@ protected function setUp() : void
 
         parent::setUp();
 
-        $this->driverConnection = $this->connection->getWrappedConnection();
 
-        if ($this->driverConnection instanceof PDOConnection) {
-            return;
+        $wrappedConnection = $this->connection->getWrappedConnection();
+
+        if (! $wrappedConnection instanceof PDOConnection) {
+            $this->markTestSkipped('PDO connection only test.');
         }
 
-        $this->markTestSkipped('PDO connection only test.');
+        $this->driverConnection = $wrappedConnection;
     }
 
     protected function tearDown() : void