Fix binding null as a boolean parameter on pgsql (#7059)

Author: derrabus

src/Driver/PgSQL/Statement.php

@@ -81,6 +81,10 @@ public function bindValue($param, $value, $type = ParameterType::STRING): bool
             throw UnknownParameter::new((string) $param);
         }
 
+        if ($value === null) {
+            $type = ParameterType::NULL;
+        }
+
         if ($type === ParameterType::BOOLEAN) {
             $this->parameters[$this->parameterMap[$param]]     = (bool) $value === false ? 'f' : 't';
             $this->parameterTypes[$this->parameterMap[$param]] = ParameterType::STRING;

tests/Functional/BooleanBindingTest.php

@@ -8,6 +8,7 @@
 use Doctrine\DBAL\Schema\Table;
 use Doctrine\DBAL\Tests\FunctionalTestCase;
 use Doctrine\DBAL\Tests\TestUtil;
+use Doctrine\DBAL\Types\Types;
 
 class BooleanBindingTest extends FunctionalTestCase
 {
@@ -18,7 +19,7 @@ protected function setUp(): void
         }
 
         $table = new Table('boolean_test_table');
-        $table->addColumn('val', 'boolean');
+        $table->addColumn('val', 'boolean')->setNotnull(false);
         $this->dropAndCreateTable($table);
     }
 
@@ -28,7 +29,7 @@ protected function tearDown(): void
     }
 
     /** @dataProvider booleanProvider */
-    public function testBooleanInsert(bool $input): void
+    public function testBooleanParameterInsert(?bool $input): void
     {
         $queryBuilder = $this->connection->createQueryBuilder();
 
@@ -37,11 +38,37 @@ public function testBooleanInsert(bool $input): void
         ])->executeStatement();
 
         self::assertSame(1, $result);
+
+        self::assertSame($input, $this->connection->convertToPHPValue(
+            $this->connection->fetchOne('SELECT val FROM boolean_test_table'),
+            Types::BOOLEAN,
+        ));
+    }
+
+    /** @dataProvider booleanProvider */
+    public function testBooleanTypeInsert(?bool $input): void
+    {
+        $queryBuilder = $this->connection->createQueryBuilder();
+
+        $result = $queryBuilder->insert('boolean_test_table')->values([
+            'val' => $queryBuilder->createNamedParameter($input, Types::BOOLEAN),
+        ])->executeStatement();
+
+        self::assertSame(1, $result);
+
+        self::assertSame($input, $this->connection->convertToPHPValue(
+            $this->connection->fetchOne('SELECT val FROM boolean_test_table'),
+            Types::BOOLEAN,
+        ));
     }
 
-    /** @return bool[][] */
+    /** @return array<string, array{bool|null}> */
     public static function booleanProvider(): array
     {
-        return [[true], [false]];
+        return [
+            'true' => [true],
+            'false' => [false],
+            'null' => [null],
+        ];
     }
 }