Merge branch '4.2.x' into 4.3.x

* 4.2.x:
  Bump doctrine/.github from 7.2.2 to 7.3.0 (#6985)
  Deterministic ordering in schema manager results
  Nightly build tweaks
  Fix SQLite schema emulation in SqliteSchemaManager

Author: derrabus

.github/workflows/coding-standards.yml

@@ -25,6 +25,6 @@ on:
 jobs:
   coding-standards:
     name: "Coding Standards"
-    uses: "doctrine/.github/.github/workflows/coding-standards.yml@7.2.2"
+    uses: "doctrine/.github/.github/workflows/coding-standards.yml@7.3.0"
     with:
       composer-options: "--ignore-platform-req=php+"

.github/workflows/continuous-integration.yml

@@ -24,9 +24,6 @@ on:
   schedule:
     - cron: "42 3 * * *"
 
-env:
-  fail-fast: true
-
 jobs:
   phpunit-smoke-check:
     name: "PHPUnit with SQLite"

.github/workflows/documentation.yml

@@ -17,4 +17,4 @@ on:
 jobs:
   documentation:
     name: "Documentation"
-    uses: "doctrine/.github/.github/workflows/documentation.yml@7.2.2"
+    uses: "doctrine/.github/.github/workflows/documentation.yml@7.3.0"

.github/workflows/nightly.yml

@@ -11,6 +11,7 @@ jobs:
     runs-on: "ubuntu-24.04"
 
     strategy:
+      fail-fast: false
       matrix:
         php-version:
           - "8.3"
@@ -80,6 +81,7 @@ jobs:
       dependency-versions: ${{ matrix.dependency-versions }}
 
     strategy:
+      fail-fast: false
       matrix:
         os:
           - ubuntu-24.04
@@ -100,6 +102,7 @@ jobs:
       extension: ${{ matrix.extension }}
 
     strategy:
+      fail-fast: false
       matrix:
         php-version:
           - '8.5'
@@ -118,6 +121,7 @@ jobs:
       extension: ${{ matrix.extension }}
 
     strategy:
+      fail-fast: false
       matrix:
         php-version:
           - '8.5'
@@ -136,6 +140,7 @@ jobs:
       collation: ${{ matrix.collation }}
 
     strategy:
+      fail-fast: false
       matrix:
         php-version:
           - '8.5'
@@ -154,6 +159,7 @@ jobs:
       extension: ${{ matrix.extension }}
 
     strategy:
+      fail-fast: false
       matrix:
         php-version:
           - '8.5'
@@ -173,6 +179,7 @@ jobs:
       postgres-locale-provider: ${{ matrix.postgres-locale-provider }}
 
     strategy:
+      fail-fast: false
       matrix:
         php-version:
           - '8.5'

.github/workflows/static-analysis.yml

@@ -25,4 +25,4 @@ on:
 jobs:
   static-analysis-phpstan:
     name: "Static Analysis"
-    uses: "doctrine/.github/.github/workflows/phpstan.yml@7.2.2"
+    uses: "doctrine/.github/.github/workflows/phpstan.yml@7.3.0"

src/Schema/PostgreSQLSchemaManager.php

@@ -343,6 +343,8 @@ protected function selectTableNames(string $databaseName): Result
   AND table_name != 'geometry_columns'
   AND table_name != 'spatial_ref_sys'
   AND table_type = 'BASE TABLE'
+ORDER BY
+  quote_ident(table_name)
 SQL;
 
         return $this->connection->executeQuery($sql, [$databaseName]);
@@ -471,6 +473,7 @@ protected function selectForeignKeyColumns(string $databaseName, ?string $tableN
                             ON n.oid = c.relnamespace
                         WHERE %s)
                   AND r.contype = 'f'
+                  ORDER BY 1, 2
         SQL,
             implode(' AND ', $this->buildQueryConditions($tableName, $params)),
         );

tests/Functional/Schema/SQLiteSchemaManagerTest.php

@@ -12,6 +12,7 @@
 use Doctrine\DBAL\Schema\ForeignKeyConstraint;
 use Doctrine\DBAL\Schema\Index;
 use Doctrine\DBAL\Schema\PrimaryKeyConstraint;
+use Doctrine\DBAL\Schema\SQLiteSchemaManager;
 use Doctrine\DBAL\Schema\Table;
 use Doctrine\DBAL\Schema\TableDiff;
 use Doctrine\DBAL\Types\BlobType;
@@ -20,8 +21,10 @@
 use Doctrine\Deprecations\PHPUnit\VerifyDeprecations;
 
 use function array_keys;
+use function array_map;
 use function array_shift;
 use function array_values;
+use function assert;
 
 class SQLiteSchemaManagerTest extends SchemaManagerFunctionalTestCase
 {
@@ -495,6 +498,81 @@ public function testShorthandInForeignKeyReferenceWithMultipleColumns(): void
         );
     }
 
+    public function testListTableNoSchemaEmulation(): void
+    {
+        $databasePlatform = $this->connection->getDatabasePlatform();
+        assert($databasePlatform instanceof SQLitePlatform);
+
+        $this->dropTableIfExists('`list_table_no_schema_emulation.test`');
+
+        $this->connection->executeStatement(<<<'DDL'
+            CREATE TABLE `list_table_no_schema_emulation.test` (
+                id INTEGER,
+                parent_id INTEGER,
+                PRIMARY KEY (id),
+                FOREIGN KEY (parent_id) REFERENCES `list_table_no_schema_emulation.test` (id)
+            );
+            DDL);
+
+        $this->connection->executeStatement(<<<'DDL'
+            CREATE INDEX i ON `list_table_no_schema_emulation.test` (parent_id);
+            DDL);
+
+        $customSQLiteSchemaManager = new class ($this->connection, $databasePlatform) extends SQLiteSchemaManager {
+            /** @return list<array<string, mixed>> */
+            public function selectTableColumnsWithSchema(): array
+            {
+                return $this->selectTableColumns('main', 'list_table_no_schema_emulation.test')
+                    ->fetchAllAssociative();
+            }
+
+            /** @return list<array<string, mixed>> */
+            public function selectIndexColumnsWithSchema(): array
+            {
+                return $this->selectIndexColumns('main', 'list_table_no_schema_emulation.test')
+                    ->fetchAllAssociative();
+            }
+
+            /** @return list<array<string, mixed>> */
+            public function selectForeignKeyColumnsWithSchema(): array
+            {
+                return $this->selectForeignKeyColumns('main', 'list_table_no_schema_emulation.test')
+                    ->fetchAllAssociative();
+            }
+        };
+
+        self::assertSame(
+            [
+                ['list_table_no_schema_emulation.test', 'id'],
+                ['list_table_no_schema_emulation.test', 'parent_id'],
+            ],
+            array_map(
+                static fn (array $row) => [$row['table_name'], $row['name']],
+                $customSQLiteSchemaManager->selectTableColumnsWithSchema(),
+            ),
+        );
+
+        self::assertSame(
+            [
+                ['list_table_no_schema_emulation.test', 'i'],
+            ],
+            array_map(
+                static fn (array $row) => [$row['table_name'], $row['name']],
+                $customSQLiteSchemaManager->selectIndexColumnsWithSchema(),
+            ),
+        );
+
+        self::assertSame(
+            [
+                ['list_table_no_schema_emulation.test', 'parent_id', 'id'],
+            ],
+            array_map(
+                static fn (array $row) => [$row['table_name'], $row['from'], $row['to']],
+                $customSQLiteSchemaManager->selectForeignKeyColumnsWithSchema(),
+            ),
+        );
+    }
+
     /**
      * This test duplicates {@see parent::testCommentInTable()} with the only difference that the name of the table
      * being created is quoted. It is only meant to cover the logic of parsing the SQLite CREATE TABLE statement