Merge pull request #150 from greg0ire/override

Use Override attribute where applicable

Author: greg0ire

phpstan.neon.dist

@@ -4,6 +4,7 @@ includes:
 
 parameters:
     level: max
+    checkMissingOverrideMethodAttribute: true
     phpVersion: 80400
     paths:
         - src

src/Doctrine/Instantiator/Instantiator.php

@@ -9,6 +9,7 @@
 use Doctrine\Instantiator\Exception\InvalidArgumentException;
 use Doctrine\Instantiator\Exception\UnexpectedValueException;
 use Exception;
+use Override;
 use ReflectionClass;
 use ReflectionException;
 use Serializable;
@@ -55,6 +56,7 @@ final class Instantiator implements InstantiatorInterface
      *
      * @template T of object
      */
+    #[Override]
     public function instantiate(string $className): object
     {
         if (isset(self::$cachedCloneables[$className])) {

tests/DoctrineTest/InstantiatorTest/InstantiatorTest.php

@@ -25,6 +25,7 @@
 use DoctrineTest\InstantiatorTestAsset\XMLReaderAsset;
 use Exception;
 use Generator;
+use Override;
 use PDORow;
 use PharException;
 use PHPUnit\Framework\TestCase;
@@ -42,6 +43,7 @@ class InstantiatorTest extends TestCase
 {
     private Instantiator $instantiator;
 
+    #[Override]
     protected function setUp(): void
     {
         parent::setUp();

tests/DoctrineTest/InstantiatorTestAsset/SerializableArrayObjectAsset.php

@@ -6,6 +6,7 @@
 
 use ArrayObject;
 use BadMethodCallException;
+use Override;
 use Serializable;
 
 /**
@@ -27,18 +28,18 @@ public function __construct()
     }
 
     /**
-     * {@inheritDoc}
-     *
      * Should not be called
      *
      * @throws BadMethodCallException
      */
-    public function unserialize($serialized): void
+    #[Override]
+    public function unserialize(string $serialized): void
     {
         throw new BadMethodCallException('Not supposed to be called!');
     }
 
     /** @param mixed[] $data */
+    #[Override]
     public function __unserialize(array $data): void
     {
         throw new BadMethodCallException('Not supposed to be called!');

tests/DoctrineTest/InstantiatorTestAsset/SimpleSerializableAsset.php

@@ -5,6 +5,7 @@
 namespace DoctrineTest\InstantiatorTestAsset;
 
 use BadMethodCallException;
+use Override;
 use Serializable;
 
 /**
@@ -22,6 +23,7 @@ public function __construct()
         throw new BadMethodCallException('Not supposed to be called!');
     }
 
+    #[Override]
     public function serialize(): string
     {
         return '';
@@ -34,6 +36,7 @@ public function serialize(): string
      *
      * @throws BadMethodCallException
      */
+    #[Override]
     public function unserialize(string $serialized): void
     {
         throw new BadMethodCallException('Not supposed to be called!');