Add types for benchmarks (#2948)

Author: IonBazan

.github/workflows/performance.yml

@@ -16,6 +16,7 @@ jobs:
       matrix:
         php-version:
           - "8.1"
+          - "8.4"
 
     services:
       mongodb:

benchmark/BaseBench.php

@@ -9,7 +9,6 @@
 use Doctrine\ODM\MongoDB\Mapping\Driver\AttributeDriver;
 use MongoDB\Client;
 use MongoDB\Model\DatabaseInfo;
-use PhpBench\Benchmark\Metadata\Annotations\BeforeMethods;
 use Symfony\Component\Cache\Adapter\ArrayAdapter;
 
 use function array_map;
@@ -19,14 +18,12 @@
 
 use const PHP_VERSION_ID;
 
-/** @BeforeMethods({"initDocumentManager", "clearDatabase"}) */
 abstract class BaseBench
 {
     public const DATABASE_NAME           = 'doctrine_odm_performance';
     private const DEFAULT_MONGODB_SERVER = 'mongodb://localhost:27017';
 
-    /** @var DocumentManager */
-    protected static $documentManager;
+    protected static DocumentManager $documentManager;
 
     protected function getDocumentManager(): DocumentManager
     {

benchmark/Document/HydrateDocumentBench.php

@@ -12,26 +12,25 @@
 use PhpBench\Attributes\BeforeMethods;
 use PhpBench\Attributes\Warmup;
 
-#[BeforeMethods(['init'])]
+#[BeforeMethods(['initDocumentManager', 'clearDatabase', 'init'])]
 final class HydrateDocumentBench extends BaseBench
 {
     /** @var array<string, mixed> */
-    private static $data;
+    private static array $data;
 
     /** @var array<string, mixed> */
-    private static $embedOneData;
+    private static array $embedOneData;
 
     /** @var array<string, mixed[]> */
-    private static $embedManyData;
+    private static array $embedManyData;
 
     /** @var array<string, mixed[]> */
-    private static $referenceOneData;
+    private static array $referenceOneData;
 
     /** @var array<string, mixed[]> */
-    private static $referenceManyData;
+    private static array $referenceManyData;
 
-    /** @var HydratorInterface */
-    private static $hydrator;
+    private static HydratorInterface $hydrator;
 
     public function init(): void
     {

benchmark/Document/LoadDocumentBench.php

@@ -17,11 +17,10 @@
 
 use function assert;
 
-#[BeforeMethods(['init'])]
+#[BeforeMethods(['initDocumentManager', 'clearDatabase', 'init'])]
 final class LoadDocumentBench extends BaseBench
 {
-    /** @var ObjectId */
-    private static $userId;
+    private static ObjectId $userId;
 
     public function init(): void
     {
@@ -87,8 +86,7 @@ public function benchLoadReferenceMany(): void
         });
     }
 
-    /** @return User */
-    private function loadDocument()
+    private function loadDocument(): User
     {
         $document = $this->getDocumentManager()->find(User::class, self::$userId);
         assert($document instanceof User);

benchmark/Document/StoreDocumentBench.php

@@ -11,8 +11,10 @@
 use Documents\Group;
 use Documents\Phonenumber;
 use Documents\User;
+use PhpBench\Attributes\BeforeMethods;
 use PhpBench\Attributes\Warmup;
 
+#[BeforeMethods(['initDocumentManager', 'clearDatabase'])]
 final class StoreDocumentBench extends BaseBench
 {
     #[Warmup(2)]