Use typed properties (#2473)

Author: IonBazan

lib/Doctrine/ODM/MongoDB/APM/Command.php

@@ -13,8 +13,7 @@
 
 final class Command
 {
-    /** @var CommandStartedEvent */
-    private $startedEvent;
+    private CommandStartedEvent $startedEvent;
 
     /** @var CommandSucceededEvent|CommandFailedEvent */
     private $finishedEvent;

lib/Doctrine/ODM/MongoDB/APM/CommandLogger.php

@@ -16,13 +16,12 @@
 final class CommandLogger implements Countable, CommandLoggerInterface
 {
     /** @var Command[] */
-    private $commands = [];
+    private array $commands = [];
 
     /** @var CommandStartedEvent[] */
-    private $startedCommands = [];
+    private array $startedCommands = [];
 
-    /** @var bool */
-    private $registered = false;
+    private bool $registered = false;
 
     public function register(): void
     {

lib/Doctrine/ODM/MongoDB/Aggregation/Aggregation.php

@@ -19,23 +19,19 @@
 
 final class Aggregation implements IteratorAggregate
 {
-    /** @var DocumentManager */
-    private $dm;
+    private DocumentManager $dm;
 
-    /** @var ClassMetadata|null */
-    private $classMetadata;
+    private ?ClassMetadata $classMetadata;
 
-    /** @var Collection */
-    private $collection;
+    private Collection $collection;
 
     /** @var array<string, mixed> */
-    private $pipeline;
+    private array $pipeline;
 
     /** @var array<string, mixed> */
-    private $options;
+    private array $options;
 
-    /** @var bool */
-    private $rewindable;
+    private bool $rewindable;
 
     /**
      * @param array<string, mixed> $pipeline

lib/Doctrine/ODM/MongoDB/Aggregation/Builder.php

@@ -34,36 +34,26 @@ class Builder
 {
     /**
      * The DocumentManager instance for this query
-     *
-     * @var DocumentManager
      */
-    private $dm;
+    private DocumentManager $dm;
 
     /**
      * The ClassMetadata instance.
-     *
-     * @var ClassMetadata
      */
-    private $class;
+    private ClassMetadata $class;
 
-    /**
-     * @var string
-     * @psalm-var class-string
-     */
-    private $hydrationClass;
+    /** @psalm-var class-string */
+    private ?string $hydrationClass = null;
 
     /**
      * The Collection instance.
-     *
-     * @var Collection
      */
-    private $collection;
+    private Collection $collection;
 
     /** @var Stage[] */
-    private $stages = [];
+    private array $stages = [];
 
-    /** @var bool */
-    private $rewindable = true;
+    private bool $rewindable = true;
 
     /**
      * Create a new aggregation builder.

lib/Doctrine/ODM/MongoDB/Aggregation/Expr.php

@@ -25,24 +25,20 @@
  */
 class Expr
 {
-    /** @var DocumentManager */
-    private $dm;
+    private DocumentManager $dm;
 
-    /** @var ClassMetadata */
-    private $class;
+    private ClassMetadata $class;
 
     /** @var array<string, mixed> */
-    private $expr = [];
+    private array $expr = [];
 
     /**
      * The current field we are operating on.
-     *
-     * @var string
      */
-    private $currentField;
+    private ?string $currentField = null;
 
     /** @var array{case: mixed|self, then?: mixed|self}|null */
-    private $switchBranch;
+    private ?array $switchBranch = null;
 
     public function __construct(DocumentManager $dm, ClassMetadataInterface $class)
     {

lib/Doctrine/ODM/MongoDB/Aggregation/Stage/AbstractBucket.php

@@ -24,11 +24,9 @@
  */
 abstract class AbstractBucket extends Stage
 {
-    /** @var DocumentManager */
-    private $dm;
+    private DocumentManager $dm;
 
-    /** @var ClassMetadata */
-    private $class;
+    private ClassMetadata $class;
 
     /** @var Bucket\AbstractOutput|null */
     protected $output;

lib/Doctrine/ODM/MongoDB/Aggregation/Stage/Bucket.php

@@ -12,7 +12,7 @@
 class Bucket extends AbstractBucket
 {
     /** @var mixed[] */
-    private $boundaries;
+    private array $boundaries;
 
     /** @var mixed */
     private $default;
@@ -70,7 +70,8 @@ public function output(): Bucket\BucketOutput
      */
     protected function getExtraPipelineFields(): array
     {
-        $fields = ['boundaries' => $this->boundaries];
+        /** @psalm-suppress RedundantPropertyInitializationCheck because the property might not be set yet */
+        $fields = ['boundaries' => $this->boundaries ?? null];
         if ($this->default !== null) {
             $fields['default'] = $this->default;
         }

lib/Doctrine/ODM/MongoDB/Aggregation/Stage/Bucket/AbstractOutput.php

@@ -18,8 +18,7 @@ abstract class AbstractOutput extends Stage
     /** @var Stage\AbstractBucket */
     protected $bucket;
 
-    /** @var Expr */
-    private $expr;
+    private Expr $expr;
 
     public function __construct(Builder $builder, Stage\AbstractBucket $bucket)
     {

lib/Doctrine/ODM/MongoDB/Aggregation/Stage/BucketAuto.php

@@ -11,11 +11,9 @@
  */
 class BucketAuto extends AbstractBucket
 {
-    /** @var int */
-    private $buckets;
+    private ?int $buckets = null;
 
-    /** @var string|null */
-    private $granularity;
+    private ?string $granularity = null;
 
     /**
      * A positive 32-bit integer that specifies the number of buckets into which

lib/Doctrine/ODM/MongoDB/Aggregation/Stage/CollStats.php

@@ -16,11 +16,9 @@ class CollStats extends Stage
     public const LATENCY_STATS_SIMPLE     = 1;
     public const LATENCY_STATS_HISTOGRAMS = 2;
 
-    /** @var int */
-    private $latencyStats = self::LATENCY_STATS_NONE;
+    private int $latencyStats = self::LATENCY_STATS_NONE;
 
-    /** @var bool */
-    private $storageStats = false;
+    private bool $storageStats = false;
 
     public function __construct(Builder $builder)
     {