Skip to content

Commit 6a6e234

Browse files
committed
Optimize getting type from value class name
relying on an exception is inefficient
1 parent e676197 commit 6a6e234

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

lib/Doctrine/ODM/MongoDB/Types/Type.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -171,18 +171,18 @@ public static function getTypeFromPHPVariable($variable): ?Type
171171
}
172172

173173
// Try the variable class as type name
174-
try {
174+
if (self::hasType($variable::class)) {
175175
return self::getType($variable::class);
176-
} catch (InvalidTypeException) {
177-
return null;
178176
}
177+
178+
return null;
179179
}
180180

181181
return match (gettype($variable)) {
182-
'integer' => self::getType('int'),
183-
'boolean' => self::getType('bool'),
184-
'double' => self::getType('float'),
185-
'string' => self::getType('string'),
182+
'integer' => self::getType(self::INT),
183+
'boolean' => self::getType(self::BOOL),
184+
'double' => self::getType(self::FLOAT),
185+
'string' => self::getType(self::STRING),
186186
default => null,
187187
};
188188
}

0 commit comments

Comments
 (0)