Don't include static properties in skipped properties (#2972)

* Don't include static properties in skipped properties

Otherwise, `skipLazyInitialization()` is called on the reflection of static properties, resulting in an error.

* Add test in ProxyFactoryTest to ensure we have the same behavior for all proxy implementations

Author: MidnightDesign

src/Proxy/Factory/NativeLazyObjectFactory.php

@@ -101,6 +101,10 @@ private function getSkippedProperties(ClassMetadata $metadata): array
                 continue;
             }
 
+            if ($property->isStatic()) {
+                continue;
+            }
+
             $skippedProperties[] = $property;
         }
 

tests/Documents/DocumentWithStaticProperty.php

@@ -0,0 +1,21 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Documents;
+
+use Doctrine\ODM\MongoDB\Mapping\Annotations as ODM;
+
+#[ODM\Document]
+class DocumentWithStaticProperty
+{
+    #[ODM\Id]
+    public string $id;
+
+    public static string $foo = 'bar';
+
+    // We need at least one mapped field to avoid the native lazy object to be
+    // switched to "initialized" state immediately after setting all its properties.
+    #[ODM\Field]
+    public string $mappedField;
+}

tests/Tests/Functional/ReferencesTest.php

@@ -15,6 +15,7 @@
 use Doctrine\ODM\MongoDB\Tests\BaseTestCase;
 use Documents\Account;
 use Documents\Address;
+use Documents\DocumentWithStaticProperty;
 use Documents\DocumentWithUnmappedProperties;
 use Documents\Group;
 use Documents\Phonenumber;
@@ -38,6 +39,15 @@ public function testSkipInitializationForUnmappedProperties(): void
         self::assertTrue($this->dm->isUninitializedObject($loadedDocument));
     }
 
+    public function testSkipInitializationForStaticProperties(): void
+    {
+        $loadedDocument = $this->dm->getReference(DocumentWithStaticProperty::class, '123');
+        $this->assertInstanceOf(DocumentWithStaticProperty::class, $loadedDocument);
+
+        self::assertSame('bar', $loadedDocument::$foo);
+        self::assertTrue($this->dm->isUninitializedObject($loadedDocument));
+    }
+
     public function testManyDeleteReference(): void
     {
         $user = new User();

tests/Tests/Proxy/Factory/ProxyFactoryTest.php

@@ -12,6 +12,7 @@
 use Doctrine\ODM\MongoDB\Proxy\InternalProxy;
 use Doctrine\ODM\MongoDB\Tests\BaseTestCase;
 use Documents\Cart;
+use Documents\DocumentWithStaticProperty;
 use Documents\DocumentWithUnmappedProperties;
 use MongoDB\Client;
 use MongoDB\Collection;
@@ -95,6 +96,23 @@ public function testCreateProxyForDocumentWithUnmappedProperties(): void
 
         self::assertSame('bar', $proxy->foo);
     }
+
+    public function testCreateProxyForDocumentWithStaticProperties(): void
+    {
+        $proxy = $this->dm->getReference(DocumentWithStaticProperty::class, '123');
+        self::assertTrue(self::isLazyObject($proxy));
+
+        // Disable initializer so we can access properties without initialising the object
+        if ($proxy instanceof InternalProxy) {
+            $proxy->__setInitialized(true);
+        } elseif ($proxy instanceof GhostObjectInterface) {
+            $proxy->setProxyInitializer(null);
+        } elseif ($this->dm->getConfiguration()->isNativeLazyObjectEnabled()) {
+            $this->dm->getClassMetadata($proxy::class)->getReflectionClass()->markLazyObjectAsInitialized($proxy);
+        }
+
+        self::assertSame('bar', $proxy::$foo);
+    }
 }
 
 class DocumentNotFoundListener