Remove calls to ReflectionMethod::setAccessible (#2751)

Author: GromNaN

tests/Doctrine/ODM/MongoDB/Tests/Functional/DocumentPersisterTest.php

@@ -638,7 +638,6 @@ public function testExecuteInsertsRespectsWriteConcern(string $class, string|int
             ->with($this->isType('array'), $this->logicalAnd($this->arrayHasKey('writeConcern'), $this->containsEqual(new WriteConcern($writeConcern))));
 
         $reflectionProperty = new ReflectionProperty($documentPersister, 'collection');
-        $reflectionProperty->setAccessible(true);
         $reflectionProperty->setValue($documentPersister, $collection);
 
         $testDocument = new $class();
@@ -660,7 +659,6 @@ public function testExecuteInsertsOmitsWriteConcernInTransaction(string $class,
             ->with($this->isType('array'), $this->logicalNot($this->arrayHasKey('writeConcern')));
 
         $reflectionProperty = new ReflectionProperty($documentPersister, 'collection');
-        $reflectionProperty->setAccessible(true);
         $reflectionProperty->setValue($documentPersister, $collection);
 
         $testDocument = new $class();
@@ -682,7 +680,6 @@ public function testExecuteUpsertsRespectsWriteConcern(string $class, string|int
             ->with($this->isType('array'), $this->isType('array'), $this->logicalAnd($this->arrayHasKey('writeConcern'), $this->containsEqual(new WriteConcern($writeConcern))));
 
         $reflectionProperty = new ReflectionProperty($documentPersister, 'collection');
-        $reflectionProperty->setAccessible(true);
         $reflectionProperty->setValue($documentPersister, $collection);
 
         $testDocument     = new $class();
@@ -705,7 +702,6 @@ public function testExecuteUpsertsDoesNotUseWriteConcernInTransaction(string $cl
             ->with($this->isType('array'), $this->logicalNot($this->arrayHasKey('writeConcern')));
 
         $reflectionProperty = new ReflectionProperty($documentPersister, 'collection');
-        $reflectionProperty->setAccessible(true);
         $reflectionProperty->setValue($documentPersister, $collection);
 
         $testDocument     = new $class();
@@ -728,7 +724,6 @@ public function testRemoveRespectsWriteConcern(string $class, string|int $writeC
             ->with($this->isType('array'), $this->logicalAnd($this->arrayHasKey('writeConcern'), $this->containsEqual(new WriteConcern($writeConcern))));
 
         $reflectionProperty = new ReflectionProperty($documentPersister, 'collection');
-        $reflectionProperty->setAccessible(true);
         $reflectionProperty->setValue($documentPersister, $collection);
 
         $testDocument = new $class();
@@ -753,7 +748,6 @@ public function testRemoveDoesNotUseWriteConcernInTransaction(string $class, str
             ->with($this->isType('array'), $this->logicalNot($this->arrayHasKey('writeConcern')));
 
         $reflectionProperty = new ReflectionProperty($documentPersister, 'collection');
-        $reflectionProperty->setAccessible(true);
         $reflectionProperty->setValue($documentPersister, $collection);
 
         $testDocument = new $class();
@@ -777,7 +771,6 @@ public function testDefaultWriteConcernIsRespected(): void
             ->with($this->isType('array'), $this->equalTo(['writeConcern' => new WriteConcern(0)]));
 
         $reflectionProperty = new ReflectionProperty($documentPersister, 'collection');
-        $reflectionProperty->setAccessible(true);
         $reflectionProperty->setValue($documentPersister, $collection);
 
         $this->dm->getConfiguration()->setDefaultCommitOptions(['writeConcern' => new WriteConcern(0)]);
@@ -800,7 +793,6 @@ public function testDefaultWriteConcernIsIgnoredInTransaction(): void
             ->with($this->isType('array'), $this->logicalNot($this->arrayHasKey('writeConcern')));
 
         $reflectionProperty = new ReflectionProperty($documentPersister, 'collection');
-        $reflectionProperty->setAccessible(true);
         $reflectionProperty->setValue($documentPersister, $collection);
 
         $this->dm->getConfiguration()->setDefaultCommitOptions(['writeConcern' => new WriteConcern(1)]);
@@ -823,7 +815,6 @@ public function testDefaultWriteConcernIsRespectedBackwardCompatibility(): void
             ->with($this->isType('array'), $this->equalTo(['writeConcern' => new WriteConcern(0)]));
 
         $reflectionProperty = new ReflectionProperty($documentPersister, 'collection');
-        $reflectionProperty->setAccessible(true);
         $reflectionProperty->setValue($documentPersister, $collection);
 
         $this->dm->getConfiguration()->setDefaultCommitOptions(['w' => 0]);

tests/Doctrine/ODM/MongoDB/Tests/Functional/SplObjectHashCollisionsTest.php

@@ -77,7 +77,6 @@ private function expectCount(string $prop, int $expected): void
     {
         $ro = new ReflectionObject($this->uow);
         $rp = $ro->getProperty($prop);
-        $rp->setAccessible(true);
         self::assertCount($expected, $rp->getValue($this->uow));
     }
 }

tests/Doctrine/ODM/MongoDB/Tests/Mapping/XmlMappingDriverTest.php

@@ -29,7 +29,6 @@ public function testSetShardKeyOptionsByAttributes(): void
 
         /** @uses XmlDriver::setShardKey */
         $m = new ReflectionMethod($driver::class, 'setShardKey');
-        $m->setAccessible(true);
         $m->invoke($driver, $class, $element);
 
         self::assertTrue($class->isSharded());

tests/Doctrine/ODM/MongoDB/Tests/Persisters/DocumentPersisterGetShardKeyQueryTest.php

@@ -26,7 +26,6 @@ public function testGetShardKeyQueryScalars(): void
         $persister = $this->uow->getDocumentPersister($o::class);
 
         $method = new ReflectionMethod($persister, 'getShardKeyQuery');
-        $method->setAccessible(true);
 
         self::assertSame(
             ['int' => $o->int, 'string' => $o->string, 'bool' => $o->bool, 'float' => $o->float],
@@ -43,8 +42,7 @@ public function testGetShardKeyQueryObjects(): void
 
         $persister = $this->uow->getDocumentPersister($o::class);
 
-        $method = new ReflectionMethod($persister, 'getShardKeyQuery');
-        $method->setAccessible(true);
+        $method        = new ReflectionMethod($persister, 'getShardKeyQuery');
         $shardKeyQuery = $method->invoke($persister, $o);
 
         self::assertInstanceOf(ObjectId::class, $shardKeyQuery['oid']);
@@ -69,8 +67,7 @@ public function testShardById(): void
 
         $persister = $this->uow->getDocumentPersister($o::class);
 
-        $method = new ReflectionMethod($persister, 'getShardKeyQuery');
-        $method->setAccessible(true);
+        $method        = new ReflectionMethod($persister, 'getShardKeyQuery');
         $shardKeyQuery = $method->invoke($persister, $o);
 
         self::assertSame(['_id' => $o->identifier], $shardKeyQuery);
@@ -88,8 +85,7 @@ public function testShardByReference(): void
 
         $persister = $this->uow->getDocumentPersister($o::class);
 
-        $method = new ReflectionMethod($persister, 'getShardKeyQuery');
-        $method->setAccessible(true);
+        $method        = new ReflectionMethod($persister, 'getShardKeyQuery');
         $shardKeyQuery = $method->invoke($persister, $o);
 
         self::assertSame(['reference.$id' => $userId], $shardKeyQuery);

tests/Doctrine/ODM/MongoDB/Tests/Query/BuilderTest.php

@@ -479,7 +479,6 @@ public function testProxiedExprMethods(string $method, array $args = []): void
 
         $qb                 = $this->getTestQueryBuilder();
         $reflectionProperty = new ReflectionProperty($qb, 'expr');
-        $reflectionProperty->setAccessible(true);
         $reflectionProperty->setValue($qb, $expr);
 
         self::assertSame($qb, $qb->$method(...$args));

tests/Doctrine/ODM/MongoDB/Tests/UnitOfWorkTest.php

@@ -535,7 +535,6 @@ public function testTransactionalCommitOmitsWriteConcernInOperation(): void
         $documentPersister = $this->uow->getDocumentPersister(ForumUser::class);
 
         $reflectionProperty = new ReflectionProperty($documentPersister, 'collection');
-        $reflectionProperty->setAccessible(true);
         $reflectionProperty->setValue($documentPersister, $collection);
 
         $user           = new ForumUser();