Schema:create fails with single collection inheritance (#2392)

* Schema:create fails with single collection inheritance

* add test

* Add assertion of inheritance of single collection type for Tournament class

Co-authored-by: Ion Bazan <[email protected]>

Author: JJarrie

lib/Doctrine/ODM/MongoDB/SchemaManager.php

@@ -390,12 +390,22 @@ public function updateDocumentValidator(string $documentName, ?int $maxTimeMs =
      */
     public function createCollections(?int $maxTimeMs = null, ?WriteConcern $writeConcern = null): void
     {
+        $singleInheritanceProcessed = [];
+
         foreach ($this->metadataFactory->getAllMetadata() as $class) {
             assert($class instanceof ClassMetadata);
             if ($class->isMappedSuperclass || $class->isEmbeddedDocument || $class->isQueryResultDocument) {
                 continue;
             }
 
+            if ($class->inheritanceType === ClassMetadata::INHERITANCE_TYPE_SINGLE_COLLECTION) {
+                if (in_array($class->collection, $singleInheritanceProcessed)) {
+                    continue;
+                }
+
+                $singleInheritanceProcessed[] = $class->collection;
+            }
+
             $this->createDocumentCollection($class->name, $maxTimeMs, $writeConcern);
         }
     }

tests/Doctrine/ODM/MongoDB/Tests/SchemaManagerTest.php

@@ -20,6 +20,7 @@
 use Documents\Sharded\ShardedOne;
 use Documents\Sharded\ShardedOneWithDifferentKey;
 use Documents\SimpleReferenceUser;
+use Documents\Tournament\Tournament;
 use Documents\UserName;
 use InvalidArgumentException;
 use MongoDB\Client;
@@ -37,6 +38,7 @@
 use PHPUnit\Framework\Constraint\IsEqual;
 use PHPUnit\Framework\MockObject\MockObject;
 
+use function array_count_values;
 use function array_map;
 use function assert;
 use function class_exists;
@@ -608,11 +610,18 @@ public function testCreateView(array $expectedWriteOptions, ?int $maxTimeMs, ?Wr
      */
     public function testCreateCollections(array $expectedWriteOptions, ?int $maxTimeMs, ?WriteConcern $writeConcern): void
     {
-        foreach ($this->documentDatabases as $class => $database) {
+        $class = $this->dm->getClassMetadata(Tournament::class);
+        self::assertSame(ClassMetadata::INHERITANCE_TYPE_SINGLE_COLLECTION, $class->inheritanceType);
+
+        $createdCollections = [];
+        foreach ($this->documentDatabases as $database) {
             $database
                 ->expects($this->atLeastOnce())
                 ->method('createCollection')
-                ->with($this->anything(), $this->writeOptions($expectedWriteOptions));
+                ->with($this->anything(), $this->writeOptions($expectedWriteOptions))
+                ->willReturnCallback(static function (string $collectionName) use (&$createdCollections): void {
+                    $createdCollections[] = $collectionName;
+                });
 
             $database
                 ->expects($this->atLeastOnce())
@@ -621,6 +630,7 @@ public function testCreateCollections(array $expectedWriteOptions, ?int $maxTime
         }
 
         $this->schemaManager->createCollections($maxTimeMs, $writeConcern);
+        self::assertSame(1, array_count_values($createdCollections)['Tournament']);
     }
 
     /**