Fix some psalm findings

Author: franmomu

tests/Doctrine/ODM/MongoDB/Tests/Aggregation/Stage/FacetTest.php

@@ -66,6 +66,9 @@ public function testFacetThrowsExceptionWithoutFieldName()
         $facetStage->pipeline($this->getTestAggregationBuilder());
     }
 
+    /**
+     * @psalm-suppress InvalidArgument on purpose to throw exception
+     */
     public function testFacetThrowsExceptionOnInvalidPipeline()
     {
         $facetStage = new Facet($this->getTestAggregationBuilder());

tests/Doctrine/ODM/MongoDB/Tests/Functional/LockTest.php

@@ -570,6 +570,8 @@ abstract class AbstractVersionBase
     /** @ODM\EmbedMany(targetDocument=Issue::class) */
     public $issues;
 
+    public $version;
+
     public function __construct($title = null)
     {
         $this->issues = new ArrayCollection();

tests/Doctrine/ODM/MongoDB/Tests/Functional/QueryTest.php

@@ -4,6 +4,7 @@
 
 namespace Doctrine\ODM\MongoDB\Tests\Functional;
 
+use Doctrine\ODM\MongoDB\Iterator\Iterator;
 use Doctrine\ODM\MongoDB\Tests\BaseTest;
 use Documents\Article;
 use Documents\CmsComment;
@@ -18,6 +19,7 @@
 use MongoDB\BSON\UTCDateTime;
 
 use function array_values;
+use function assert;
 use function get_class;
 use function iterator_to_array;
 use function strtotime;
@@ -396,7 +398,11 @@ public function testNestedQueryReference()
             ->field('indirectlyReferencedUsers.user.id')->equals(new ObjectId($referencedUser->getId()))
             ->getQuery();
 
-        $referencedUsers = iterator_to_array($referencedUsersQuery->execute(), false);
+        $referencedUsersIterator = $referencedUsersQuery->execute();
+
+        assert($referencedUsersIterator instanceof Iterator);
+
+        $referencedUsers = iterator_to_array($referencedUsersIterator, false);
 
         $this->assertCount(1, $referencedUsers);
         $this->assertSame($user, $referencedUsers[0]);

tests/Doctrine/ODM/MongoDB/Tests/Functional/Ticket/GH453Test.php

@@ -146,7 +146,7 @@ public function testEmbedMany()
         $this->assertBsonArray($doc->id, 'embedManyAddToSet');
 
         // Check that the value is changed properly
-        unset($colPush[1], $colSet[1], $colSetArray[1], $colAddToSet['1']);
+        unset($colPush[1], $colSet[1], $colSetArray[1], $colAddToSet[1]);
         $doc                    = $this->dm->merge($doc);
         $doc->embedManyPush     = $colPush;
         $doc->embedManySet      = $colSet;

tests/Doctrine/ODM/MongoDB/Tests/Mapping/ClassMetadataTest.php

@@ -418,8 +418,7 @@ public function testSetFieldValueWithProxy()
 
     public function testSetCustomRepositoryClass()
     {
-        $cm            = new ClassMetadata(self::class);
-        $cm->namespace = 'Doctrine\ODM\MongoDB\Tests\Mapping';
+        $cm = new ClassMetadata(self::class);
 
         $cm->setCustomRepositoryClass(Repository::class);