Fix array_filter call returning a scalar

franmomu · franmomu · commit faf7ef6598d5 · 2021-06-26T16:05:15.000+02:00
diff --git a/lib/Doctrine/ODM/MongoDB/Tools/Console/Command/Schema/CreateCommand.php b/lib/Doctrine/ODM/MongoDB/Tools/Console/Command/Schema/CreateCommand.php
@@ -39,8 +39,8 @@ protected function configure()
 
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        $create = array_filter($this->createOrder, static function ($option) use ($input) {
-            return $input->getOption($option);
+        $create = array_filter($this->createOrder, static function (string $option) use ($input): bool {
+            return (bool) $input->getOption($option);
         });
 
         // Default to the full creation order if no options were specified
diff --git a/lib/Doctrine/ODM/MongoDB/Tools/Console/Command/Schema/DropCommand.php b/lib/Doctrine/ODM/MongoDB/Tools/Console/Command/Schema/DropCommand.php
@@ -36,8 +36,8 @@ protected function configure()
 
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        $drop = array_filter($this->dropOrder, static function ($option) use ($input) {
-            return $input->getOption($option);
+        $drop = array_filter($this->dropOrder, static function (string $option) use ($input): bool {
+            return (bool) $input->getOption($option);
         });
 
         // Default to the full drop order if no options were specified

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,8 @@ protected function configure()`
`39`	`39`
`40`	`40`	`protected function execute(InputInterface $input, OutputInterface $output)`
`41`	`41`	`{`
`42`		`- $create = array_filter($this->createOrder, static function ($option) use ($input) {`
`43`		`- return $input->getOption($option);`
	`42`	`+ $create = array_filter($this->createOrder, static function (string $option) use ($input): bool {`
	`43`	`+ return (bool) $input->getOption($option);`
`44`	`44`	`});`
`45`	`45`
`46`	`46`	`// Default to the full creation order if no options were specified`
Original file line number	Diff line number	Diff line change
`@@ -36,8 +36,8 @@ protected function configure()`
`36`	`36`
`37`	`37`	`protected function execute(InputInterface $input, OutputInterface $output)`
`38`	`38`	`{`
`39`		`- $drop = array_filter($this->dropOrder, static function ($option) use ($input) {`
`40`		`- return $input->getOption($option);`
	`39`	`+ $drop = array_filter($this->dropOrder, static function (string $option) use ($input): bool {`
	`40`	`+ return (bool) $input->getOption($option);`
`41`	`41`	`});`
`42`	`42`
`43`	`43`	`// Default to the full drop order if no options were specified`