Upgrade to doctrine/coding-standard 13 (#11881)

Author: greg0ire

composer.json

@@ -41,14 +41,14 @@
     },
     "require-dev": {
         "doctrine/annotations": "^1.13 || ^2",
-        "doctrine/coding-standard": "^9.0.2 || ^12.0",
+        "doctrine/coding-standard": "^9.0.2 || ^13.0",
         "phpbench/phpbench": "^0.16.10 || ^1.0",
         "phpstan/extension-installer": "~1.1.0 || ^1.4",
         "phpstan/phpstan": "~1.4.10 || 2.0.3",
         "phpstan/phpstan-deprecation-rules": "^1 || ^2",
         "phpunit/phpunit": "^7.5 || ^8.5 || ^9.6",
         "psr/log": "^1 || ^2 || ^3",
-        "squizlabs/php_codesniffer": "3.7.2",
+        "squizlabs/php_codesniffer": "3.12.0",
         "symfony/cache": "^4.4 || ^5.4 || ^6.4 || ^7.0",
         "symfony/var-exporter": "^4.4 || ^5.4 || ^6.2 || ^7.0",
         "symfony/yaml": "^3.4 || ^4.0 || ^5.0 || ^6.0 || ^7.0"

src/Mapping/ClassMetadataInfo.php

@@ -1278,7 +1278,6 @@ public function enableAssociationCache($fieldName, array $cache)
 
     /**
      * @param string $fieldName
-     * @param array  $cache
      * @phpstan-param array{usage?: int|null, region?: string|null} $cache
      *
      * @return int[]|string[]

tests/Tests/Mocks/ConnectionMock.php

@@ -118,13 +118,11 @@ public function setDatabasePlatform(AbstractPlatform $platform): void
         $this->_platformMock = $platform;
     }
 
-    /** @return array */
     public function getExecuteStatements(): array
     {
         return $this->_executeStatements;
     }
 
-    /** @return array */
     public function getDeletes(): array
     {
         return $this->_deletes;

tests/Tests/ORM/Mapping/Reflection/ReflectionPropertiesGetterTest.php

@@ -84,7 +84,7 @@ public function testPropertiesAreAccessible(): void
 
     public function testPropertyGetterIsIdempotent(): void
     {
-        $getter = (new ReflectionPropertiesGetter(new RuntimeReflectionService()));
+        $getter = new ReflectionPropertiesGetter(new RuntimeReflectionService());
 
         self::assertSame(
             $getter->getProperties(ClassWithMixedProperties::class),
@@ -110,7 +110,7 @@ public function testPropertyGetterWillSkipPropertiesNotRetrievedByTheRuntimeRefl
             ->expects(self::atLeastOnce())
             ->method('getAccessibleProperty');
 
-        $getter = (new ReflectionPropertiesGetter($reflectionService));
+        $getter = new ReflectionPropertiesGetter($reflectionService);
 
         self::assertEmpty($getter->getProperties(ClassWithMixedProperties::class));
     }
@@ -127,7 +127,7 @@ public function testPropertyGetterWillSkipClassesNotRetrievedByTheRuntimeReflect
 
         $reflectionService->expects(self::never())->method('getAccessibleProperty');
 
-        $getter = (new ReflectionPropertiesGetter($reflectionService));
+        $getter = new ReflectionPropertiesGetter($reflectionService);
 
         self::assertEmpty($getter->getProperties(ClassWithMixedProperties::class));
     }

tests/Tests/OrmFunctionalTestCase.php

@@ -679,8 +679,6 @@ protected function tearDown(): void
     }
 
     /**
-     * @param array $classNames
-     *
      * @throws RuntimeException
      */
     protected function setUpEntitySchema(array $classNames): void