Skip to content

Commit 16f355f

Browse files
committed
Remove tests for already working case as they add no value other than exploration, and we only need the regression test.
1 parent e5e3166 commit 16f355f

File tree

7 files changed

+6
-131
lines changed

7 files changed

+6
-131
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
declare(strict_types=1);
44

5-
namespace Doctrine\Tests\Models\AbstractFetchEager\WithFetchEager;
5+
namespace Doctrine\Tests\Models\AbstractFetchEager;
66

77
use Doctrine\Common\Collections\ArrayCollection;
88
use Doctrine\Common\Collections\Collection;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
declare(strict_types=1);
44

5-
namespace Doctrine\Tests\Models\AbstractFetchEager\WithFetchEager;
5+
namespace Doctrine\Tests\Models\AbstractFetchEager;
66

77
use Doctrine\ORM\Mapping as ORM;
88

tests/Tests/Models/AbstractFetchEager/WithFetchEager/User.php renamed to tests/Tests/Models/AbstractFetchEager/User.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
declare(strict_types=1);
44

5-
namespace Doctrine\Tests\Models\AbstractFetchEager\WithFetchEager;
5+
namespace Doctrine\Tests\Models\AbstractFetchEager;
66

77
use Doctrine\ORM\Mapping as ORM;
88

tests/Tests/Models/AbstractFetchEager/WithoutFetchEager/AbstractRemoveControl.php

Lines changed: 0 additions & 49 deletions
This file was deleted.

tests/Tests/Models/AbstractFetchEager/WithoutFetchEager/MobileRemoteControl.php

Lines changed: 0 additions & 14 deletions
This file was deleted.

tests/Tests/Models/AbstractFetchEager/WithoutFetchEager/User.php

Lines changed: 0 additions & 35 deletions
This file was deleted.

tests/Tests/ORM/Functional/AbstractFetchEagerTest.php

Lines changed: 3 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,9 @@
44

55
namespace Doctrine\Tests\ORM\Functional;
66

7-
use Doctrine\Tests\Models\AbstractFetchEager\WithFetchEager\AbstractRemoveControl;
8-
use Doctrine\Tests\Models\AbstractFetchEager\WithFetchEager\MobileRemoteControl;
9-
use Doctrine\Tests\Models\AbstractFetchEager\WithFetchEager\User;
10-
use Doctrine\Tests\Models\AbstractFetchEager\WithoutFetchEager\AbstractRemoveControl as AbstractRemoveControlWithoutFetchEager;
11-
use Doctrine\Tests\Models\AbstractFetchEager\WithoutFetchEager\MobileRemoteControl as MobileRemoteControlWithoutFetchEager;
12-
use Doctrine\Tests\Models\AbstractFetchEager\WithoutFetchEager\User as UserWithoutFetchEager;
7+
use Doctrine\Tests\Models\AbstractFetchEager\AbstractRemoveControl;
8+
use Doctrine\Tests\Models\AbstractFetchEager\MobileRemoteControl;
9+
use Doctrine\Tests\Models\AbstractFetchEager\User;
1310
use Doctrine\Tests\OrmFunctionalTestCase;
1411

1512
final class AbstractFetchEagerTest extends OrmFunctionalTestCase
@@ -37,28 +34,4 @@ public function testWithAbstractFetchEager(): void
3734
self::assertEquals('smart', $user->remoteControl->name);
3835
self::assertTrue($user->remoteControl->users->contains($user));
3936
}
40-
41-
public function testWithoutAbstractFetchEager(): void
42-
{
43-
$this->createSchemaForModels(
44-
AbstractRemoveControlWithoutFetchEager::class,
45-
UserWithoutFetchEager::class
46-
);
47-
48-
$control = new MobileRemoteControlWithoutFetchEager('smart');
49-
$user = new UserWithoutFetchEager($control);
50-
51-
$entityManage = $this->getEntityManager();
52-
53-
$entityManage->persist($control);
54-
$entityManage->persist($user);
55-
$entityManage->flush();
56-
$entityManage->clear();
57-
58-
$user = $entityManage->find(UserWithoutFetchEager::class, $user->id);
59-
60-
self::assertNotNull($user);
61-
self::assertEquals('smart', $user->remoteControl->name);
62-
self::assertTrue($user->remoteControl->users->contains($user));
63-
}
6437
}

0 commit comments

Comments
 (0)