Merge pull request #11912 from xabbuh/dbal-6823

[#6823] pass unquoted identifier folding to AbstractPlatform

Author: greg0ire

tests/Tests/ORM/Mapping/DefaultQuoteStrategyTest.php

@@ -5,12 +5,14 @@
 namespace Doctrine\Tests\ORM\Mapping;
 
 use Doctrine\DBAL\Platforms\AbstractPlatform;
+use Doctrine\DBAL\Schema\Name\UnquotedIdentifierFolding;
 use Doctrine\ORM\Mapping\DefaultQuoteStrategy;
 use Doctrine\Tests\Models\NonPublicSchemaJoins\User as NonPublicSchemaUser;
 use Doctrine\Tests\OrmTestCase;
 use PHPUnit\Framework\Attributes\Group;
 
 use function assert;
+use function enum_exists;
 
 /**
  * Doctrine\Tests\ORM\Mapping\DefaultQuoteStrategyTest
@@ -24,7 +26,7 @@ public function testGetJoinTableName(): void
         $em       = $this->getTestEntityManager();
         $metadata = $em->getClassMetadata(NonPublicSchemaUser::class);
         $strategy = new DefaultQuoteStrategy();
-        $platform = $this->getMockForAbstractClass(AbstractPlatform::class);
+        $platform = $this->getMockForAbstractClass(AbstractPlatform::class, enum_exists(UnquotedIdentifierFolding::class) ? [UnquotedIdentifierFolding::UPPER] : []);
         assert($platform instanceof AbstractPlatform);
 
         self::assertSame(

tests/Tests/ORM/Persisters/BasicEntityPersisterTypeValueSqlTest.php

@@ -9,6 +9,7 @@
 use Doctrine\DBAL\Connection;
 use Doctrine\DBAL\Driver;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
+use Doctrine\DBAL\Schema\Name\UnquotedIdentifierFolding;
 use Doctrine\DBAL\Types\Type as DBALType;
 use Doctrine\ORM\Mapping\OneToManyAssociationMapping;
 use Doctrine\ORM\Persisters\Entity\BasicEntityPersister;
@@ -23,6 +24,7 @@
 use ReflectionMethod;
 
 use function array_slice;
+use function enum_exists;
 
 class BasicEntityPersisterTypeValueSqlTest extends OrmTestCase
 {
@@ -65,6 +67,7 @@ public function testUpdateUsesTypeValuesSQL(): void
             ->willReturn($this->createMock(Driver\Connection::class));
 
         $platform = $this->getMockBuilder(AbstractPlatform::class)
+            ->setConstructorArgs(enum_exists(UnquotedIdentifierFolding::class) ? [UnquotedIdentifierFolding::UPPER] : [])
             ->onlyMethods(['supportsIdentityColumns'])
             ->getMockForAbstractClass();
         $platform->method('supportsIdentityColumns')

tests/Tests/ORM/Persisters/ManyToManyPersisterTest.php

@@ -7,6 +7,7 @@
 use Doctrine\DBAL\Connection;
 use Doctrine\DBAL\Driver;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
+use Doctrine\DBAL\Schema\Name\UnquotedIdentifierFolding;
 use Doctrine\ORM\Persisters\Collection\ManyToManyPersister;
 use Doctrine\Tests\Models\ManyToManyPersister\ChildClass;
 use Doctrine\Tests\Models\ManyToManyPersister\OtherParentClass;
@@ -15,6 +16,8 @@
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\Group;
 
+use function enum_exists;
+
 #[CoversClass(ManyToManyPersister::class)]
 final class ManyToManyPersisterTest extends OrmTestCase
 {
@@ -31,7 +34,7 @@ public function testDeleteManyToManyCollection(): void
             ->onlyMethods(['executeStatement', 'getDatabasePlatform'])
             ->getMock();
         $connection->method('getDatabasePlatform')
-            ->willReturn($this->getMockForAbstractClass(AbstractPlatform::class));
+            ->willReturn($this->getMockForAbstractClass(AbstractPlatform::class, enum_exists(UnquotedIdentifierFolding::class) ? [UnquotedIdentifierFolding::UPPER] : []));
 
         $parent      = new ParentClass(1);
         $otherParent = new OtherParentClass(42);

tests/Tests/ORM/Query/QueryTest.php

@@ -14,6 +14,7 @@
 use Doctrine\DBAL\LockMode;
 use Doctrine\DBAL\ParameterType;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
+use Doctrine\DBAL\Schema\Name\UnquotedIdentifierFolding;
 use Doctrine\DBAL\Types\Types;
 use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\Query;
@@ -39,6 +40,7 @@
 use Symfony\Component\Cache\Adapter\ArrayAdapter;
 
 use function array_map;
+use function enum_exists;
 
 class QueryTest extends OrmTestCase
 {
@@ -597,6 +599,7 @@ private function createConnection(Result ...$results): Connection
             ->will($this->onConsecutiveCalls(...$results));
 
         $platform = $this->getMockBuilder(AbstractPlatform::class)
+            ->setConstructorArgs(enum_exists(UnquotedIdentifierFolding::class) ? [UnquotedIdentifierFolding::UPPER] : [])
             ->onlyMethods(['supportsIdentityColumns'])
             ->getMockForAbstractClass();
         $platform->method('supportsIdentityColumns')

tests/Tests/ORM/Tools/Pagination/PaginatorTest.php

@@ -8,6 +8,7 @@
 use Doctrine\DBAL\Driver;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Result;
+use Doctrine\DBAL\Schema\Name\UnquotedIdentifierFolding;
 use Doctrine\ORM\Decorator\EntityManagerDecorator;
 use Doctrine\ORM\EntityManagerInterface;
 use Doctrine\ORM\Internal\Hydration\AbstractHydrator;
@@ -17,6 +18,8 @@
 use Doctrine\Tests\OrmTestCase;
 use PHPUnit\Framework\MockObject\MockObject;
 
+use function enum_exists;
+
 class PaginatorTest extends OrmTestCase
 {
     private Connection&MockObject $connection;
@@ -26,6 +29,7 @@ class PaginatorTest extends OrmTestCase
     protected function setUp(): void
     {
         $platform = $this->getMockBuilder(AbstractPlatform::class)
+            ->setConstructorArgs(enum_exists(UnquotedIdentifierFolding::class) ? [UnquotedIdentifierFolding::UPPER] : [])
             ->onlyMethods(['supportsIdentityColumns'])
             ->getMockForAbstractClass();
         $platform->method('supportsIdentityColumns')

tests/Tests/ORM/UnitOfWorkTest.php

@@ -11,6 +11,7 @@
 use Doctrine\DBAL\Driver\Statement;
 use Doctrine\DBAL\Exception;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
+use Doctrine\DBAL\Schema\Name\UnquotedIdentifierFolding;
 use Doctrine\ORM\EntityNotFoundException;
 use Doctrine\ORM\Exception\EntityIdentityCollisionException;
 use Doctrine\ORM\Mapping\ClassMetadata;
@@ -38,6 +39,7 @@
 use PHPUnit\Framework\MockObject\MockObject;
 use stdClass;
 
+use function enum_exists;
 use function random_int;
 use function uniqid;
 
@@ -533,6 +535,7 @@ public function testPreviousDetectedIllegalNewNonCascadedEntitiesAreCleanedUpOnS
     public function testCommitThrowOptimisticLockExceptionWhenConnectionCommitFails(): void
     {
         $platform = $this->getMockBuilder(AbstractPlatform::class)
+            ->setConstructorArgs(enum_exists(UnquotedIdentifierFolding::class) ? [UnquotedIdentifierFolding::UPPER] : [])
             ->onlyMethods(['supportsIdentityColumns'])
             ->getMockForAbstractClass();
         $platform->method('supportsIdentityColumns')

tests/Tests/OrmTestCase.php

@@ -9,6 +9,7 @@
 use Doctrine\DBAL\Driver\Result;
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Schema\AbstractSchemaManager;
+use Doctrine\DBAL\Schema\Name\UnquotedIdentifierFolding;
 use Doctrine\DBAL\Schema\SchemaConfig;
 use Doctrine\ORM\Cache\CacheConfiguration;
 use Doctrine\ORM\Cache\CacheFactory;
@@ -21,6 +22,7 @@
 use Psr\Cache\CacheItemPoolInterface;
 use Symfony\Component\Cache\Adapter\ArrayAdapter;
 
+use function enum_exists;
 use function method_exists;
 use function realpath;
 use function sprintf;
@@ -158,6 +160,7 @@ private function createPlatformMock(): AbstractPlatform
             ->willReturn(new SchemaConfig());
 
         $platform = $this->getMockBuilder(AbstractPlatform::class)
+            ->setConstructorArgs(enum_exists(UnquotedIdentifierFolding::class) ? [UnquotedIdentifierFolding::UPPER] : [])
             ->onlyMethods(['supportsIdentityColumns', 'createSchemaManager'])
             ->getMockForAbstractClass();
         $platform->method('supportsIdentityColumns')