Remove Configuration::ensureProductionSettings() (#9358)

Author: derrabus

UPGRADE.md

@@ -1,5 +1,15 @@
 # Upgrade to 3.0
 
+## BC BREAK: Remove cache settings inspection
+
+Doctrine does not provide its own cache implementation anymore and relies on
+the PSR-6 standard instead. As a consequence, we cannot determine anymore
+whether a given cache adapter is suitable for a production environment.
+Because of that, functionality that aims to do so has been removed:
+
+* `Configuration::ensureProductionSettings()`
+* the `orm:ensure-production-settings` console command
+
 ## BC BREAK: PSR-6-based second level cache
 
 The second level cache has been reworked to consume a PSR-6 cache. Using a
@@ -46,11 +56,6 @@ _before_ upgrading to 3.0:
 php doctrine orm:convert-mapping xml /path/to/mapping-path-converted-to-xml
 ```
 
-## BC BREAK: Remove the `orm:ensure-production-settings` console command
-
-The `orm:ensure-production-settings` console command and its implementation
-`Doctrine\ORM\Tools\Console\Command\EnsureProductionSettingsCommand` have been removed.
-
 ## BC BREAK: Remove code generators and related console commands
 
 These console commands have been removed:

lib/Doctrine/ORM/Cache/Exception/MetadataCacheNotConfigured.php

@@ -15,15 +15,9 @@
 use Doctrine\Common\Proxy\AbstractProxyFactory;
 use Doctrine\Deprecations\Deprecation;
 use Doctrine\ORM\Cache\CacheConfiguration;
-use Doctrine\ORM\Cache\Exception\CacheException;
-use Doctrine\ORM\Cache\Exception\MetadataCacheNotConfigured;
-use Doctrine\ORM\Cache\Exception\MetadataCacheUsesNonPersistentCache;
-use Doctrine\ORM\Cache\Exception\QueryCacheNotConfigured;
-use Doctrine\ORM\Cache\Exception\QueryCacheUsesNonPersistentCache;
 use Doctrine\ORM\Exception\InvalidEntityRepository;
 use Doctrine\ORM\Exception\NamedNativeQueryNotFound;
 use Doctrine\ORM\Exception\NamedQueryNotFound;
-use Doctrine\ORM\Exception\ProxyClassesAlwaysRegenerating;
 use Doctrine\ORM\Exception\UnknownEntityNamespace;
 use Doctrine\ORM\Internal\Hydration\AbstractHydrator;
 use Doctrine\ORM\Mapping\ClassMetadataFactory;
@@ -476,52 +470,6 @@ public function getNamedNativeQuery($name)
         return $this->_attributes['namedNativeQueries'][$name];
     }
 
-    /**
-     * Ensures that this Configuration instance contains settings that are
-     * suitable for a production environment.
-     *
-     * @deprecated
-     *
-     * @return void
-     *
-     * @throws ProxyClassesAlwaysRegenerating
-     * @throws CacheException If a configuration setting has a value that is not
-     *                        suitable for a production environment.
-     */
-    public function ensureProductionSettings()
-    {
-        Deprecation::triggerIfCalledFromOutside(
-            'doctrine/orm',
-            'https://github.com/doctrine/orm/pull/9074',
-            '%s is deprecated',
-            __METHOD__
-        );
-
-        $queryCacheImpl = $this->getQueryCacheImpl();
-
-        if (! $queryCacheImpl) {
-            throw QueryCacheNotConfigured::create();
-        }
-
-        if ($queryCacheImpl instanceof ArrayCache) {
-            throw QueryCacheUsesNonPersistentCache::fromDriver($queryCacheImpl);
-        }
-
-        if ($this->getAutoGenerateProxyClasses()) {
-            throw ProxyClassesAlwaysRegenerating::create();
-        }
-
-        if (! $this->getMetadataCache()) {
-            throw MetadataCacheNotConfigured::create();
-        }
-
-        $metadataCacheImpl = $this->getMetadataCacheImpl();
-
-        if ($metadataCacheImpl instanceof ArrayCache) {
-            throw MetadataCacheUsesNonPersistentCache::fromDriver($metadataCacheImpl);
-        }
-    }
-
     /**
      * Registers a custom DQL function that produces a string value.
      * Such a function can then be used in any DQL statement in any place where string

lib/Doctrine/ORM/Cache/Exception/MetadataCacheUsesNonPersistentCache.php

@@ -100,11 +100,6 @@ parameters:
 			count: 1
 			path: lib/Doctrine/ORM/Cache/TimestampQueryCacheValidator.php
 
-		-
-			message: "#^Class Doctrine\\\\Common\\\\Cache\\\\ArrayCache not found\\.$#"
-			count: 2
-			path: lib/Doctrine/ORM/Configuration.php
-
 		-
 			message: "#^Parameter \\#2 \\$cache of class Doctrine\\\\Common\\\\Annotations\\\\CachedReader constructor expects Doctrine\\\\Common\\\\Cache\\\\Cache, Doctrine\\\\Common\\\\Cache\\\\ArrayCache given\\.$#"
 			count: 1

lib/Doctrine/ORM/Cache/Exception/QueryCacheNotConfigured.php

@@ -319,11 +319,8 @@
       <code>new CachedReader($reader, new ArrayCache())</code>
       <code>new SimpleAnnotationReader()</code>
     </DeprecatedClass>
-    <DeprecatedMethod occurrences="4">
+    <DeprecatedMethod occurrences="1">
       <code>AnnotationRegistry::registerFile(__DIR__ . '/Mapping/Driver/DoctrineAnnotations.php')</code>
-      <code>getAutoGenerateProxyClasses</code>
-      <code>getMetadataCacheImpl</code>
-      <code>getQueryCacheImpl</code>
     </DeprecatedMethod>
     <RedundantCastGivenDocblockType occurrences="1">
       <code>(bool) $flag</code>

lib/Doctrine/ORM/Cache/Exception/QueryCacheUsesNonPersistentCache.php

@@ -28,7 +28,6 @@
                 <!-- We're calling the deprecated method for BC here. -->
                 <file name="lib/Doctrine/ORM/Internal/SQLResultCasing.php"/>
                 <!-- Remove on 3.0.x -->
-                <referencedMethod name="Doctrine\ORM\Configuration::ensureProductionSettings"/>
                 <referencedMethod name="Doctrine\ORM\Id\AbstractIdGenerator::generate"/>
             </errorLevel>
         </DeprecatedMethod>