Merge pull request #11924 from xabbuh/dbal-6867

prefer primary key constraints over Index::isPrimary()

Author: greg0ire

phpstan-baseline.neon

@@ -1395,7 +1395,7 @@ parameters:
 		-
 			message: '#^Call to method toString\(\) on an unknown class Doctrine\\DBAL\\Schema\\Name\\UnqualifiedName\.$#'
 			identifier: class.notFound
-			count: 4
+			count: 5
 			path: src/Mapping/Driver/DatabaseDriver.php
 
 		-
@@ -1473,7 +1473,7 @@ parameters:
 		-
 			message: '#^Parameter \$name of anonymous function has invalid type Doctrine\\DBAL\\Schema\\Name\\UnqualifiedName\.$#'
 			identifier: class.notFound
-			count: 4
+			count: 5
 			path: src/Mapping/Driver/DatabaseDriver.php
 
 		-

src/Mapping/Driver/DatabaseDriver.php

@@ -319,11 +319,13 @@ private function reverseEngineerMappingFromDatabase(): void
      */
     private function buildIndexes(ClassMetadata $metadata): void
     {
-        $tableName = $metadata->table['name'];
-        $indexes   = $this->tables[$tableName]->getIndexes();
+        $tableName  = $metadata->table['name'];
+        $table      = $this->tables[$tableName];
+        $primaryKey = self::getPrimaryKey($table);
+        $indexes    = $table->getIndexes();
 
         foreach ($indexes as $index) {
-            if ($index->isPrimary()) {
+            if ($index === $primaryKey) {
                 continue;
             }
 
@@ -506,7 +508,7 @@ private function buildToOneAssociationMappings(ClassMetadata $metadata): void
     private function getTablePrimaryKeys(Table $table): array
     {
         try {
-            if (method_exists($table, 'getPrimaryKeyConstraints')) {
+            if (method_exists($table, 'getPrimaryKeyConstraint')) {
                 return array_map(static fn (UnqualifiedName $name) => $name->toString(), $table->getPrimaryKeyConstraint()->getColumnNames());
             }
 
@@ -594,4 +596,27 @@ private static function getIndexedColumns(Index $index): array
 
         return $index->getColumns();
     }
+
+    private static function getPrimaryKey(Table $table): Index|null
+    {
+        $primaryKeyConstraint = null;
+
+        if (method_exists(Table::class, 'getPrimaryKeyConstraint')) {
+            $primaryKeyConstraint = $table->getPrimaryKeyConstraint();
+        }
+
+        foreach ($table->getIndexes() as $index) {
+            if ($primaryKeyConstraint !== null) {
+                $primaryKeyConstraintColumns = array_map(static fn (UnqualifiedName $name) => $name->toString(), $primaryKeyConstraint->getColumnNames());
+
+                if ($primaryKeyConstraintColumns === self::getIndexedColumns($index)) {
+                    return $index;
+                }
+            } elseif ($index->isPrimary()) {
+                return $index;
+            }
+        }
+
+        return null;
+    }
 }