Skip to content

Commit 760397c

Browse files
authored
Remove ignore rules for issues fixed upstream (#9336)
The rules still should apply when using DBAL v2
1 parent efc982a commit 760397c

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

phpstan-baseline.neon

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1335,16 +1335,6 @@ parameters:
13351335
count: 1
13361336
path: lib/Doctrine/ORM/Query/AST/Functions/LowerFunction.php
13371337

1338-
-
1339-
message: "#^Parameter \\#2 \\$start of method Doctrine\\\\DBAL\\\\Platforms\\\\AbstractPlatform\\:\\:getSubstringExpression\\(\\) expects int, string given\\.$#"
1340-
count: 1
1341-
path: lib/Doctrine/ORM/Query/AST/Functions/SubstringFunction.php
1342-
1343-
-
1344-
message: "#^Parameter \\#3 \\$length of method Doctrine\\\\DBAL\\\\Platforms\\\\AbstractPlatform\\:\\:getSubstringExpression\\(\\) expects int\\|null, string\\|null given\\.$#"
1345-
count: 1
1346-
path: lib/Doctrine/ORM/Query/AST/Functions/SubstringFunction.php
1347-
13481338
-
13491339
message: "#^Parameter \\#1 \\$simpleArithmeticExpr of method Doctrine\\\\ORM\\\\Query\\\\SqlWalker\\:\\:walkSimpleArithmeticExpression\\(\\) expects Doctrine\\\\ORM\\\\Query\\\\AST\\\\SimpleArithmeticExpression, Doctrine\\\\ORM\\\\Query\\\\AST\\\\Node given\\.$#"
13501340
count: 1

phpstan-dbal2.neon

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,3 +25,15 @@ parameters:
2525
message: '/^Call to an undefined method Doctrine\\Common\\Cache\\Cache::deleteAll\(\)\.$/'
2626
count: 1
2727
path: lib/Doctrine/ORM/Tools/Console/Command/ClearCache/ResultCommand.php
28+
29+
30+
# Won't get fixed in DBAL 2
31+
-
32+
message: "#^Parameter \\#2 \\$start of method Doctrine\\\\DBAL\\\\Platforms\\\\AbstractPlatform\\:\\:getSubstringExpression\\(\\) expects int, string given\\.$#"
33+
count: 1
34+
path: lib/Doctrine/ORM/Query/AST/Functions/SubstringFunction.php
35+
36+
-
37+
message: "#^Parameter \\#3 \\$length of method Doctrine\\\\DBAL\\\\Platforms\\\\AbstractPlatform\\:\\:getSubstringExpression\\(\\) expects int\\|null, string\\|null given\\.$#"
38+
count: 1
39+
path: lib/Doctrine/ORM/Query/AST/Functions/SubstringFunction.php

0 commit comments

Comments
 (0)