Convert test into 2 unit tests

That test was testing too many thing and not really making it clear what
the expected output was, given some output. Instead, let us create 2
tests, each pertaining to the class under test.

Author: greg0ire

tests/Tests/ORM/Functional/Ticket/DDC2825Test.php

@@ -11,8 +11,6 @@
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Group;
 
-use function sprintf;
-
 /**
  * This class makes tests on the correct use of a database schema when entities are stored
  */
@@ -30,41 +28,7 @@ protected function setUp(): void
         }
     }
 
-    #[DataProvider('getTestedClasses')]
-    public function testClassSchemaMappingsValidity(
-        string $className,
-        string $expectedSchemaName,
-        string $expectedTableName,
-        bool $isQuoted,
-    ): void {
-        $classMetadata   = $this->_em->getClassMetadata($className);
-        $platform        = $this->_em->getConnection()->getDatabasePlatform();
-        $quotedTableName = $this->_em->getConfiguration()->getQuoteStrategy()->getTableName($classMetadata, $platform);
-
-        // Check if table name and schema properties are defined in the class metadata
-        self::assertEquals($expectedTableName, $classMetadata->table['name']);
-        self::assertEquals($expectedSchemaName, $classMetadata->table['schema']);
-
-        $fullTableName = sprintf(
-            $isQuoted ? '"%s"."%s"' : '%s.%s',
-            $expectedSchemaName,
-            $expectedTableName,
-        );
-
-        self::assertEquals($fullTableName, $quotedTableName);
-
-        // Checks sequence name validity
-        self::assertEquals(
-            sprintf(
-                '%s.%s_%s_seq',
-                $expectedSchemaName,
-                $expectedTableName,
-                $classMetadata->getSingleIdentifierColumnName(),
-            ),
-            $classMetadata->getSequenceName($platform),
-        );
-    }
-
+    /** @param class-string $className */
     #[DataProvider('getTestedClasses')]
     public function testPersistenceOfEntityWithSchemaMapping(string $className): void
     {
@@ -77,18 +41,14 @@ public function testPersistenceOfEntityWithSchemaMapping(string $className): voi
         self::assertCount(1, $this->_em->getRepository($className)->findAll());
     }
 
-    /**
-     * Data provider
-     *
-     * @return string[][]
-     */
+    /** @return list<array{class-string}> */
     public static function getTestedClasses(): array
     {
         return [
-            [ExplicitSchemaAndTable::class, 'explicit_schema', 'explicit_table', false],
-            [SchemaAndTableInTableName::class, 'implicit_schema', 'implicit_table', false],
-            [DDC2825ClassWithImplicitlyDefinedSchemaAndQuotedTableName::class, 'myschema', 'order', false],
-            [File::class, 'yourschema', 'file', true],
+            [ExplicitSchemaAndTable::class],
+            [SchemaAndTableInTableName::class],
+            [DDC2825ClassWithImplicitlyDefinedSchemaAndQuotedTableName::class],
+            [File::class],
         ];
     }
 }

tests/Tests/ORM/Mapping/ClassMetadataTest.php

@@ -5,6 +5,7 @@
 namespace Doctrine\Tests\ORM\Mapping;
 
 use ArrayObject;
+use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Types\Types;
 use Doctrine\Deprecations\PHPUnit\VerifyDeprecations;
 use Doctrine\ORM\Events;
@@ -51,6 +52,7 @@
 use Doctrine\Tests\OrmTestCase;
 use DoctrineGlobalArticle;
 use LogicException;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Group as TestGroup;
 use PHPUnit\Framework\Attributes\WithoutErrorHandler;
 use ReflectionClass;
@@ -970,6 +972,47 @@ public function testQuotedSequenceName(): void
         );
     }
 
+    #[DataProvider('fullTableNameProvider')]
+    public function testGetSequenceName(
+        string $expectedSequenceName,
+        string $fullTableName,
+    ): void {
+        $cm = new ClassMetadata(self::class);
+        $cm->setIdentifier(['id']);
+        $cm->setPrimaryTable(['name' => $fullTableName]);
+
+        $platform = $this->createStub(AbstractPlatform::class);
+
+        self::assertSame(
+            $expectedSequenceName,
+            $cm->getSequenceName($platform),
+        );
+    }
+
+    /** @return iterable<string, array{string, string}> */
+    public static function fullTableNameProvider(): iterable
+    {
+        yield 'quoted table name with schema' => [
+            'custom.reserved_id_seq',
+            'custom.`reserved`',
+        ];
+
+        yield 'unquoted table name with schema' => [
+            'custom.non_reserved_id_seq',
+            'custom.non_reserved',
+        ];
+
+        yield 'quoted table name without schema' => [
+            'reserved_id_seq',
+            '`reserved`',
+        ];
+
+        yield 'unquoted table name without schema' => [
+            'non_reserved_id_seq',
+            'non_reserved',
+        ];
+    }
+
     #[TestGroup('DDC-2700')]
     public function testIsIdentifierMappedSuperClass(): void
     {

tests/Tests/ORM/Mapping/DefaultQuoteStrategyTest.php

@@ -6,13 +6,16 @@
 
 use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Schema\Name\UnquotedIdentifierFolding;
+use Doctrine\ORM\Mapping\ClassMetadata;
 use Doctrine\ORM\Mapping\DefaultQuoteStrategy;
 use Doctrine\Tests\Models\NonPublicSchemaJoins\User as NonPublicSchemaUser;
 use Doctrine\Tests\OrmTestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Group;
 
 use function assert;
 use function enum_exists;
+use function sprintf;
 
 /**
  * Doctrine\Tests\ORM\Mapping\DefaultQuoteStrategyTest
@@ -34,4 +37,48 @@ public function testGetJoinTableName(): void
             $strategy->getJoinTableName($metadata->associationMappings['readers'], $metadata, $platform),
         );
     }
+
+    #[DataProvider('fullTableNameProvider')]
+    public function testGetTableName(string $expectedFullTableName, string $tableName): void
+    {
+        $classMetadata = new ClassMetadata(self::class);
+        $classMetadata->setPrimaryTable(['name' => $tableName]);
+
+        $platform = $this->createStub(AbstractPlatform::class);
+        $platform->method('quoteSingleIdentifier')
+            ->willReturnCallback(
+                static fn (string $identifier): string => sprintf('✌️%s✌️', $identifier),
+            );
+
+        $quotedTableName = (new DefaultQuoteStrategy())->getTableName(
+            $classMetadata,
+            $platform,
+        );
+
+        self::assertSame($expectedFullTableName, $quotedTableName);
+    }
+
+    /** @return iterable<string, array{string, string}> */
+    public static function fullTableNameProvider(): iterable
+    {
+        yield 'quoted table name with schema' => [
+            '✌️custom✌️.✌️reserved✌️',
+            'custom.`reserved`',
+        ];
+
+        yield 'unquoted table name with schema' => [
+            'custom.non_reserved',
+            'custom.non_reserved',
+        ];
+
+        yield 'quoted table name without schema' => [
+            '✌️reserved✌️',
+            '`reserved`',
+        ];
+
+        yield 'unquoted table name without schema' => [
+            'non_reserved',
+            'non_reserved',
+        ];
+    }
 }