Skip to content

Commit c5c66e5

Browse files
committed
Remove tests for unserializing old (^2.14) parser results
I think it is not important so support unserializing parser results from another major version release. The tests made sense when they were added in a bugfix release back in #10684, but not anymore for the 4.0.x branch.
1 parent 8f95375 commit c5c66e5

File tree

2 files changed

+0
-18
lines changed

2 files changed

+0
-18
lines changed

tests/Tests/ORM/Functional/ParserResultSerializationTest.php

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
use Symfony\Component\VarExporter\Instantiator;
1818
use Symfony\Component\VarExporter\VarExporter;
1919

20-
use function file_get_contents;
21-
use function rtrim;
2220
use function serialize;
2321
use function unserialize;
2422

@@ -68,22 +66,6 @@ static function (ParserResult $parserResult): ParserResult {
6866
];
6967
}
7068

71-
#[DataProvider('provideSerializedSingleSelectResults')]
72-
public function testUnserializeSingleSelectResult(string $serialized): void
73-
{
74-
$unserialized = unserialize($serialized);
75-
76-
$this->assertInstanceOf(ParserResult::class, $unserialized);
77-
$this->assertInstanceOf(ResultSetMapping::class, $unserialized->getResultSetMapping());
78-
$this->assertEquals(['name' => [0]], $unserialized->getParameterMappings());
79-
}
80-
81-
/** @return Generator<string, array{string}> */
82-
public static function provideSerializedSingleSelectResults(): Generator
83-
{
84-
yield '2.17.0' => [rtrim(file_get_contents(__DIR__ . '/ParserResults/single_select_2_17_0.txt'), "\n")];
85-
}
86-
8769
public function testSymfony44ProvidedData(): void
8870
{
8971
$sqlExecutor = new FinalizedSelectExecutor('test');
-2.31 KB
Binary file not shown.

0 commit comments

Comments
 (0)