Skip writing readonly properties if the value did not change

Author: derrabus

lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php

@@ -701,7 +701,7 @@ class ClassMetadataInfo implements ClassMetadata
     /**
      * The ReflectionProperty instances of the mapped class.
      *
-     * @var ReflectionProperty[]|null[]
+     * @var array<string, ReflectionProperty|null>
      */
     public $reflFields = [];
 

lib/Doctrine/ORM/UnitOfWork.php

@@ -40,6 +40,7 @@
 use Doctrine\Persistence\PropertyChangedListener;
 use Exception;
 use InvalidArgumentException;
+use LogicException;
 use RuntimeException;
 use Throwable;
 use UnexpectedValueException;
@@ -53,6 +54,7 @@
 use function array_pop;
 use function array_sum;
 use function array_values;
+use function assert;
 use function count;
 use function current;
 use function get_class;
@@ -66,6 +68,8 @@
 use function spl_object_id;
 use function sprintf;
 
+use const PHP_VERSION_ID;
+
 /**
  * The UnitOfWork is responsible for tracking changes to objects during an
  * "object-level" transaction and for writing out changes to the database
@@ -2724,9 +2728,25 @@ public function createEntity($className, array $data, &$hints = [])
         }
 
         foreach ($data as $field => $value) {
-            if (isset($class->fieldMappings[$field])) {
-                $class->reflFields[$field]->setValue($entity, $value);
+            if (! isset($class->fieldMappings[$field])) {
+                continue;
             }
+
+            assert($class->reflFields[$field] !== null);
+
+            if (
+                PHP_VERSION_ID >= 80100
+                && $class->reflFields[$field]->isReadOnly()
+                && $class->reflFields[$field]->isInitialized($entity)
+            ) {
+                if ($class->reflFields[$field]->getValue($entity) === $value) {
+                    continue;
+                }
+
+                throw new LogicException(sprintf('Attempting to change readonly field %s.', $field));
+            }
+
+            $class->reflFields[$field]->setValue($entity, $value);
         }
 
         // Loading the entity right here, if its in the eager loading map get rid of it there.

phpstan-baseline.neon

@@ -1904,3 +1904,4 @@ parameters:
 			message: "#^Access to an undefined property Doctrine\\\\Persistence\\\\Mapping\\\\ClassMetadata\\:\\:\\$subClasses\\.$#"
 			count: 1
 			path: lib/Doctrine/ORM/Utility/HierarchyDiscriminatorResolver.php
+

psalm-baseline.xml

@@ -3559,7 +3559,7 @@
       <code>$assoc['targetEntity']</code>
       <code>$assoc['type']</code>
     </PossiblyNullArrayAccess>
-    <PossiblyNullReference occurrences="33">
+    <PossiblyNullReference occurrences="32">
       <code>buildCachedCollectionPersister</code>
       <code>buildCachedEntityPersister</code>
       <code>getCacheFactory</code>
@@ -3592,7 +3592,6 @@
       <code>setValue</code>
       <code>setValue</code>
       <code>setValue</code>
-      <code>setValue</code>
     </PossiblyNullReference>
     <PossiblyUndefinedMethod occurrences="4">
       <code>addPropertyChangedListener</code>