Return 0 when there's no metadata to process (#9147)

wickedOne · web-flow · commit f2729b0610a3 · 2021-10-23T09:43:40.000Z
diff --git a/lib/Doctrine/ORM/Tools/Console/Command/ConvertMappingCommand.php b/lib/Doctrine/ORM/Tools/Console/Command/ConvertMappingCommand.php
@@ -151,7 +151,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         if (empty($metadata)) {
             $ui->success('No Metadata Classes to process.');
 
-            return;
+            return 0;
         }
 
         foreach ($metadata as $class) {
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -2021,11 +2021,6 @@ parameters:
 			count: 1
 			path: lib/Doctrine/ORM/Tools/Console/Command/ConvertMappingCommand.php
 
-		-
-			message: "#^Method Doctrine\\\\ORM\\\\Tools\\\\Console\\\\Command\\\\ConvertMappingCommand\\:\\:execute\\(\\) should return int but empty return statement found\\.$#"
-			count: 1
-			path: lib/Doctrine/ORM/Tools/Console/Command/ConvertMappingCommand.php
-
 		-
 			message: "#^Parameter \\#1 \\$metadata of method Doctrine\\\\ORM\\\\Tools\\\\Export\\\\Driver\\\\AbstractExporter\\:\\:setMetadata\\(\\) expects array\\<int, Doctrine\\\\ORM\\\\Mapping\\\\ClassMetadata\\>, array\\<Doctrine\\\\Persistence\\\\Mapping\\\\ClassMetadata\\> given\\.$#"
 			count: 1

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`151`	`151`	`if (empty($metadata)) {`
`152`	`152`	`$ui->success('No Metadata Classes to process.');`
`153`	`153`
`154`		`- return;`
	`154`	`+ return 0;`
`155`	`155`	`}`
`156`	`156`
`157`	`157`	`foreach ($metadata as $class) {`