QueryBuilder getRootAliases too wide return type?

[norkunas]

orm/lib/Doctrine/ORM/QueryBuilder.php

Lines 428 to 456 in 0ae2a2d

	/**
	* Gets the root aliases of the query. This is the entity aliases involved
	* in the construction of the query.
	*
	* <code>
	* $qb = $em->createQueryBuilder()
	* ->select('u')
	* ->from('User', 'u');
	*
	* $qb->getRootAliases(); // array('u')
	* </code>
	*
	* @return mixed[]
	* @psalm-return list<mixed>
	*/
	public function getRootAliases()
	{
	$aliases = [];
	foreach ($this->_dqlParts['from'] as &$fromClause) {
	if (is_string($fromClause)) {
	$spacePos = strrpos($fromClause, ' ');
	$from = substr($fromClause, 0, $spacePos);
	$alias = substr($fromClause, $spacePos + 1);
	$fromClause = new Query\Expr\From($from, $alias);
	}
	$aliases[] = $fromClause->getAlias();

I do not understand how getRootAliases could return anything other than string if From::getAlias always returns string?

[derrabus]

I do not understand how getRootAliases could return anything other than string

Neither do I. 🙂