Enable and fix no-unused-vars rule

Author: tmcw

.eslintrc

@@ -24,6 +24,7 @@
     "no-throw-literal": 2,
     "no-self-compare": 2,
     "no-void": 2,
+    "no-unused-vars": 2,
     "wrap-iife": 2,
     "no-eq-null": 2,
     "quotes": [2, "single"],

bin/documentation.js

@@ -3,20 +3,16 @@
 'use strict';
 
 var documentation = require('../'),
-
   streamArray = require('stream-array'),
   fs = require('fs'),
   vfs = require('vinyl-fs'),
   formatError = require('../lib/error'),
   args = require('../lib/args.js');
 
-var parsedArgs = args(process.argv.slice(2));
-var inputs = parsedArgs.inputs,
-  options = parsedArgs.options,
+var parsedArgs = args(process.argv.slice(2)),
   formatterOptions = parsedArgs.formatterOptions,
-  outputLocation = parsedArgs.output;
-
-var formatter = documentation.formats[parsedArgs.formatter];
+  outputLocation = parsedArgs.output,
+  formatter = documentation.formats[parsedArgs.formatter];
 
 documentation(parsedArgs.inputs, parsedArgs.options, function (err, result) {
   if (err) {

index.js

@@ -6,7 +6,7 @@ var sort = require('./lib/sort'),
   filterJS = require('./lib/filter_js'),
   dependency = require('./lib/input/dependency'),
   shallow = require('./lib/input/shallow'),
-  parse = require('./lib/parsers/javascript'),
+  parseJavaScript = require('./lib/parsers/javascript'),
   polyglot = require('./lib/parsers/polyglot'),
   github = require('./lib/github'),
   hierarchy = require('./lib/hierarchy'),
@@ -48,6 +48,7 @@ module.exports = function (indexes, options, callback) {
   }
 
   var inputFn = (options.polyglot || options.shallow) ? shallow : dependency;
+  var parseFn = (options.polyglot) ? polyglot : parseJavaScript;
 
   return inputFn(indexes, options, function (error, inputs) {
     if (error) {
@@ -57,7 +58,7 @@ module.exports = function (indexes, options, callback) {
       var flat = inputs
         .filter(filterJS)
         .reduce(function (memo, file) {
-          return memo.concat(parse(file));
+          return memo.concat(parseFn(file));
         }, [])
         .map(function (comment) {
           // compose nesting & membership to avoid intermediate arrays

lib/args.js

@@ -95,9 +95,6 @@ module.exports = function (args) {
     throw new Error('The HTML output mode requires a destination directory set with -o');
   }
 
-  var formatterOptions = {
-  };
-
   var config = {};
 
   if (argv.config) {

lib/github.js

@@ -1,7 +1,6 @@
 'use strict';
 
 var path = require('path');
-var fs = require('fs');
 var findGit = require('../lib/git/find_git');
 var getGithubURLPrefix = require('../lib/git/url_prefix');
 

lib/lint.js

@@ -18,7 +18,6 @@ var CANONICAL = {
  * @returns {Array<Object>} array of errors
  */
 module.exports = function (comment) {
-  var errors = [];
   comment.tags.forEach(function (tag) {
     function nameInvariant(name) {
       if (CANONICAL[name]) {

lib/parse.js

@@ -1,7 +1,6 @@
 'use strict';
 
 var doctrine = require('doctrine'),
-  error = require('./error'),
   flatten = require('./flatten'),
   normalize = require('./normalize');
 

test/bin.js

@@ -84,14 +84,14 @@ test('--shallow option', function (t) {
 });
 
 test('bad -f option', function (t) {
-  documentation(['-f DOES-NOT-EXIST fixture/internal.input.js'], function (err, data) {
+  documentation(['-f DOES-NOT-EXIST fixture/internal.input.js'], function (err) {
     t.ok(err, 'returns error');
     t.end();
   });
 });
 
 test('html with no destination', function (t) {
-  documentation(['-f html fixture/internal.input.js'], function (err, data) {
+  documentation(['-f html fixture/internal.input.js'], function (err) {
     t.ok(err.toString()
       .match(/The HTML output mode requires a destination directory set with -o/),
       'needs dest for html');
@@ -100,7 +100,7 @@ test('html with no destination', function (t) {
 });
 
 test('given no files', function (t) {
-  documentation([''], function (err, data) {
+  documentation([''], function (err) {
     t.ok(err.toString()
       .match(/documentation was given no files and was not run in a module directory/),
       'no files given');
@@ -137,7 +137,7 @@ test('write to html', function (t) {
 test('fatal error', function (t) {
 
   documentation(['--shallow fixture/bad/syntax.input.js'], {},
-    function (err, data) {
+    function (err) {
       t.ok(err.toString().match(/Unexpected token/), 'reports syntax error');
       t.end();
     }, false);

test/lib/error.js

@@ -5,10 +5,6 @@ var test = require('tap').test,
   error = require('../../lib/error');
 
 test('error', function (t) {
-  var tag = {
-    lineNumber: 2
-  };
-
   var comment = {
     context: {
       file: path.join(process.cwd(), 'file.js')

test/lib/git/find_git.js

@@ -1,7 +1,6 @@
 'use strict';
 
 var test = require('tap').test,
-  path = require('path'),
   mock = require('mock-fs'),
   mockRepo = require('./mock_repo'),
   findGit = require('../../../lib/git/find_git');