Skip to content

Docsplit images command - Added the ability to specify the page number delimiter via a command line option #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Docsplit images command - Added the ability to specify the page number delimiter via a command line option #110

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2894363
docsplit images cmd - added the ability to specify page number delimi…
BrandonNoad May 28, 2014
9c66ec3
Merge remote-tracking branch 'upstream/master'
BrandonNoad May 29, 2014
916408f
Added /usr/bin/libreoffice as another possible LibreOffice exe path
BrandonNoad Jun 9, 2014
b63ed55
Merge remote-tracking branch 'upstream/master'
BrandonNoad Oct 21, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/docsplit/command_line.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ def parse_options
opts.on('-r', '--rolling', 'generate images from each previous image') do |r|
@options[:rolling] = true
end
opts.on('--delimiter [DELIMITER]', 'set page number delimiter (eg: _, -, -Page-...)') do |d|
@options[:delimiter] = d.tr('^','')
Copy link
Author

@BrandonNoad BrandonNoad May 28, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to have your delimiter start with a dash, you need to escape it with the '^' character. So, we need to strip the '^' before passing it to @options.

end
opts.on_tail('-v', '--version', 'display docsplit version') do
puts "Docsplit version #{Docsplit::VERSION}"
exit
Expand Down
4 changes: 3 additions & 1 deletion lib/docsplit/image_extractor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ class ImageExtractor
MEMORY_ARGS = "-limit memory 256MiB -limit map 512MiB"
DEFAULT_FORMAT = :png
DEFAULT_DENSITY = '150'
DEFAULT_PAGE_DELIMITER = "_"

# Extract a list of PDFs as rasterized page images, according to the
# configuration in options.
Expand Down Expand Up @@ -41,7 +42,7 @@ def convert(pdf, size, format, previous=nil)
raise ExtractionFailed, result if $? != 0
else
page_list(pages).each do |page|
out_file = ESCAPE[File.join(directory, "#{basename}_#{page}.#{format}")]
out_file = ESCAPE[File.join(directory, "#{basename}#{@delimiter}#{page}.#{format}")]
cmd = "MAGICK_TMPDIR=#{tempdir} OMP_NUM_THREADS=2 gm convert +adjoin -define pdf:use-cropbox=true #{common} #{escaped_pdf}[#{page - 1}] #{out_file} 2>&1".chomp
result = `#{cmd}`.chomp
raise ExtractionFailed, result if $? != 0
Expand All @@ -63,6 +64,7 @@ def extract_options(options)
@sizes = [options[:size]].flatten.compact
@sizes = [nil] if @sizes.empty?
@rolling = !!options[:rolling]
@delimiter = options[:delimiter] || DEFAULT_PAGE_DELIMITER
end

# If there's only one size requested, generate the images directly into
Expand Down