fix: remove SSH key requirements for public repository submodules

- Convert submodule URL from SSH to HTTPS access
- Remove SSH key input from setup-submodules GitHub Action
- Simplify CI/CD workflow by removing SSH key parameters
- Add changeset for patch version bumps

Fixes Dependabot CI failures caused by missing SSH private key secrets.
Dependabot PRs can now run successfully without repository secrets access.

Author: cvarma2

.changeset/remove-ssh-keys-for-public-repos.md

@@ -0,0 +1,17 @@
+---
+"@1fe/server": patch
+"@1fe/shell": patch  
+"@1fe/cli": patch
+"@1fe/create-1fe-app": patch
+---
+
+Remove SSH key requirements for submodules since repositories are now public
+
+Fixed Dependabot CI failures by eliminating SSH key dependencies for accessing submodules:
+
+- Converted submodule URL from SSH (`git@github.com:`) to HTTPS (`https://github.com/`)
+- Removed SSH key input requirement from setup-submodules GitHub Action
+- Simplified CI/CD workflow by removing SSH key parameters
+- All submodule operations now work with public repository access
+
+This resolves the "ssh-private-key argument is empty" error that was causing Dependabot PRs to fail in CI builds. Dependabot PRs can now run successfully without requiring repository secrets access.

.github/workflows/ci-cd.yml

@@ -40,8 +40,6 @@ jobs:
       - uses: ./.github/workflows/steps/setup-node
 
       - uses: ./.github/workflows/steps/setup-submodules
-        with:
-          submodule-ssh-private-key: ${{ secrets.SUBMODULE_SSH_PRIVATE_KEY }}
 
       - name: Build the project
         run: yarn build
@@ -67,8 +65,6 @@ jobs:
       - uses: ./.github/workflows/steps/setup-node
 
       - uses: ./.github/workflows/steps/setup-submodules
-        with:
-          submodule-ssh-private-key: ${{ secrets.SUBMODULE_SSH_PRIVATE_KEY }}
           self-ssh-private-key: ${{ secrets.SELF_SSH_PRIVATE_KEY }}
 
       - name: Lint the project
@@ -86,8 +82,6 @@ jobs:
       - uses: ./.github/workflows/steps/setup-node
 
       - uses: ./.github/workflows/steps/setup-submodules
-        with:
-          submodule-ssh-private-key: ${{ secrets.SUBMODULE_SSH_PRIVATE_KEY }}
           self-ssh-private-key: ${{ secrets.SELF_SSH_PRIVATE_KEY }}
 
       - name: Run unit tests
@@ -107,8 +101,6 @@ jobs:
       - uses: ./.github/workflows/steps/setup-node
 
       - uses: ./.github/workflows/steps/setup-submodules
-        with:
-          submodule-ssh-private-key: ${{ secrets.SUBMODULE_SSH_PRIVATE_KEY }}
           self-ssh-private-key: ${{ secrets.SELF_SSH_PRIVATE_KEY }}
 
       - name: Restore build artifacts
@@ -169,8 +161,6 @@ jobs:
       - uses: ./.github/workflows/steps/setup-node
 
       - uses: ./.github/workflows/steps/setup-submodules
-        with:
-          submodule-ssh-private-key: ${{ secrets.SUBMODULE_SSH_PRIVATE_KEY }}
           self-ssh-private-key: ${{ secrets.SELF_SSH_PRIVATE_KEY }}
 
       - name: Restore build artifacts

.github/workflows/steps/setup-submodules/action.yml

@@ -1,25 +1,13 @@
 name: Setup Submodules
 description: Set up Git submodules for the project
 
-inputs:
-  submodule-ssh-private-key:
-    description: SSH private key for accessing submodules
-    required: true
-
 runs:
   using: 'composite'
   steps:
     - name: Mark workspace as safe
       shell: bash
       run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
 
-    # TODO #61 - this action goes away when our repos become public.
-    - name: Set up SSH for submodules and yarn
-      uses: webfactory/ssh-agent@v0.9.1
-      with:
-        ssh-private-key: |
-          ${{ inputs.submodule-ssh-private-key }}
-
     - name: Initialize submodules
       shell: bash
       run: git submodule update --init --recursive --remote # always make sure to work on latest submodule commits

.gitmodules

@@ -1,4 +1,4 @@
 [submodule "apps/starter-app"]
 	path = apps/starter-app
-	url = git@github.com:docusign/1fe-starter-app.git
+	url = https://github.com/docusign/1fe-starter-app.git
 	ignore = dirty