Skip to content

Commit 243e0e1

Browse files
author
Majid Mallis
committed
reverted scaleValue type to String till we have a better handling of reserved words such as 'Number'
1 parent 85f8a0f commit 243e0e1

File tree

4 files changed

+14
-12
lines changed

4 files changed

+14
-12
lines changed

src/main/java/com/docusign/esign/model/InitialHere.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import java.util.Objects;
44
import com.docusign.esign.model.ErrorDetails;
55
import com.docusign.esign.model.MergeField;
6-
import com.docusign.esign.model.Number;
76
import com.fasterxml.jackson.annotation.JsonProperty;
87
import com.fasterxml.jackson.annotation.JsonValue;
98
import io.swagger.annotations.ApiModel;
@@ -34,7 +33,7 @@ public class InitialHere {
3433
private String optional = null;
3534
private String pageNumber = null;
3635
private String recipientId = null;
37-
private Number scaleValue = null;
36+
private String scaleValue = null;
3837
private String status = null;
3938
private String tabId = null;
4039
private String tabLabel = null;
@@ -301,10 +300,10 @@ public void setRecipientId(String recipientId) {
301300

302301
@ApiModelProperty(value = "Sets the size for the InitialHere tab. It can be value from 0.5 to 1.0, where 1.0 represents full size and 0.5 is 50% size.")
303302
@JsonProperty("scaleValue")
304-
public Number getScaleValue() {
303+
public String getScaleValue() {
305304
return scaleValue;
306305
}
307-
public void setScaleValue(Number scaleValue) {
306+
public void setScaleValue(String scaleValue) {
308307
this.scaleValue = scaleValue;
309308
}
310309

src/main/java/com/docusign/esign/model/SignHere.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import java.util.Objects;
44
import com.docusign.esign.model.ErrorDetails;
55
import com.docusign.esign.model.MergeField;
6-
import com.docusign.esign.model.Number;
76
import com.fasterxml.jackson.annotation.JsonProperty;
87
import com.fasterxml.jackson.annotation.JsonValue;
98
import io.swagger.annotations.ApiModel;
@@ -34,7 +33,7 @@ public class SignHere {
3433
private String optional = null;
3534
private String pageNumber = null;
3635
private String recipientId = null;
37-
private Number scaleValue = null;
36+
private String scaleValue = null;
3837
private String status = null;
3938
private String tabId = null;
4039
private String tabLabel = null;
@@ -301,10 +300,10 @@ public void setRecipientId(String recipientId) {
301300

302301
@ApiModelProperty(value = "")
303302
@JsonProperty("scaleValue")
304-
public Number getScaleValue() {
303+
public String getScaleValue() {
305304
return scaleValue;
306305
}
307-
public void setScaleValue(Number scaleValue) {
306+
public void setScaleValue(String scaleValue) {
308307
this.scaleValue = scaleValue;
309308
}
310309

src/main/java/com/docusign/esign/model/SignerAttachment.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import java.util.Objects;
44
import com.docusign.esign.model.ErrorDetails;
55
import com.docusign.esign.model.MergeField;
6-
import com.docusign.esign.model.Number;
76
import com.fasterxml.jackson.annotation.JsonProperty;
87
import com.fasterxml.jackson.annotation.JsonValue;
98
import io.swagger.annotations.ApiModel;
@@ -34,7 +33,7 @@ public class SignerAttachment {
3433
private String optional = null;
3534
private String pageNumber = null;
3635
private String recipientId = null;
37-
private Number scaleValue = null;
36+
private String scaleValue = null;
3837
private String status = null;
3938
private String tabId = null;
4039
private String tabLabel = null;
@@ -301,10 +300,10 @@ public void setRecipientId(String recipientId) {
301300

302301
@ApiModelProperty(value = "")
303302
@JsonProperty("scaleValue")
304-
public Number getScaleValue() {
303+
public String getScaleValue() {
305304
return scaleValue;
306305
}
307-
public void setScaleValue(Number scaleValue) {
306+
public void setScaleValue(String scaleValue) {
308307
this.scaleValue = scaleValue;
309308
}
310309

src/test/java/SdkUnitTests.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ public void RequestASignatureTest()
162162
signHere.setRecipientId("1");
163163
signHere.setXPosition("100");
164164
signHere.setYPosition("100");
165+
signHere.setScaleValue("0.5");
165166

166167
List<SignHere> signHereTabs = new ArrayList<SignHere>();
167168
signHereTabs.add(signHere);
@@ -366,6 +367,7 @@ public void EmbeddedSigningTest()
366367
signHere.setRecipientId("1");
367368
signHere.setXPosition("100");
368369
signHere.setYPosition("100");
370+
signHere.setScaleValue("0.5");
369371

370372
List<SignHere> signHereTabs = new ArrayList<SignHere>();
371373
signHereTabs.add(signHere);
@@ -499,6 +501,7 @@ public void CreateTemplateTest()
499501
signHere.setRecipientId("1");
500502
signHere.setXPosition("100");
501503
signHere.setYPosition("100");
504+
signHere.setScaleValue("0.5");
502505

503506
List<SignHere> signHereTabs = new ArrayList<SignHere>();
504507
signHereTabs.add(signHere);
@@ -793,6 +796,7 @@ public void ResendEnvelopeTest() {
793796
signHere.setRecipientId("1");
794797
signHere.setXPosition("100");
795798
signHere.setYPosition("100");
799+
signHere.setScaleValue("0.5");
796800

797801
List<SignHere> signHereTabs = new ArrayList<SignHere>();
798802
signHereTabs.add(signHere);
@@ -917,6 +921,7 @@ public void GetDiagnosticLogsTest()
917921
signHere.setRecipientId("1");
918922
signHere.setXPosition("100");
919923
signHere.setYPosition("100");
924+
signHere.setScaleValue("0.5");
920925

921926
List<SignHere> signHereTabs = new ArrayList<SignHere>();
922927
signHereTabs.add(signHere);

0 commit comments

Comments
 (0)