Skip to content

Commit 720cabb

Browse files
committed
removed embedding
1 parent 93081bc commit 720cabb

File tree

4 files changed

+17
-46
lines changed

4 files changed

+17
-46
lines changed

client/src/components/TriggerForm/TriggerForm.jsx

Lines changed: 15 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { ROUTE, TemplateType } from '../../constants.js';
88
import { api } from '../../api';
99
import { openPopupWindow, closePopupWindow, updateWorkflowDefinitions } from '../../store/actions';
1010

11-
const TriggerForm = ({ workflowId, templateType, triggerType }) => {
11+
const TriggerForm = ({ workflowId, templateType }) => {
1212
const dispatch = useDispatch();
1313
const navigate = useNavigate();
1414
const isPopupOpened = useSelector(state => state.popup.isOpened);
@@ -106,24 +106,20 @@ const TriggerForm = ({ workflowId, templateType, triggerType }) => {
106106
const { data: triggeredWorkflow } = await api.workflows.triggerWorkflow(workflowId, templateType, body);
107107
setWorkflowInstanceUrl(triggeredWorkflow.workflowInstanceUrl);
108108

109-
if(triggerType === "Url") {
110-
navigate(`${ROUTE.TRIGGERFORM}/${workflowId}?type=${templateType}&triggerType=${triggerType}&triggerUrl=${triggeredWorkflow.workflowInstanceUrl}`)
111-
} else {
112-
// Update workflowDefinitions. "...workflow" creates new workflow-object to avoid mutation in redux
113-
const updatedWorkflowDefinitions = workflows.map(w => {
114-
if (w.id !== workflowId) return { ...w };
115-
116-
return {
117-
...w,
118-
instanceId: triggeredWorkflow.instanceId,
119-
isTriggered: true,
120-
};
121-
});
122-
123-
dispatch(updateWorkflowDefinitions(updatedWorkflowDefinitions));
124-
setDataSending(false);
125-
dispatch(openPopupWindow());
126-
}
109+
// Update workflowDefinitions. "...workflow" creates new workflow-object to avoid mutation in redux
110+
const updatedWorkflowDefinitions = workflows.map(w => {
111+
if (w.id !== workflowId) return { ...w };
112+
113+
return {
114+
...w,
115+
instanceId: triggeredWorkflow.instanceId,
116+
isTriggered: true,
117+
};
118+
});
119+
120+
dispatch(updateWorkflowDefinitions(updatedWorkflowDefinitions));
121+
setDataSending(false);
122+
dispatch(openPopupWindow());
127123
};
128124

129125
if (!relevantFormFields.length)

client/src/components/WorkflowList/WorkflowList.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ const WorkflowList = ({ items, interactionType, isLoading }) => {
4848
</div>
4949

5050
{interactionType === WorkflowItemsInteractionType.TRIGGER && (
51-
<button className={styles.cell3} onClick={() => navigate(`${ROUTE.TRIGGERFORM}/${item.id}?type=${item.type}&triggerType=${item.triggerType}`)}>
51+
<button className={styles.cell3} onClick={() => navigate(`${ROUTE.TRIGGERFORM}/${item.id}?type=${item.type}`)}>
5252
{textContent.buttons.triggerWorkflow}
5353
</button>
5454
)}

client/src/pages/TriggerWorkflow/TriggerWorkflow.jsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,15 +41,13 @@ const TriggerWorkflow = () => {
4141
id: definition.id,
4242
name: definition.name,
4343
type: "-",
44-
triggerType: definition.triggerType
4544
};
4645
}
4746

4847
return {
4948
id: definition.id,
5049
name: `${TemplateType[foundKey]?.name}`,
5150
type: TemplateType[foundKey]?.type,
52-
triggerType: definition.triggerType
5351
};
5452
})
5553
.filter(definition => !!definition);

client/src/pages/TriggerWorkflowForm/TriggerWorkflowForm.jsx

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -15,29 +15,6 @@ const TriggerWorkflowForm = () => {
1515
const location = useLocation();
1616
const searchParams = new URLSearchParams(location.search);
1717
const type = searchParams.get('type');
18-
const triggerType = searchParams.get('triggerType');
19-
const triggerUrl = searchParams.get('triggerUrl');
20-
21-
if(triggerUrl !== null){
22-
return (
23-
<div className="page-box">
24-
<Header />
25-
<div className={styles.contentContainer}>
26-
<WorkflowDescription
27-
title={textContent.pageTitles.completeWorkflow}
28-
behindTheScenesComponent={<TriggerBehindTheScenes />}
29-
backRoute={ROUTE.TRIGGER}
30-
/>
31-
32-
<div className={styles.formContainer}>
33-
<iframe src={triggerUrl} width="800" height="600">
34-
</iframe>
35-
</div>
36-
</div>
37-
<Footer withContent={false} />
38-
</div>
39-
);
40-
}
4118

4219
return (
4320
<div className="page-box">
@@ -48,7 +25,7 @@ const TriggerWorkflowForm = () => {
4825
behindTheScenesComponent={<TriggerBehindTheScenes />}
4926
backRoute={ROUTE.TRIGGER}
5027
/>
51-
<TriggerForm workflowId={workflowId} templateType={type} triggerType={triggerType} />
28+
<TriggerForm workflowId={workflowId} templateType={type} />
5229
</div>
5330
<Footer withContent={false} />
5431
</div>

0 commit comments

Comments
 (0)