feat: Added multiple maintainers and _lastauthor

dploeger · dploeger · commit 396145a34a3a · 2022-05-04T13:43:42.000+02:00
fixes #15
diff --git a/.travis.yml b/.travis.yml
diff --git a/README.md b/README.md
@@ -49,7 +49,8 @@ A table of checks that will be carried out.
 A table of maintainers for pages.
 
 - PagePattern: A regular expression that is matched against the full document path. Parent pages are separated through a "/".
-- Maintainer: The user that should receive all notifications for pages matching this pattern
+- Maintainer: The users that should receive all notifications for pages matching this pattern (separated by ,). You can 
+  use `_lastauthor` to reference the last author of the page) 
 
 ### Panel "Notification Template"
 
diff --git a/lib/api/Notification.ts b/lib/api/Notification.ts
@@ -36,18 +36,18 @@ export class Notification {
 
     for (const maintainer of this._configuration.maintainer) {
       if (documentInfo.matchesPath(maintainer.pagePattern)) {
-        documentInfo.author = maintainer.maintainer
+        documentInfo.author = maintainer.maintainer.replace(/_lastauthor/, documentInfo.author)
       }
     }
 
-    let to = documentInfo.author
+    let to = documentInfo.author.split(/,/)
     if (this._configuration.domain) {
-      to = `${to}@${this._configuration.domain}`
+      to = to.map((target) => `${target}@${this._configuration.domain}`)
     }
 
     const mailOptions = {
       from: this._configuration.notificationFrom,
-      to: to,
+      to: to.join(','),
       subject: subjectTemplate(documentInfo),
       html: bodyTemplate(documentInfo),
     }
diff --git a/test/MockServer.ts b/test/MockServer.ts
@@ -118,7 +118,7 @@ export class MockServer {
             </tr>
             <tr>
                 <td>main/Test/.*</td>
-                <td>maintainer</td>
+                <td>maintainer,_lastauthor</td>
             </tr>
             </tbody>
         </table>
diff --git a/test/NotificationTest.ts b/test/NotificationTest.ts
@@ -52,7 +52,7 @@ describe('The Notification API', (): void => {
     chai.expect(
       (transportStub as unknown as SinonStubbedInstance<Mail>).sendMail.calledWith({
         from: 'Notification <noreply@example.com>',
-        to: 'maintainer@example.com',
+        to: 'maintainer@example.com,author2@example.com',
         subject: Handlebars.compile(MockServer.NOTIFICATION_SUBJECT)(documentInfo),
         html: Handlebars.compile(MockServer.NOTIFICATION_BODY)(documentInfo),
       })

Original file line number	Diff line number	Diff line change
`@@ -36,18 +36,18 @@ export class Notification {`
`36`	`36`
`37`	`37`	`for (const maintainer of this._configuration.maintainer) {`
`38`	`38`	`if (documentInfo.matchesPath(maintainer.pagePattern)) {`
`39`		`- documentInfo.author = maintainer.maintainer`
	`39`	`+ documentInfo.author = maintainer.maintainer.replace(/_lastauthor/, documentInfo.author)`
`40`	`40`	`}`
`41`	`41`	`}`
`42`	`42`
`43`		`- let to = documentInfo.author`
	`43`	`+ let to = documentInfo.author.split(/,/)`
`44`	`44`	`if (this._configuration.domain) {`
`45`		- to = `${to}@${this._configuration.domain}`
	`45`	+ to = to.map((target) => `${target}@${this._configuration.domain}`)
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`const mailOptions = {`
`49`	`49`	`from: this._configuration.notificationFrom,`
`50`		`- to: to,`
	`50`	`+ to: to.join(','),`
`51`	`51`	`subject: subjectTemplate(documentInfo),`
`52`	`52`	`html: bodyTemplate(documentInfo),`
`53`	`53`	`}`
-Original file line number
+Diff line change
     chai.expect(
       (transportStub as unknown as SinonStubbedInstance<Mail>).sendMail.calledWith({
         from: 'Notification <[email protected]>',
 -        to: '[email protected]',
 +        to: '[email protected],[email protected]',
         subject: Handlebars.compile(MockServer.NOTIFICATION_SUBJECT)(documentInfo),
         html: Handlebars.compile(MockServer.NOTIFICATION_BODY)(documentInfo),
       })