fix: fix breaking notifications with excluded documents

Author: dploeger

lib/api/Notification.ts

@@ -33,18 +33,18 @@ export class Notification {
     const subjectTemplate = Handlebars.compile(this._configuration.notificationSubjectTemplate)
     const bodyTemplate = Handlebars.compile(this._configuration.notificationBodyTemplate)
 
-    for (const documentInfo of documentInfos) {
+    process: for (const documentInfo of documentInfos) {
       for (const exception of this._configuration.exceptions) {
         if (documentInfo.matchesPath(exception)) {
           this._log.info(`Skipping ${documentInfo.title} because it matches the exception ${exception}`)
-          return
+          continue process
         }
       }
 
       for (const excludedLabel of this._configuration.excludedLabels) {
         if (documentInfo.labels.some((label) => label.toLowerCase() == excludedLabel.toLowerCase())) {
           this._log.info(`Skipping ${documentInfo.title} because it has the excluded label ${excludedLabel}`)
-          return
+          continue process
         }
       }
 

test/NotificationTest.ts

@@ -164,7 +164,9 @@ describe('The Notification API', (): void => {
   it('should not send notifications for a document excluded by label', async (): Promise<void> => {
     const notification = new Notification(configuration, '', confluence, transportStub)
     const documentInfo = new DocumentInfo(0, 'author2', moment(), 'message', 'Title', ['main'], 'http://example.com', 'test', ['not'])
-    await notification.notify([documentInfo])
-    chai.expect((transportStub as unknown as SinonStubbedInstance<Mail>).sendMail.calledOnce).to.be.false
+    const documentInfoValid = new DocumentInfo(0, 'author2', moment(), 'message', 'Title', ['main'], 'http://example.com', 'test', [])
+    await notification.notify([documentInfo, documentInfoValid])
+    chai.expect((transportStub as unknown as SinonStubbedInstance<Mail>).sendMail.calledOnce).to.be.true
+    chai.expect((transportStub as unknown as SinonStubbedInstance<Mail>).sendMail.calledTwice).to.be.false
   })
 })