fix: Only send out one document if author == maintainer

Author: dploeger

lib/api/Notification.ts

@@ -59,7 +59,9 @@ export class Notification {
           this._notificationBatch[recipient] = []
         }
 
-        this._notificationBatch[recipient].push(documentInfo)
+        if (!this._notificationBatch[recipient].some((docInfo) => docInfo === documentInfo)) {
+          this._notificationBatch[recipient].push(documentInfo)
+        }
       }
     }
 

test/NotificationTest.ts

@@ -134,4 +134,28 @@ describe('The Notification API', (): void => {
       })
     ).to.be.true
   })
+  it('should not send both documents when the maintainer is the author', async (): Promise<void> => {
+    const notification = new Notification(configuration, '', confluence, transportStub)
+    const documentInfo = new DocumentInfo(0, 'maintainer', moment(), 'message', 'Test2', ['main', 'Test'], 'http://example.com', 'test')
+    await notification.notify([documentInfo])
+    chai.expect((transportStub as unknown as SinonStubbedInstance<Mail>).sendMail.calledOnce).to.be.true
+    chai.expect(
+      (transportStub as unknown as SinonStubbedInstance<Mail>).sendMail.calledWith({
+        from: 'Notification <[email protected]>',
+        to: '[email protected]',
+        subject: Handlebars.compile(MockServer.NOTIFICATION_SUBJECT)({
+          author: '[email protected]',
+          documentsCount: 1,
+          documents: [documentInfo],
+          multipleDocuments: false,
+        }),
+        html: Handlebars.compile(MockServer.NOTIFICATION_BODY)({
+          author: '[email protected]',
+          documentsCount: 1,
+          documents: [documentInfo],
+          multipleDocuments: false,
+        }),
+      })
+    ).to.be.true
+  })
 })