fix: Smaller doc fix about public ips

Added terraform-module tools to the readme and fixed open findings, which made the suffix feature actually work.

Author: dploeger

README.md

@@ -23,13 +23,17 @@ module "azure-mysql" {
 <!-- BEGIN_TF_DOCS -->
 ## Requirements
 
-No requirements.
+The following requirements are needed by this module:
+
+- terraform (>=1.0.0)
+
+- azurerm (>=3.63.0)
 
 ## Providers
 
 The following providers are used by this module:
 
-- azurerm
+- azurerm (>=3.63.0)
 
 ## Modules
 
@@ -113,8 +117,10 @@ Default: `"mysqladmin"`
 ### allowed\_ips
 
 Description:     A hash of permissions to access the database server by ip. The hash key is the name suffix and each value  
-    has a start and an end value. For public access set start\_ip\_address to 0.0.0.0 and end\_ip\_address to  
-    255.255.255.255. This variable is not used if public\_access = false.
+    has a start and an end value.
+
+    * For public access set start to 0.0.0.0 and end to 255.255.255.255
+    * To allow access from all Azure services to this database, set start and end to 0.0.0.0
 
 Type:
 
@@ -258,7 +264,6 @@ Description: FQDN of the database service
 
 ## Development
 
-Use [terraform-docs](https://terraform-docs.io/) to generate the API documentation by running
+Use [the terraform module tools](https://github.com/dodevops/terraform-module-tools) to check and generate the documentation by running
 
-    terraform fmt .
-    terraform-docs .
+    docker run -v "$PWD":/terraform ghcr.io/dodevops/terraform-module-tools:latest

databases.tf

@@ -2,7 +2,7 @@ resource "azurerm_mysql_flexible_database" "db" {
   for_each            = toset(var.database_suffixes)
   resource_group_name = var.resource_group
   server_name         = azurerm_mysql_flexible_server.server.name
-  name                = "${var.project}${var.stage}db${each.value}"
+  name                = "${var.project}${var.stage}db${var.suffix}${each.value}"
   charset             = var.charset
   collation           = var.collation
 }

server.tf

@@ -1,5 +1,5 @@
 resource "azurerm_mysql_flexible_server" "server" {
-  name                   = "${var.project}${var.stage}dbsrv"
+  name                   = "${var.project}${var.stage}dbsrv${var.suffix}"
   location               = var.location
   resource_group_name    = var.resource_group
   administrator_login    = var.admin_login

terraform.tf

@@ -0,0 +1,9 @@
+terraform {
+  required_version = ">=1.0.0"
+  required_providers {
+    azurerm = {
+      source  = "hashicorp/azurerm"
+      version = ">=3.63.0"
+    }
+  }
+}

vars.tf

@@ -93,8 +93,10 @@ variable "database_storage_iops" {
 variable "allowed_ips" {
   description = <<EOF
     A hash of permissions to access the database server by ip. The hash key is the name suffix and each value
-    has a start and an end value. For public access set start_ip_address to 0.0.0.0 and end_ip_address to
-    255.255.255.255. This variable is not used if public_access = false.
+    has a start and an end value.
+
+    * For public access set start to 0.0.0.0 and end to 255.255.255.255
+    * To allow access from all Azure services to this database, set start and end to 0.0.0.0
   EOF
   type = map(object({
     start = string,