Conversation
ninewise
approved these changes
Jan 30, 2026
ninewise
left a comment
ninewise
left a comment
There was a problem hiding this comment.
I'm unsure why you'd remove I18N though; I'd expect Dodona to need this more nowadays, and it wasn't adding much complexity.
Member
Author
|
@ninewise the Tested judge is now more or less the recommended judge, so this judge is reserved for more advanced use cases. You are right that the added complexity is not too much, but we're not using it anymore. So might as well remove it. It is still easy to add afterwards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I18n in the judge is a feature that is not really used anymore. This PR removes this feature and now always shows error messages in English.
Edit: changed the base branch to develop, to do all "breaking" changes all at once.