Fix warnings

dodyg · dodyg · commit 83109c1fb64c · 2024-03-06T10:25:50.000+08:00
diff --git a/projects/features/features-http-body-response/Program.cs b/projects/features/features-http-body-response/Program.cs
@@ -4,7 +4,7 @@
 var app = WebApplication.Create();
 app.Run(async context =>
 {
-    context.Response.Headers.Add("Content-Type", "text/html; charset=utf-8");
+    context.Response.Headers.Append("Content-Type", "text/html; charset=utf-8");
     var feature = context.Features.Get<IHttpResponseBodyFeature>();
     await feature.StartAsync();
     await feature.Stream.WriteAsync(Encoding.UTF8.GetBytes("<html><body style=\"font-size:240px;text-align:center;\">Hello 🌍</body></html>"));
diff --git a/projects/features/features-max-request-body-size/Program.cs b/projects/features/features-max-request-body-size/Program.cs
@@ -15,7 +15,7 @@
     var str = "<html><body>";
     str += $"Max Request Body Size {bodySize.MaxRequestBodySize}(Is Read Only: {bodySize.IsReadOnly}) You can <strong>also</strong> set this value at KestrelServerOptions.Limits.MaxRequestBodySize";
     str += "</body></html>";
-    context.Response.Headers.Add("Content-Type", "text/html");
+    context.Response.Headers.Append("Content-Type", "text/html");
     return context.Response.WriteAsync($"{str}");
 });
 
diff --git a/projects/file-provider/file-provider-custom/Program.cs b/projects/file-provider/file-provider-custom/Program.cs
@@ -9,7 +9,7 @@
 
 app.Run(async context =>
 {
-    context.Response.Headers.Add("content-type", "text/html");
+    context.Response.Headers.Append("content-type", "text/html");
 
     using (var stream = app.Environment.ContentRootFileProvider.GetFileInfo("").CreateReadStream())
     {
diff --git a/projects/file-provider/file-provider-physical/Program.cs b/projects/file-provider/file-provider-physical/Program.cs
@@ -4,7 +4,7 @@
 
 app.Run(async context =>
 {
-    context.Response.Headers.Add("Content-Type", "text/html");
+    context.Response.Headers.Append("Content-Type", "text/html");
 
     var contentRoot = app.Environment.ContentRootFileProvider;
     var contentPhysical = app.Environment.ContentRootFileProvider as PhysicalFileProvider;
diff --git a/projects/file-provider/serve-static-files-7/Program.cs b/projects/file-provider/serve-static-files-7/Program.cs
@@ -12,7 +12,7 @@
 
 app.Run(async context =>
 {
-    context.Response.Headers.Add("content-type", "text/html");
+    context.Response.Headers.Append("content-type", "text/html");
 
     await context.Response.WriteAsync(@"
                 <html>
diff --git a/projects/file-provider/serve-static-files-8/Program.cs b/projects/file-provider/serve-static-files-8/Program.cs
@@ -23,7 +23,7 @@
 
 app.Run(async context =>
 {
-    context.Response.Headers.Add("content-type", "text/html");
+    context.Response.Headers.Append("content-type", "text/html");
 
     await context.Response.WriteAsync(@"
                 <html>
diff --git a/projects/health-check/health-check-5/Program.cs b/projects/health-check/health-check-5/Program.cs
@@ -22,7 +22,7 @@
 {
     ResponseWriter = async (context, health) =>
     {
-        context.Response.Headers.Add("Content-Type", "text/plain");
+        context.Response.Headers.Append("Content-Type", "text/plain");
 
         if (health.Status == HealthStatus.Healthy)
             await context.Response.WriteAsync("Everything is good");
diff --git a/projects/health-check/health-check-6/Program.cs b/projects/health-check/health-check-6/Program.cs
@@ -22,7 +22,7 @@
 {
     ResponseWriter = async (context, health) =>
     {
-        context.Response.Headers.Add("Content-Type", "text/plain");
+        context.Response.Headers.Append("Content-Type", "text/plain");
 
         if (health.Status == HealthStatus.Healthy)
             await context.Response.WriteAsync("Everything is good");
diff --git a/projects/httpclientfactory/httpclientfactory-1/Program.cs b/projects/httpclientfactory/httpclientfactory-1/Program.cs
@@ -9,7 +9,7 @@
     var client = httpClient.CreateClient();
     var result = await client.GetStringAsync("http://scripting.com/rss.xml");
 
-    context.Response.Headers.Add("Content-Type", "application/rss+xml");
+    context.Response.Headers.Append("Content-Type", "application/rss+xml");
     await context.Response.WriteAsync(result);
 });
 
diff --git a/projects/httpclientfactory/httpclientfactory-2/Program.cs b/projects/httpclientfactory/httpclientfactory-2/Program.cs
@@ -14,7 +14,7 @@
         var client = httpClient.CreateClient("rss"); // use the preconfigured http client
         var result = await client.GetStringAsync("http://scripting.com/rss.xml");
 
-        context.Response.Headers.Add("Content-Type", "application/rss+xml");
+        context.Response.Headers.Append("Content-Type", "application/rss+xml");
         await context.Response.WriteAsync(result);
     });
 
diff --git a/projects/httpclientfactory/httpclientfactory-3/Program.cs b/projects/httpclientfactory/httpclientfactory-3/Program.cs
@@ -9,7 +9,7 @@
         var rss = context.RequestServices.GetService<RssReader>();
         var result = await rss.Get("http://scripting.com/rss.xml");
 
-        context.Response.Headers.Add("Content-Type", "application/rss+xml");
+        context.Response.Headers.Append("Content-Type", "application/rss+xml");
         await context.Response.WriteAsync(result);
     });
 
diff --git a/projects/httpclientfactory/httpclientfactory-4/Program.cs b/projects/httpclientfactory/httpclientfactory-4/Program.cs
@@ -9,7 +9,7 @@
     var rss = context.RequestServices.GetService<IRss>();
     var result = await rss.Get("http://scripting.com/rss.xml");
 
-    context.Response.Headers.Add("Content-Type", "application/rss+xml");
+    context.Response.Headers.Append("Content-Type", "application/rss+xml");
     await context.Response.WriteAsync(result);
 });
 
diff --git a/projects/image-sharp/Program.cs b/projects/image-sharp/Program.cs
@@ -15,7 +15,7 @@
 
 app.Run(async context =>
 {
-    context.Response.Headers.Add("Content-Type", "text/html");
+    context.Response.Headers.Append("Content-Type", "text/html");
     await context.Response.WriteAsync($@"
     <html>
     <body>
diff --git a/projects/json/json-6/Program.cs b/projects/json/json-6/Program.cs
@@ -29,7 +29,7 @@
         Indented = true
     };
 
-    context.Response.Headers.Add(HeaderNames.ContentType, "application/json");
+    context.Response.Headers.Append(HeaderNames.ContentType, "application/json");
 
     await using (var writer = new Utf8JsonWriter(context.Response.Body, options))
     {
diff --git a/projects/localization/localization-6/Program.cs b/projects/localization/localization-6/Program.cs
@@ -57,7 +57,7 @@
 
     var requestCulture = context.Features.Get<IRequestCultureFeature>().RequestCulture;
 
-    context.Response.Headers.Add("Content-Type", "text/html");
+    context.Response.Headers.Append("Content-Type", "text/html");
     await context.Response.WriteAsync("<html><body>");
     await context.Response.WriteAsync($"Request Culture `{requestCulture.UICulture}` = {local["Hello"]}<br/><br/>");
     await context.Response.WriteAsync($@"<a href=""/greet-friend"">Greet Friend</a><br/>");
diff --git a/projects/middleware/middleware-10/Program.cs b/projects/middleware/middleware-10/Program.cs
@@ -13,7 +13,7 @@ public TerminalMiddleware(RequestDelegate next)
     public async Task Invoke(HttpContext context, ILogger<TerminalMiddleware> log)
     {
         log.LogDebug($"Request: {context.Request.Path}");
-        context.Response.Headers.Add("Content-Type", "text/plain");
+        context.Response.Headers.Append("Content-Type", "text/plain");
         await context.Response.WriteAsync($"Middleware is singleton. Keep refreshing the page. You will see that the date does not change {_date}.");
     }
 }
diff --git a/projects/middleware/middleware-11/Program.cs b/projects/middleware/middleware-11/Program.cs
@@ -19,7 +19,7 @@ public TerminalMiddleware(ILogger<TerminalMiddleware> log)
     public async Task InvokeAsync(HttpContext context, RequestDelegate next)
     {
         _log.LogDebug($"Request: {context.Request.Path}");
-        context.Response.Headers.Add("Content-Type", "text/plain");
+        context.Response.Headers.Append("Content-Type", "text/plain");
         await context.Response.WriteAsync($"This Middleware is transient. Keep refreshing your page. The date will keep changing: {_date}.");
     }
 }
diff --git a/projects/middleware/middleware-12/Program.cs b/projects/middleware/middleware-12/Program.cs
@@ -23,7 +23,7 @@ public async Task Invoke(HttpContext context)
         await _next.Invoke(context);
         context.Items["Content"] += "</body></html>";
 
-        context.Response.Headers.Add("content-type", "text/html");
+        context.Response.Headers.Append("content-type", "text/html");
         await context.Response.WriteAsync(context.Items["Content"] as string);
     }
 }
diff --git a/projects/middleware/middleware-2/Program.cs b/projects/middleware/middleware-2/Program.cs
@@ -5,7 +5,7 @@
 app.Use(BufferAsync);
 app.Run(async context =>
 {
-    context.Response.Headers.Add("Content-Type", "text/html");
+    context.Response.Headers.Append("Content-Type", "text/html");
     await context.Response.WriteAsync("<h1>This sample uses buffering</h1>");
     await context.Response.WriteAsync("<p>This allows all your Middlewares to write to Response.</p>");
 });
diff --git a/projects/middleware/middleware-4/Program.cs b/projects/middleware/middleware-4/Program.cs
@@ -5,7 +5,7 @@
 
 app.Run(context =>
 {
-    context.Response.Headers.Add("Content-Type", "text/html");
+    context.Response.Headers.Append("Content-Type", "text/html");
     return context.Response.WriteAsync(@"
                    <a href=""/hello"">hello</a> <a href=""/world"">world</a>
                 ");
diff --git a/projects/middleware/middleware-5/Program.cs b/projects/middleware/middleware-5/Program.cs
@@ -12,7 +12,7 @@
 
 app.Run(context =>
 {
-    context.Response.Headers.Add("Content-Type", "text/html");
+    context.Response.Headers.Append("Content-Type", "text/html");
     return context.Response.WriteAsync(@"<a href=""/hello"">/hello</a> <a href=""/hello/world"">/hello/world</a>");
 });
 
diff --git a/projects/middleware/middleware-6/Program.cs b/projects/middleware/middleware-6/Program.cs
@@ -13,7 +13,7 @@
 
 app.Run(context =>
 {
-    context.Response.Headers.Add("content-type", "text/html");
+    context.Response.Headers.Append("content-type", "text/html");
     return context.Response.WriteAsync(@"<a href=""/hello"">/hello</a> <a href=""/hello/world"">/hello/world</a>");
 });
 
diff --git a/projects/middleware/middleware-7/Program.cs b/projects/middleware/middleware-7/Program.cs
@@ -24,7 +24,7 @@
 
 app.Run(context =>
 {
-    context.Response.Headers.Add("content-type", "text/html");
+    context.Response.Headers.Append("content-type", "text/html");
     return context.Response.WriteAsync(@"<a href=""/hello"">/hello</a> <a href=""/greetings"">/greetings</a>");
 });
 
diff --git a/projects/minimal-hosting/web-application-use-web-sockets/Program.cs b/projects/minimal-hosting/web-application-use-web-sockets/Program.cs
@@ -40,7 +40,7 @@
 
 app.Run(async context =>
     {
-        context.Response.Headers.Add("content-type", "text/html");
+        context.Response.Headers.Append("content-type", "text/html");
         await context.Response.WriteAsync(@"
 <html>                
     <head>
diff --git a/projects/mvc/razor-class-library/razor-class-library-1/src/WebApplication/Program.cs b/projects/mvc/razor-class-library/razor-class-library-1/src/WebApplication/Program.cs
@@ -6,7 +6,7 @@
 
 app.Run(async (context) =>
 {
-    context.Response.Headers.Add("Content-Type", "text/html");
+    context.Response.Headers.Append("Content-Type", "text/html");
 
     await context.Response.WriteAsync(@"<html>
         <body>
diff --git a/projects/mvc/razor-class-library/razor-class-library-with-controllers/src/WebApplication/Program.cs b/projects/mvc/razor-class-library/razor-class-library-with-controllers/src/WebApplication/Program.cs
@@ -7,7 +7,7 @@
 
 app.Run(async (context) =>
 {
-    context.Response.Headers.Add("Content-Type", "text/html");
+    context.Response.Headers.Append("Content-Type", "text/html");
 
     await context.Response.WriteAsync(@"<html>
         <body>
diff --git a/projects/mvc/razor-class-library/razor-class-library-with-static-files/src/WebApplication/Program.cs b/projects/mvc/razor-class-library/razor-class-library-with-static-files/src/WebApplication/Program.cs
@@ -10,7 +10,7 @@
 
 app.Run(async (context) =>
 {
-    context.Response.Headers.Add("Content-Type", "text/html");
+    context.Response.Headers.Append("Content-Type", "text/html");
 
     await context.Response.WriteAsync(@"<html>
         <body>
diff --git a/projects/request/README.md b/projects/request/README.md
@@ -74,4 +74,4 @@
 
       Demonstrates on how to access cookie values issued by remote API via AJAX call.
 
-dotnet6
+dotnet8
diff --git a/projects/request/anti-forgery/Program.cs b/projects/request/anti-forgery/Program.cs
@@ -25,7 +25,7 @@
 
     var token = antiForgery.GetAndStoreTokens(context);
 
-    context.Response.Headers.Add("Content-Type", "text/html");
+    context.Response.Headers.Append("Content-Type", "text/html");
     await context.Response.WriteAsync($@"
     <html>
     <body>
diff --git a/projects/request/build.bat b/projects/request/build.bat
@@ -0,0 +1,15 @@
+dotnet build anti-forgery
+dotnet build cookies-1
+dotnet build cookies-2
+dotnet build cookies-3
+dotnet build form-upload-file
+dotnet build form-url-encoded-content
+dotnet build form-values
+dotnet build query-string-1
+dotnet build query-string-2
+dotnet build query-string-3
+dotnet build query-string-create
+dotnet build request-headers
+dotnet build request-headers-names
+dotnet build request-headers-typed
+dotnet build request-verb
diff --git a/projects/request/cookies-2/Program.cs b/projects/request/cookies-2/Program.cs
@@ -2,7 +2,7 @@
 
 app.Run(async context =>
 {
-    context.Response.Headers.Add("content-type","text/html");
+    context.Response.Headers.Append("content-type","text/html");
     var deleteCookie = context.Request.Query["delete"];
 
     if(!string.IsNullOrWhiteSpace(deleteCookie))
diff --git a/projects/request/form-upload-file/Program.cs b/projects/request/form-upload-file/Program.cs
@@ -2,7 +2,7 @@
 
 app.MapGet("", async context =>
 {
-    context.Response.Headers.Add("content-type", "text/html");
+    context.Response.Headers.Append("content-type", "text/html");
 
     var body = $@"
                 <html><body>
diff --git a/projects/request/form-url-encoded-content/Program.cs b/projects/request/form-url-encoded-content/Program.cs
@@ -15,7 +15,7 @@
 
     using var queryString = new FormUrlEncodedContent(dicts);
     
-    context.Response.Headers.Add("Content-Type", "text/html");
+    context.Response.Headers.Append("Content-Type", "text/html");
     await context.Response.WriteAsync($@"<html>
     <head>
         <link rel=""stylesheet"" href=""https://cdnjs.cloudflare.com/ajax/libs/bulma/0.7.5/css/bulma.css"" />
diff --git a/projects/request/form-values/Program.cs b/projects/request/form-values/Program.cs
@@ -2,7 +2,7 @@
 
 app.MapGet("", async context =>
 {
-    context.Response.Headers.Add("content-type", "text/html");
+    context.Response.Headers.Append("content-type", "text/html");
 
     var body = $@"
 <html><body>
@@ -33,7 +33,7 @@
 
 app.MapPost("Upload", async context =>
 {
-    context.Response.Headers.Add("content-type", "text/html");
+    context.Response.Headers.Append("content-type", "text/html");
 
     if (context.Request.HasFormContentType)
     {
diff --git a/projects/request/query-string-1/Program.cs b/projects/request/query-string-1/Program.cs
@@ -3,7 +3,7 @@
 //These are the three default services available at Configure
 app.Run(async context =>
 {
-    context.Response.Headers.Add("content-type", "text/html");
+    context.Response.Headers.Append("content-type", "text/html");
 
     StringValues queryString = context.Request.Query["message"];
 
diff --git a/projects/request/query-string-2/Program.cs b/projects/request/query-string-2/Program.cs
@@ -5,7 +5,7 @@
 //These are the three default services available at Configure
 app.Run(async context =>
 {
-    context.Response.Headers.Add("Content-Type", "text/html");
+    context.Response.Headers.Append("Content-Type", "text/html");
 
     StringValues queryString = context.Request.Query["message"];
 
diff --git a/projects/request/query-string-3/Program.cs b/projects/request/query-string-3/Program.cs
@@ -2,7 +2,7 @@
 
 app.Run(async context =>
 {
-    context.Response.Headers.Add("content-type", "text/html");
+    context.Response.Headers.Append("content-type", "text/html");
 
     await context.Response.WriteAsync("<html><body>");
     await context.Response.WriteAsync("<h1>All query string</h1>");
diff --git a/projects/request/query-string-create/Program.cs b/projects/request/query-string-create/Program.cs
@@ -15,7 +15,7 @@
 
     var queryString = QueryString.Create(dicts);
     
-    context.Response.Headers.Add("Content-Type", "text/html");
+    context.Response.Headers.Append("Content-Type", "text/html");
     await context.Response.WriteAsync($@"<html>
     <head>
         <link rel=""stylesheet"" href=""https://cdnjs.cloudflare.com/ajax/libs/bulma/0.7.5/css/bulma.css"" />
diff --git a/projects/request/request-headers-names/Program.cs b/projects/request/request-headers-names/Program.cs
@@ -12,7 +12,7 @@ List<FieldInfo> GetConstants(Type type)
 
 app.Run(async context =>
 {
-    context.Response.Headers.Add(HeaderNames.ContentType, "text/html");
+    context.Response.Headers.Append(HeaderNames.ContentType, "text/html");
 
     await context.Response.WriteAsync("<html><body>");
     await context.Response.WriteAsync("<h1>Request Headers from Microsoft.Net.Http.Headers.HeaderNames</h1>");
diff --git a/projects/request/request-headers/Program.cs b/projects/request/request-headers/Program.cs
@@ -2,7 +2,7 @@
 
 app.Run(async context =>
 {
-    context.Response.Headers.Add("content-type", "text/html");
+    context.Response.Headers.Append("content-type", "text/html");
     await context.Response.WriteAsync("<h1>Request Headers</h1>");
     await context.Response.WriteAsync("<ul>");
     foreach (var h in context.Request.Headers)
diff --git a/projects/response/README.md b/projects/response/README.md
@@ -23,4 +23,4 @@
 
   This example shows how to issue trailing HTTP headers. Normal HTTP headers must be issued before body of the HTTP Response starts being written. Trailing headers allows you to issue headers after the HTTP body has been written. 
 
-  dotnet6
+  dotnet8
diff --git a/projects/response/response-header/Program.cs b/projects/response/response-header/Program.cs
@@ -1,11 +1,11 @@
 var app = WebApplication.Create();
 app.Run(async context =>
 {
-    context.Response.Headers.Add("content-type", "text/html");
+    context.Response.Headers.Append("content-type", "text/html");
     await context.Response.WriteAsync("<b>Hello world</b>");
     try
     {
-        context.Response.Headers.Add("my-header", "awesome");
+        context.Response.Headers.Append("my-header", "awesome");
     }
     catch (Exception ex)
     {
diff --git a/projects/response/trailing-headers/Program.cs b/projects/response/trailing-headers/Program.cs
diff --git a/projects/uri-helper/uri-helper-build-absolute/Program.cs b/projects/uri-helper/uri-helper-build-absolute/Program.cs
diff --git a/projects/uri-helper/uri-helper-from-absolute/Program.cs b/projects/uri-helper/uri-helper-from-absolute/Program.cs
diff --git a/projects/uri-helper/uri-helper-get-display-url/Program.cs b/projects/uri-helper/uri-helper-get-display-url/Program.cs

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`var app = WebApplication.Create();`
`5`	`5`	`app.Run(async context =>`
`6`	`6`	`{`
`7`		`- context.Response.Headers.Add("Content-Type", "text/html; charset=utf-8");`
	`7`	`+ context.Response.Headers.Append("Content-Type", "text/html; charset=utf-8");`
`8`	`8`	`var feature = context.Features.Get<IHttpResponseBodyFeature>();`
`9`	`9`	`await feature.StartAsync();`
`10`	`10`	`await feature.Stream.WriteAsync(Encoding.UTF8.GetBytes("<html><body style=\"font-size:240px;text-align:center;\">Hello 🌍</body></html>"));`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`
`10`	`10`	`app.Run(async context =>`
`11`	`11`	`{`
`12`		`- context.Response.Headers.Add("content-type", "text/html");`
	`12`	`+ context.Response.Headers.Append("content-type", "text/html");`
`13`	`13`
`14`	`14`	`using (var stream = app.Environment.ContentRootFileProvider.GetFileInfo("").CreateReadStream())`
`15`	`15`	`{`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`
`13`	`13`	`app.Run(async context =>`
`14`	`14`	`{`
`15`		`- context.Response.Headers.Add("content-type", "text/html");`
	`15`	`+ context.Response.Headers.Append("content-type", "text/html");`
`16`	`16`
`17`	`17`	`await context.Response.WriteAsync(@"`
`18`	`18`	`<html>`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`
`24`	`24`	`app.Run(async context =>`
`25`	`25`	`{`
`26`		`- context.Response.Headers.Add("content-type", "text/html");`
	`26`	`+ context.Response.Headers.Append("content-type", "text/html");`
`27`	`27`
`28`	`28`	`await context.Response.WriteAsync(@"`
`29`	`29`	`<html>`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`{`
`23`	`23`	`ResponseWriter = async (context, health) =>`
`24`	`24`	`{`
`25`		`- context.Response.Headers.Add("Content-Type", "text/plain");`
	`25`	`+ context.Response.Headers.Append("Content-Type", "text/plain");`
`26`	`26`
`27`	`27`	`if (health.Status == HealthStatus.Healthy)`
`28`	`28`	`await context.Response.WriteAsync("Everything is good");`