Add Validation on Contributor; (DOECODE-799)

Author: sowerstl

src/main/java/gov/osti/services/Metadata.java

@@ -2363,8 +2363,11 @@ else if (m.getLicenses().contains(DOECodeMetadata.License.Other.value()) && Stri
                     if (!Validation.isValidORCID(contributor.getOrcid()))
                         reasons.add("Contributor ORCID \"" + contributor.getOrcid() +"\" is not valid.");
                 }
+                if (StringUtils.isBlank(contributor.getFirstName()) || StringUtils.isBlank(contributor.getLastName()) || (null == contributor.getContributorType())) {
+                    reasons.add("Contributor must include first name, last name, and contributor type.");
             }
         }
+        }
         // if "OS" accessibility, a REPOSITORY LINK is REQUIRED
         if (DOECodeMetadata.Accessibility.OS.equals(m.getAccessibility())) {
             if (StringUtils.isBlank(m.getRepositoryLink()))
@@ -2377,6 +2380,7 @@ else if (m.getLicenses().contains(DOECodeMetadata.License.Other.value()) && Stri
         // if repository link is present, and not CO, it needs to be valid too
         if (StringUtils.isNotBlank(m.getRepositoryLink()) && !DOECodeMetadata.Accessibility.CO.equals(m.getAccessibility()) && !Validation.isValidRepositoryLink(m.getRepositoryLink()))
             reasons.add("Repository URL is not a valid repository.");
+
         return reasons;
     }
 

src/main/java/gov/osti/services/Metadata.md

@@ -527,6 +527,7 @@ metadata fields.
  {"email":"[email protected]",
   "affiliations":["Testing Services, Inc."],
   "first_name":"Tester",
+  "last_name":"Smith",
   "contributor_type":"DataCurator"}],
 "sponsoring_organizations":[
   {"organization_name":"OSTI",