feat: Implement the possibility to set the number of reconnect attempts (by default int.MaxValue). Additionally as default connect interval, it was implemented the exponential backoff.

Author: jlareo

src/SocketIOClient.Sample/MyConnectInterval.cs

@@ -1,7 +1,5 @@
 using SocketIOClient.ConnectInterval;
 using System;
-using System.Collections.Generic;
-using System.Text;
 
 namespace SocketIOClient.Sample
 {
@@ -14,15 +12,15 @@ public MyConnectInterval()
 
         double delay;
 
-        public int GetDelay()
+        public double GetDelay()
         {
             Console.WriteLine("GetDelay: " + delay);
-            return (int)delay;
+            return delay;
         }
 
-        public double NextDealy()
+        public double NextDelay()
         {
-            Console.WriteLine("NextDealy: " + (delay + 1000));
+            Console.WriteLine("NextDelay: " + (delay + 1000));
             return delay += 1000;
         }
     }

src/SocketIOClient.Test/SocketIOTests/ReconnectionTest.cs

@@ -130,6 +130,36 @@ public virtual async Task ReconnectingTest()
             Assert.AreEqual(1, attempt);
         }
 
+        public virtual async Task ReconnectionAttemptsExceededTest() 
+        {
+            var client = SocketIOCreator.Create();
+            client.ServerUri = new System.Uri("http://localhost:11011");
+            client.Options.AllowedRetryFirstConnection = true;
+            client.Options.ReconnectionAttempts = 5;
+
+            int reconnectingCount = 0;
+            int attempt = 0;
+            int reconnectionErrorCount = 0;
+
+            client.OnReconnecting += (sender, e) =>
+            {
+                reconnectingCount++;
+                attempt = e;
+            };
+
+            client.OnReconnectFailed += (sender, e) =>
+            {
+                reconnectionErrorCount++;
+            };
+
+            await client.ConnectAsync();
+
+            Assert.AreEqual(reconnectingCount, 5);
+            Assert.AreEqual(reconnectionErrorCount, 1);
+            Assert.AreEqual(attempt, 5);
+        }
+
+
         [Timeout(30000)]
         public virtual async Task ManuallyReconnectionTest()
         {

src/SocketIOClient.Test/SocketIOTests/V2/ReconnectionV2NspTest.cs

@@ -31,6 +31,12 @@ public override async Task ReconnectingTest()
             await base.ReconnectingTest();
         }
 
+        [TestMethod]
+        public override async Task ReconnectionAttemptsExceededTest()
+        {
+            await base.ReconnectionAttemptsExceededTest();
+        }
+
         [TestMethod]
         public override async Task ManuallyReconnectionTest()
         {

src/SocketIOClient.Test/SocketIOTests/V2/ReconnectionV2Test.cs

@@ -31,6 +31,12 @@ public override async Task ReconnectingTest()
             await base.ReconnectingTest();
         }
 
+        [TestMethod]
+        public override async Task ReconnectionAttemptsExceededTest()
+        {
+            await base.ReconnectionAttemptsExceededTest();
+        }
+
         [TestMethod]
         public override async Task ManuallyReconnectionTest()
         {

src/SocketIOClient.Test/SocketIOTests/V3/ReconnectionV3NspTest.cs

@@ -31,6 +31,12 @@ public override async Task ReconnectingTest()
             await base.ReconnectingTest();
         }
 
+        [TestMethod]
+        public override async Task ReconnectionAttemptsExceededTest()
+        {
+            await base.ReconnectionAttemptsExceededTest();
+        }
+
         [TestMethod]
         public override async Task ManuallyReconnectionTest()
         {

src/SocketIOClient.Test/SocketIOTests/V3/ReconnectionV3Test.cs

@@ -19,6 +19,12 @@ public override async Task ReconnectionTrueTest()
             await base.ReconnectionTrueTest();
         }
 
+        [TestMethod]
+        public override async Task ReconnectionAttemptsExceededTest()
+        {
+            await base.ReconnectionAttemptsExceededTest();
+        }
+
         [TestMethod]
         public override async Task ReconnectionFalseTest()
         {

src/SocketIOClient.Test/SocketIOTests/V4/ReconnectionV4NspTest.cs

@@ -31,6 +31,12 @@ public override async Task ReconnectingTest()
             await base.ReconnectingTest();
         }
 
+        [TestMethod]
+        public override async Task ReconnectionAttemptsExceededTest()
+        {
+            await base.ReconnectionAttemptsExceededTest();
+        }
+
         [TestMethod]
         public override async Task ManuallyReconnectionTest()
         {

src/SocketIOClient.Test/SocketIOTests/V4/ReconnectionV4Test.cs

@@ -31,6 +31,12 @@ public override async Task ReconnectingTest()
             await base.ReconnectingTest();
         }
 
+        [TestMethod]
+        public override async Task ReconnectionAttemptsExceededTest()
+        {
+            await base.ReconnectionAttemptsExceededTest();
+        }
+
         [TestMethod]
         public override async Task ManuallyReconnectionTest()
         {

src/SocketIOClient/ConnectInterval/DefaultConnectInterval.cs

@@ -1,25 +1,36 @@
-namespace SocketIOClient.ConnectInterval
+using System;
+
+namespace SocketIOClient.ConnectInterval
 {
     class DefaultConnectInterval: IConnectInterval
     {
         public DefaultConnectInterval(SocketIOOptions options)
         {
             this.options = options;
-            delayDouble = options.ReconnectionDelay;
+            this.delay = options.ReconnectionDelay;
         }
 
         readonly SocketIOOptions options;
-        double delayDouble;
+        private double delay;
+        private int attempts = 0;
 
-        public int GetDelay()
+        public double GetDelay()
         {
-            return (int)delayDouble;
+            return this.delay;
         }
 
-        public double NextDealy()
+        public double NextDelay()
         {
-            delayDouble += 2 * options.RandomizationFactor;
-            return delayDouble;
+            this.delay = options.ReconnectionDelay * (long)Math.Pow(2, attempts++);
+            
+            if (this.options.RandomizationFactor > 0) 
+            {
+                Random random = new Random();
+                var deviation = (long)Math.Floor(random.NextDouble() * this.options.RandomizationFactor * options.ReconnectionDelay);
+                this.delay = ((long)Math.Floor(random.NextDouble() * 10) & 1) == 0 ? this.delay - deviation : this.delay + deviation;
+            }
+
+            return this.delay;
         }
     }
 }

src/SocketIOClient/ConnectInterval/IConnectInterval.cs

@@ -2,7 +2,7 @@
 {
     public interface IConnectInterval
     {
-        int GetDelay();
-        double NextDealy();
+        double GetDelay();
+        double NextDelay();
     }
 }