check diags

hanneshayashi · hanneshayashi · commit bf66e42ad07c · 2025-09-03T16:35:23.000+02:00
diff --git a/internal/provider/allocation_resource.go b/internal/provider/allocation_resource.go
@@ -124,7 +124,11 @@ func (r *allocationResource) Read(ctx context.Context, req resource.ReadRequest,
 		)
 		return
 	}
-	state.populate(allocation, ctx)
+	diags = state.populate(allocation, ctx)
+	resp.Diagnostics.Append(diags...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
 
 	// Set refreshed state
 	diags = resp.State.Set(ctx, &state)
@@ -178,7 +182,11 @@ func (r *allocationResource) Update(ctx context.Context, req resource.UpdateRequ
 		)
 		return
 	}
-	state.populate(allocationResponse, ctx)
+	diags = state.populate(allocationResponse, ctx)
+	resp.Diagnostics.Append(diags...)
+	if resp.Diagnostics.HasError() {
+		return
+	}
 
 	// Set refreshed state
 	diags = resp.State.Set(ctx, &state)

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,11 @@ func (r *allocationResource) Read(ctx context.Context, req resource.ReadRequest,`
`124`	`124`	`)`
`125`	`125`	`return`
`126`	`126`	`}`
`127`		`- state.populate(allocation, ctx)`
	`127`	`+ diags = state.populate(allocation, ctx)`
	`128`	`+ resp.Diagnostics.Append(diags...)`
	`129`	`+ if resp.Diagnostics.HasError() {`
	`130`	`+ return`
	`131`	`+ }`
`128`	`132`
`129`	`133`	`// Set refreshed state`
`130`	`134`	`diags = resp.State.Set(ctx, &state)`
`@@ -178,7 +182,11 @@ func (r *allocationResource) Update(ctx context.Context, req resource.UpdateRequ`
`178`	`182`	`)`
`179`	`183`	`return`
`180`	`184`	`}`
`181`		`- state.populate(allocationResponse, ctx)`
	`185`	`+ diags = state.populate(allocationResponse, ctx)`
	`186`	`+ resp.Diagnostics.Append(diags...)`
	`187`	`+ if resp.Diagnostics.HasError() {`
	`188`	`+ return`
	`189`	`+ }`
`182`	`190`
`183`	`191`	`// Set refreshed state`
`184`	`192`	`diags = resp.State.Set(ctx, &state)`