remove unused stuff

kariy · kariy · commit 04d8f162d630 · 2025-11-11T00:08:24.000-05:00
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/executor/benches/execution.rs b/crates/executor/benches/execution.rs
@@ -43,22 +43,22 @@ fn blockifier(
     // convert to blockifier block context
     let block_context = block_context_from_envs(chain_spec, block_envs, None);
 
-    // group.bench_function("Blockifier.Cold", |b| {
-    //     // we need to set up the cached state for each iteration as it's not cloneable
-    //     b.iter_batched(
-    //         || {
-    //             // setup state
-    //             let state = provider.latest().expect("failed to get latest state");
-    //             let state = CachedState::new(StateProviderDb::new(state));
+    group.bench_function("Blockifier.Cold", |b| {
+        // we need to set up the cached state for each iteration as it's not cloneable
+        b.iter_batched(
+            || {
+                // setup state
+                let state = provider.latest().expect("failed to get latest state");
+                let state = CachedState::new(StateProviderDb::new(state));
 
-    //             (state, &block_context, execution_flags, tx.clone())
-    //         },
-    //         |(mut state, block_context, flags, tx)| {
-    //             transact(&mut state, block_context, flags, tx, None)
-    //         },
-    //         BatchSize::SmallInput,
-    //     )
-    // });
+                (state, &block_context, execution_flags, tx.clone())
+            },
+            |(mut state, block_context, flags, tx)| {
+                transact(&mut state, block_context, flags, tx, None)
+            },
+            BatchSize::SmallInput,
+        )
+    });
 }
 
 criterion_group! {
diff --git a/crates/executor/tests/executor.rs b/crates/executor/tests/executor.rs
@@ -92,12 +92,11 @@ fn test_executor_with_valid_blocks_impl(
         .unwrap()
         .expect("storage should exist");
 
-    // assert!(
-    //     updated_main_acc_balance < Felt::from(DEFAULT_PREFUNDED_ACCOUNT_BALANCE),
-    //     "sender balance should decrease"
-    // );
-    // assert_eq!(actual_new_acc_balance, felt!("0x9999999999999999"), "account balance is
-    // updated");
+    assert!(
+        updated_main_acc_balance < Felt::from(DEFAULT_PREFUNDED_ACCOUNT_BALANCE),
+        "sender balance should decrease"
+    );
+    assert_eq!(actual_new_acc_balance, felt!("0x9999999999999999"), "account balance is updated");
 
     // assert that the sierra class is declared
     let expected_class_hash = felt!("0x420");
@@ -161,10 +160,10 @@ fn test_executor_with_valid_blocks_impl(
         .unwrap()
         .expect("storage should exist");
 
-    // assert!(
-    //     updated_new_acc_balance < felt!("0x9999999999999999"),
-    //     "account balance should be updated"
-    // );
+    assert!(
+        updated_new_acc_balance < felt!("0x9999999999999999"),
+        "account balance should be updated"
+    );
 
     // block 3
     //
diff --git a/crates/gateway/gateway-client/src/lib.rs b/crates/gateway/gateway-client/src/lib.rs
@@ -196,17 +196,6 @@ impl Client {
     }
 }
 
-// unknown format:
-// <html><head>
-// <meta http-equiv="content-type" content="text/html;charset=utf-8">
-// <title>502 Server Error</title>
-// </head>
-// <body text=#000000 bgcolor=#ffffff>
-// <h1>Error: Server Error</h1>
-// <h2>The server encountered a temporary error and could not complete your request.<p>Please try
-// again in 30 seconds.</h2> <h2></h2>
-// </body></html>
-
 #[derive(Debug, thiserror::Error)]
 pub enum Error {
     #[error(transparent)]
diff --git a/crates/node/Cargo.toml b/crates/node/Cargo.toml
@@ -30,7 +30,6 @@ katana-tasks.workspace = true
 
 anyhow.workspace = true
 starknet.workspace = true
-num-traits.workspace = true
 futures.workspace = true
 http.workspace = true
 jsonrpsee.workspace = true
diff --git a/crates/rpc/rpc-server/src/starknet/mod.rs b/crates/rpc/rpc-server/src/starknet/mod.rs
@@ -12,7 +12,7 @@ use katana_pool::TransactionPool;
 use katana_primitives::block::{BlockHashOrNumber, BlockIdOrTag, FinalityStatus, GasPrices};
 use katana_primitives::class::{ClassHash, CompiledClass};
 use katana_primitives::contract::{ContractAddress, Nonce, StorageKey, StorageValue};
-use katana_primitives::env::{BlockEnv, VersionedConstantsOverrides};
+use katana_primitives::env::BlockEnv;
 use katana_primitives::event::MaybeForkedContinuationToken;
 use katana_primitives::transaction::{ExecutableTxWithHash, TxHash, TxNumber};
 use katana_primitives::Felt;
diff --git a/crates/storage/provider/provider-api/src/state_update.rs b/crates/storage/provider/provider-api/src/state_update.rs
@@ -18,12 +18,6 @@ pub trait StateUpdateProvider: Send + Sync {
         block_id: BlockHashOrNumber,
     ) -> ProviderResult<Option<BTreeMap<ClassHash, CompiledClassHash>>>;
 
-    /// Returns all declared deprecated class hashes at the given block.
-    fn declared_deprecated_classes(
-        &self,
-        block_id: BlockHashOrNumber,
-    ) -> ProviderResult<Option<Vec<ClassHash>>>;
-
     /// Returns all deployed contracts at the given block.
     fn deployed_contracts(
         &self,
diff --git a/crates/storage/provider/provider/src/lib.rs b/crates/storage/provider/provider/src/lib.rs
@@ -285,13 +285,6 @@ where
         self.provider.declared_classes(block_id)
     }
 
-    fn declared_deprecated_classes(
-        &self,
-        block_id: BlockHashOrNumber,
-    ) -> ProviderResult<Option<Vec<ClassHash>>> {
-        self.provider.declared_deprecated_classes(block_id)
-    }
-
     fn deployed_contracts(
         &self,
         block_id: BlockHashOrNumber,
diff --git a/crates/storage/provider/provider/src/providers/db/mod.rs b/crates/storage/provider/provider/src/providers/db/mod.rs
@@ -409,34 +409,6 @@ impl<Db: Database> StateUpdateProvider for DbProvider<Db> {
         }
     }
 
-    fn declared_deprecated_classes(
-        &self,
-        block_id: BlockHashOrNumber,
-    ) -> ProviderResult<Option<Vec<ClassHash>>> {
-        let db_tx = self.0.tx()?;
-        let block_num = self.block_number_by_id(block_id)?;
-
-        if let Some(block_num) = block_num {
-            let declared_classes = dup_entries::<Db, tables::ClassDeclarations, Vec<ClassHash>, _>(
-                &db_tx,
-                block_num,
-                |entry| {
-                    let (_, class_hash) = entry?;
-                    if db_tx.get::<tables::CompiledClassHashes>(class_hash)?.is_none() {
-                        Ok(Some(class_hash))
-                    } else {
-                        Ok(None)
-                    }
-                },
-            )?;
-
-            db_tx.commit()?;
-            Ok(Some(declared_classes))
-        } else {
-            Ok(None)
-        }
-    }
-
     fn deployed_contracts(
         &self,
         block_id: BlockHashOrNumber,
diff --git a/crates/storage/provider/provider/src/providers/fork/mod.rs b/crates/storage/provider/provider/src/providers/fork/mod.rs
@@ -135,13 +135,6 @@ impl<Db: Database> StateUpdateProvider for ForkedProvider<Db> {
         self.provider.declared_classes(block_id)
     }
 
-    fn declared_deprecated_classes(
-        &self,
-        block_id: BlockHashOrNumber,
-    ) -> ProviderResult<Option<Vec<ClassHash>>> {
-        self.provider.declared_deprecated_classes(block_id)
-    }
-
     fn deployed_contracts(
         &self,
         block_id: BlockHashOrNumber,
diff --git a/crates/storage/provider/provider/src/test_utils.rs b/crates/storage/provider/provider/src/test_utils.rs
@@ -19,7 +19,7 @@ pub fn test_provider() -> DbProvider {
 
 /// Initializes the provider with a genesis block and states.
 fn initialize_test_provider<P: BlockWriter>(provider: &P) {
-    let chain = get_chain_for_testing();
+    let chain = create_chain_for_testing();
 
     let hash = BlockHash::ZERO;
     let status = FinalityStatus::AcceptedOnL2;
@@ -34,7 +34,7 @@ fn initialize_test_provider<P: BlockWriter>(provider: &P) {
 /// Creates a genesis config specifically for testing purposes.
 /// This includes:
 /// - An account with simple `__execute__` function, deployed at address `0x1`.
-pub fn get_chain_for_testing() -> katana_chain_spec::dev::ChainSpec {
+fn create_chain_for_testing() -> katana_chain_spec::dev::ChainSpec {
     let mut chain = katana_chain_spec::dev::DEV_UNALLOCATED.clone();
 
     let class_hash = felt!("0x111");
diff --git a/crates/sync/stage/Cargo.toml b/crates/sync/stage/Cargo.toml
@@ -12,7 +12,6 @@ katana-gateway-client.workspace = true
 katana-gateway-types.workspace = true
 katana-messaging.workspace = true
 katana-pool.workspace = true
-katana-trie.workspace = true
 katana-primitives.workspace = true
 katana-provider.workspace = true
 katana-rpc-types.workspace = true
diff --git a/crates/sync/stage/tests/trie.rs b/crates/sync/stage/tests/trie.rs
@@ -101,13 +101,6 @@ impl StateUpdateProvider for MockProvider {
         Ok(None)
     }
 
-    fn declared_deprecated_classes(
-        &self,
-        block_id: BlockHashOrNumber,
-    ) -> ProviderResult<Option<Vec<ClassHash>>> {
-        Ok(None)
-    }
-
     fn deployed_contracts(
         &self,
         _block_id: BlockHashOrNumber,
