refactor(primitives): define felt! macro locally (#390)

This change is part of the effort to remove the dependency on the `starknet` crate by introducing a local crate that provides the `felt!` macro, instead of relying on the one provided by the `starknet` crate.

Author: kariy

Cargo.lock

@@ -24,6 +24,7 @@ members = [
 	"crates/pool/pool",
 	"crates/pool/pool-api",
 	"crates/primitives",
+	"crates/primitives/macro",
 	"crates/rpc/rpc-server",
 	"crates/rpc/rpc-api",
 	"crates/rpc/rpc-client",
@@ -94,6 +95,7 @@ katana-pipeline = { path = "crates/sync/pipeline" }
 katana-pool = { path = "crates/pool/pool" }
 katana-pool-api = { path = "crates/pool/pool-api" }
 katana-primitives = { path = "crates/primitives" }
+katana-primitives-macro = { path = "crates/primitives/macro" }
 katana-provider = { path = "crates/storage/provider/provider" }
 katana-provider-api = { path = "crates/storage/provider/provider-api" }
 katana-rpc-server = { path = "crates/rpc/rpc-server" }

Cargo.toml

@@ -74,7 +74,7 @@ pub struct GetAccountCalldataResponse {
 
 #[cfg(test)]
 mod tests {
-    use katana_primitives::{address, ContractAddress};
+    use katana_primitives::address;
 
     use super::*;
 

crates/cartridge/src/client.rs

@@ -556,7 +556,7 @@ mod test {
     };
     use katana_node::config::rpc::RpcModuleKind;
     use katana_primitives::chain::ChainId;
-    use katana_primitives::{address, felt, ContractAddress, Felt};
+    use katana_primitives::{address, felt, Felt};
 
     use super::*;
 

crates/cli/src/args.rs

@@ -156,7 +156,7 @@ mod tests {
     use blockifier::state::cached_state::{self};
     use katana_primitives::class::ContractClass;
     use katana_primitives::execution::FunctionCall;
-    use katana_primitives::{address, felt, ContractAddress};
+    use katana_primitives::{address, felt};
     use katana_provider::api::contract::ContractClassWriter;
     use katana_provider::api::state::{StateFactoryProvider, StateWriter};
     use katana_provider::{test_utils, ProviderFactory};

crates/executor/src/implementation/blockifier/call.rs

@@ -9,7 +9,6 @@ use katana_genesis::constant::{
     DEFAULT_ETH_FEE_TOKEN_ADDRESS, DEFAULT_PREFUNDED_ACCOUNT_BALANCE, DEFAULT_UDC_ADDRESS,
 };
 use katana_primitives::block::ExecutableBlock;
-use katana_primitives::contract::ContractAddress;
 use katana_primitives::transaction::TxWithHash;
 use katana_primitives::{address, Felt};
 use katana_provider::api::contract::ContractClassProviderExt;

crates/executor/tests/executor.rs

@@ -409,7 +409,7 @@ impl From<ExecutionResources> for katana_primitives::receipt::ExecutionResources
 #[cfg(test)]
 mod from_primitives_test {
     use katana_primitives::transaction::TxWithHash;
-    use katana_primitives::{address, felt, ContractAddress};
+    use katana_primitives::{address, felt};
     use katana_utils::arbitrary;
 
     use super::*;
@@ -735,7 +735,6 @@ mod from_primitives_test {
 mod from_rpc_test {
     use std::collections::{BTreeMap, BTreeSet};
 
-    use katana_primitives::contract::ContractAddress;
     use katana_primitives::{address, felt};
 
     use crate::{DeclaredContract, StateDiff};

crates/gateway/gateway-types/src/conversion.rs

@@ -5,7 +5,7 @@ use katana_gateway_types::{
     StateDiff, StorageDiff,
 };
 use katana_primitives::execution::BuiltinName;
-use katana_primitives::{address, eth_address, felt, ContractAddress};
+use katana_primitives::{address, eth_address, felt};
 use serde_json::json;
 
 #[test]

crates/gateway/gateway-types/tests/types.rs

@@ -7,11 +7,14 @@ version.workspace = true
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
+katana-primitives-macro.workspace = true
+
 cairo-vm.workspace = true
 cairo-lang-sierra.workspace = true
 cairo-lang-utils.workspace = true
 cairo-lang-starknet-classes.workspace = true
 
+
 anyhow.workspace = true
 arbitrary = { workspace = true, optional = true }
 blockifier = { workspace = true, features = [ "testing" ] } # some Clone derives are gated behind 'testing' feature

crates/primitives/Cargo.toml

@@ -0,0 +1,15 @@
+[package]
+description = "Procedural macros for katana-primitives"
+edition.workspace = true
+name = "katana-primitives-macro"
+version.workspace = true
+
+[lib]
+proc-macro = true
+
+[dependencies]
+proc-macro2.workspace = true
+quote.workspace = true
+syn = { workspace = true, features = ["parsing", "proc-macro"] }
+
+starknet-types-core.workspace = true