hotfix for invalid hash computation due to stupid abi formatting bcs the abi is an arbitrary string

Author: kariy

crates/rpc/rpc-types/src/class.rs

@@ -7,7 +7,8 @@ use std::io::{self, Write};
 use cairo_lang_starknet_classes::contract_class::ContractEntryPoints;
 use cairo_lang_utils::bigint::BigUintAsHex;
 use katana_primitives::class::{
-    compute_sierra_class_hash, ClassHash, ContractClass, LegacyContractClass, SierraContractClass,
+    compute_legacy_class_hash, compute_sierra_class_hash, ClassHash, ComputeClassHashError,
+    ContractClass, LegacyContractClass, SierraContractClass,
 };
 use katana_primitives::{
     Felt, {self},
@@ -34,6 +35,15 @@ pub enum Class {
     Legacy(RpcLegacyContractClass),
 }
 
+impl Class {
+    pub fn hash(&self) -> ClassHash {
+        match self {
+            Class::Sierra(class) => class.hash(),
+            Class::Legacy(class) => class.hash().unwrap(),
+        }
+    }
+}
+
 #[derive(Debug, thiserror::Error)]
 pub enum ConversionError {
     #[error(transparent)]
@@ -119,6 +129,12 @@ pub struct RpcLegacyContractClass {
     pub abi: Option<Vec<ContractClassAbiEntry>>,
 }
 
+impl RpcLegacyContractClass {
+    pub fn hash(&self) -> Result<ClassHash, ComputeClassHashError> {
+        compute_legacy_class_hash(&LegacyContractClass::try_from(self.clone()).unwrap())
+    }
+}
+
 //////////////////////////////////////////////////
 // LegacyClass implementations
 //////////////////////////////////////////////////

crates/sync/stage/src/classes.rs

@@ -93,14 +93,9 @@ impl<P> Classes<P> {
                 .zip(class_artifacts.into_par_iter())
                 .map(|(key, gateway_class)| {
                     let block = key.block;
-                    let expected_hash = key.class_hash;
-
-                    let class: ContractClass =
-                        gateway_class.try_into().map_err(Error::Conversion)?;
 
-                    let computed_hash = class.class_hash().map_err(|source| {
-                        Error::ClassHashComputation { class_hash: expected_hash, source, block }
-                    })?;
+                    let expected_hash = key.class_hash;
+                    let computed_hash = gateway_class.hash();
 
                     if computed_hash != expected_hash {
                         return Err(Error::ClassHashMismatch {
@@ -110,7 +105,7 @@ impl<P> Classes<P> {
                         });
                     }
 
-                    Ok(class)
+                    Ok(ContractClass::try_from(gateway_class).map_err(Error::Conversion)?)
                 })
                 .collect::<Result<Vec<_>, Error>>();