fix(provider): historical provider doesn't respect pinned block number#360
Merged
fix(provider): historical provider doesn't respect pinned block number#360
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 73.32% 73.76% +0.44%
==========================================
Files 209 256 +47
Lines 23132 31418 +8286
==========================================
+ Hits 16961 23177 +6216
- Misses 6171 8241 +2070 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chudkowsky
pushed a commit
that referenced
this pull request
Nov 18, 2025
#360) The fork version of the `HistoricalStateProvider` should falls back to requesting data from the forked network ONLY when the pinned block number (i.e., the block number the `HistoricalStateProvider` is created for - the `block_id` given to `<ForkedProvider as StateFactoryProvider>::historical`) is less than or equal to the block number which katana is forked at. Currently, `HistoricalStateProvider` would immediately falls back to the forked network. The request is then handled by the `Backend` and `Backend` is pinned to the forked block number and not the block number the state provider is for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fork version of the
HistoricalStateProvidershould falls back to requesting data from the forked network ONLY when the pinned block number (i.e., the block number theHistoricalStateProvideris created for - theblock_idgiven to<ForkedProvider as StateFactoryProvider>::historical) is less than or equal to the block number which katana is forked at.Currently,
HistoricalStateProviderwould immediately falls back to the forked network. The request is then handled by theBackendandBackendis pinned to the forked block number and not the block number the state provider is for.